[jira] [Updated] (LUCENE-4981) Deprecate PositionFilter
[ https://issues.apache.org/jira/browse/LUCENE-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Rowe updated LUCENE-4981: --- Fix Version/s: 4.4 > Deprecate PositionFilter > > > Key: LUCENE-4981 > URL: https://issues.apache.org/jira/browse/LUCENE-4981 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Fix For: 4.4 > > Attachments: LUCENE-4981.patch, LUCENE-4981.patch > > > According to the documentation > (http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters#solr.PositionFilterFactory), > PositionFilter is mainly useful to make query parsers generate boolean > queries instead of phrase queries although this problem can be solved at > query parsing level instead of analysis level (eg. using > QueryParser.setAutoGeneratePhraseQueries). > So given that PositionFilter corrupts token graphs (see TestRandomChains), I > propose to deprecate it. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4981) Deprecate PositionFilter
[ https://issues.apache.org/jira/browse/LUCENE-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-4981: - Attachment: LUCENE-4981.patch Thanks for your feedback Steve. I updated the patch to say that the problems that were solved by PositionFilter should be solved at query parsing level, does it look better? > Deprecate PositionFilter > > > Key: LUCENE-4981 > URL: https://issues.apache.org/jira/browse/LUCENE-4981 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-4981.patch, LUCENE-4981.patch > > > According to the documentation > (http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters#solr.PositionFilterFactory), > PositionFilter is mainly useful to make query parsers generate boolean > queries instead of phrase queries although this problem can be solved at > query parsing level instead of analysis level (eg. using > QueryParser.setAutoGeneratePhraseQueries). > So given that PositionFilter corrupts token graphs (see TestRandomChains), I > propose to deprecate it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4981) Deprecate PositionFilter
[ https://issues.apache.org/jira/browse/LUCENE-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-4981: - Attachment: LUCENE-4981.patch Here is the patch for 4.x. The patch for trunk is simpler as PositionFilter and PositionFilterFactory would simply be removed. > Deprecate PositionFilter > > > Key: LUCENE-4981 > URL: https://issues.apache.org/jira/browse/LUCENE-4981 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-4981.patch > > > According to the documentation > (http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters#solr.PositionFilterFactory), > PositionFilter is mainly useful to make query parsers generate boolean > queries instead of phrase queries although this problem can be solved at > query parsing level instead of analysis level (eg. using > QueryParser.setAutoGeneratePhraseQueries). > So given that PositionFilter corrupts token graphs (see TestRandomChains), I > propose to deprecate it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
