[
https://issues.apache.org/jira/browse/LUCENE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Furkan KAMACI updated LUCENE-5512:
--
Attachment: LUCENE-5512.patch
I've finished removing redundant typing for trunk. 1221 files has affected from
my patch. I've done it for both Lucene and Solr modules.
I didn't use any automated tools for it and I've changed even the commented
codes to avoid confusion.
After I finished removing redundant typing I have reviewed all my changes
inside 1221 files and everything seems OK. Code is compiled successfully and
all tests are passed.
My suggestion is that: if the voting ends up and result is OK to support Java 7
we should apply this patch into trunk as soon as possible. Because it includes
many changes and it make Lucene/Solr code much more readable. On the other hand
I don't think that it will cause conflict (at least any real conflict) for
people who develops code right now.
All in all I could have a chance to check nearly all classes of project and it
was really good for me. I've noted some issues about project noted some good
tips for me when I was checking all the Lucene/Solr project.
[~rcmuir] you can check the code and apply the patch if vote passes.
Remove redundant typing (diamond operator) in trunk
---
Key: LUCENE-5512
URL: https://issues.apache.org/jira/browse/LUCENE-5512
Project: Lucene - Core
Issue Type: Improvement
Reporter: Robert Muir
Attachments: LUCENE-5512.patch, LUCENE-5512.patch, LUCENE-5512.patch
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
