[jira] [Updated] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir
[
https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Ernst updated LUCENE-5650:
---
Attachment: dih.patch
Looks like we overlapped on fixing these. I like how you handle velocity
better than me (I hacked through a way to set the log file). But I'm not sure
I like the DIH change. I think it is bogus to default to the CWD if running
without a core (which seems to only happen in tests?). I changed this to
default to solr.solr.home, then set this to a temp dir in the abstract DIH test
base (see attached patch).
createTempDir and associated functions no longer create java.io.tmpdir
--
Key: LUCENE-5650
URL: https://issues.apache.org/jira/browse/LUCENE-5650
Project: Lucene - Core
Issue Type: Improvement
Components: general/test
Reporter: Ryan Ernst
Assignee: Dawid Weiss
Priority: Minor
Fix For: 4.9, 5.0
Attachments: LUCENE-5650.patch, LUCENE-5650.patch, LUCENE-5650.patch,
LUCENE-5650.patch, dih.patch
The recent refactoring to all the create temp file/dir functions (which is
great!) has a minor regression from what existed before. With the old
{{LuceneTestCase.TEMP_DIR}}, the directory was created if it did not exist.
So, if you set {{java.io.tmpdir}} to {{./temp}}, then it would create that
dir within the per jvm working dir. However, {{getBaseTempDirForClass()}}
now does asserts that check the dir exists, is a dir, and is writeable.
Lucene uses {{.}} as {{java.io.tmpdir}}. Then in the test security
manager, the per jvm cwd has read/write/execute permissions. However, this
allows tests to write to their cwd, which I'm trying to protect against (by
setting cwd to read/execute in my test security manager).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir
[
https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Ernst updated LUCENE-5650:
---
Attachment: LUCENE-5650.patch
New patch. All tests pass.
I fixed SOLR-6055 in this by adding a separate update log dir to SolrCore,
which is independently forced to be absolute (for the local filesystem, not the
DirectoryFactory). I also made the javaTempDir in the new test rule always
absolute so that the ulog isAbsolute check would work.
createTempDir and associated functions no longer create java.io.tmpdir
--
Key: LUCENE-5650
URL: https://issues.apache.org/jira/browse/LUCENE-5650
Project: Lucene - Core
Issue Type: Improvement
Components: general/test
Reporter: Ryan Ernst
Assignee: Dawid Weiss
Priority: Minor
Fix For: 4.9, 5.0
Attachments: LUCENE-5650.patch, LUCENE-5650.patch, LUCENE-5650.patch,
LUCENE-5650.patch
The recent refactoring to all the create temp file/dir functions (which is
great!) has a minor regression from what existed before. With the old
{{LuceneTestCase.TEMP_DIR}}, the directory was created if it did not exist.
So, if you set {{java.io.tmpdir}} to {{./temp}}, then it would create that
dir within the per jvm working dir. However, {{getBaseTempDirForClass()}}
now does asserts that check the dir exists, is a dir, and is writeable.
Lucene uses {{.}} as {{java.io.tmpdir}}. Then in the test security
manager, the per jvm cwd has read/write/execute permissions. However, this
allows tests to write to their cwd, which I'm trying to protect against (by
setting cwd to read/execute in my test security manager).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir
[
https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-5650:
Attachment: LUCENE-5650.patch
This is an adjustment to Ryan's patch. I moved a lot of the temp-file related
code out of LuceneTestCase (leaving appropriate delegate calls to the rule code
and its logic).
A side-effect of this is that temp. dir gets created before any test code below
the rule is executed. This helps hunspell tests.
All Lucene test pass. Solr's does have a few offenders still; haven't looked at
them yet.
createTempDir and associated functions no longer create java.io.tmpdir
--
Key: LUCENE-5650
URL: https://issues.apache.org/jira/browse/LUCENE-5650
Project: Lucene - Core
Issue Type: Improvement
Components: general/test
Reporter: Ryan Ernst
Assignee: Dawid Weiss
Priority: Minor
Fix For: 4.9, 5.0
Attachments: LUCENE-5650.patch, LUCENE-5650.patch
The recent refactoring to all the create temp file/dir functions (which is
great!) has a minor regression from what existed before. With the old
{{LuceneTestCase.TEMP_DIR}}, the directory was created if it did not exist.
So, if you set {{java.io.tmpdir}} to {{./temp}}, then it would create that
dir within the per jvm working dir. However, {{getBaseTempDirForClass()}}
now does asserts that check the dir exists, is a dir, and is writeable.
Lucene uses {{.}} as {{java.io.tmpdir}}. Then in the test security
manager, the per jvm cwd has read/write/execute permissions. However, this
allows tests to write to their cwd, which I'm trying to protect against (by
setting cwd to read/execute in my test security manager).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir
[
https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Ernst updated LUCENE-5650:
---
Attachment: LUCENE-5650.patch
Thanks Dawid, your refactorings look good.
This patch adds fixes for the solr tests. There is one nocommit for SOLR-6055.
createTempDir and associated functions no longer create java.io.tmpdir
--
Key: LUCENE-5650
URL: https://issues.apache.org/jira/browse/LUCENE-5650
Project: Lucene - Core
Issue Type: Improvement
Components: general/test
Reporter: Ryan Ernst
Assignee: Dawid Weiss
Priority: Minor
Fix For: 4.9, 5.0
Attachments: LUCENE-5650.patch, LUCENE-5650.patch, LUCENE-5650.patch
The recent refactoring to all the create temp file/dir functions (which is
great!) has a minor regression from what existed before. With the old
{{LuceneTestCase.TEMP_DIR}}, the directory was created if it did not exist.
So, if you set {{java.io.tmpdir}} to {{./temp}}, then it would create that
dir within the per jvm working dir. However, {{getBaseTempDirForClass()}}
now does asserts that check the dir exists, is a dir, and is writeable.
Lucene uses {{.}} as {{java.io.tmpdir}}. Then in the test security
manager, the per jvm cwd has read/write/execute permissions. However, this
allows tests to write to their cwd, which I'm trying to protect against (by
setting cwd to read/execute in my test security manager).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
