[jira] [Updated] (LUCENE-6226) Allow TermScorer to expose positions, offsets and payloads
[ https://issues.apache.org/jira/browse/LUCENE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6226: -- Attachment: LUCENE-6226.patch Here's an up-to-date patch. TermScorer and the various BooleanScorers implement Scorer.intervals(). I've added three new queries, OrderedNearQuery, NonOverlappingQuery and RangeFilterQuery which make use of these. There is still a nocommit, regarding Explanations on IntervalWeight, and I'll want to add some QueryUtils checks as well, but I wanted to get some feedback on this API. > Allow TermScorer to expose positions, offsets and payloads > -- > > Key: LUCENE-6226 > URL: https://issues.apache.org/jira/browse/LUCENE-6226 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.1 > > Attachments: LUCENE-6226.patch, LUCENE-6226.patch, LUCENE-6226.patch, > LUCENE-6226.patch, LUCENE-6226.patch, LUCENE-6226.patch, LUCENE-6226.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6226) Allow TermScorer to expose positions, offsets and payloads
[ https://issues.apache.org/jira/browse/LUCENE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6226: -- Attachment: LUCENE-6226.patch New patch. Rather than getting positions directly from the Scorer, this goes back to Simon's original idea of having a separate per-scorer IntervalIterator. We have an IntervalQuery that will match a document if it's child scorers produce any matching intervals, and the notion of an IntervalFilter that allows you to select which intervals match. Query.createWeight() and IndexSearcher.createNormalizedWeight() take an enum based on Adrien's idea. Scorers that don't support iterators (which at the moment is all of them except TermScorer) throw an IllegalArgumentException. TermWeight.scorer() will throw an IllegalStateException if the weight has been created with DOCS_AND_SCORES_AND_POSITIONS but no positions were indexed. > Allow TermScorer to expose positions, offsets and payloads > -- > > Key: LUCENE-6226 > URL: https://issues.apache.org/jira/browse/LUCENE-6226 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.1 > > Attachments: LUCENE-6226.patch, LUCENE-6226.patch, LUCENE-6226.patch, > LUCENE-6226.patch, LUCENE-6226.patch, LUCENE-6226.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6226) Allow TermScorer to expose positions, offsets and payloads
[ https://issues.apache.org/jira/browse/LUCENE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6226: -- Attachment: LUCENE-6226.patch Updated patch, using a new PostingsFeatures enum instead of a bitmask. I tried using the already-existing IndexOptions, but it doesn't deal with payloads directly - maybe we could look at merging the two enums later on? > Allow TermScorer to expose positions, offsets and payloads > -- > > Key: LUCENE-6226 > URL: https://issues.apache.org/jira/browse/LUCENE-6226 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.1 > > Attachments: LUCENE-6226.patch, LUCENE-6226.patch, LUCENE-6226.patch, > LUCENE-6226.patch, LUCENE-6226.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6226) Allow TermScorer to expose positions, offsets and payloads
[ https://issues.apache.org/jira/browse/LUCENE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6226: -- Attachment: LUCENE-6226.patch Final patch, fixes a couple of Solr tests. Passes precommit. I think it's ready? > Allow TermScorer to expose positions, offsets and payloads > -- > > Key: LUCENE-6226 > URL: https://issues.apache.org/jira/browse/LUCENE-6226 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.1 > > Attachments: LUCENE-6226.patch, LUCENE-6226.patch, LUCENE-6226.patch, > LUCENE-6226.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6226) Allow TermScorer to expose positions, offsets and payloads
[ https://issues.apache.org/jira/browse/LUCENE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6226: -- Attachment: LUCENE-6226.patch You're right, I'm getting ahead of myself here. We don't need to worry about positions being exhausted until we have queries that use subscorer positions and can't call freq() up front. Here's an amended patch that removes the upto tracking from TermScorer and reverts the changes to Collector. > Allow TermScorer to expose positions, offsets and payloads > -- > > Key: LUCENE-6226 > URL: https://issues.apache.org/jira/browse/LUCENE-6226 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.1 > > Attachments: LUCENE-6226.patch, LUCENE-6226.patch, LUCENE-6226.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6226) Allow TermScorer to expose positions, offsets and payloads
[ https://issues.apache.org/jira/browse/LUCENE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6226: -- Attachment: LUCENE-6226.patch Previous patch only changed lucene-core, this one catches all the other modules as well. > Allow TermScorer to expose positions, offsets and payloads > -- > > Key: LUCENE-6226 > URL: https://issues.apache.org/jira/browse/LUCENE-6226 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.1 > > Attachments: LUCENE-6226.patch, LUCENE-6226.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6226) Allow TermScorer to expose positions, offsets and payloads
[ https://issues.apache.org/jira/browse/LUCENE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6226: -- Attachment: LUCENE-6226.patch > Allow TermScorer to expose positions, offsets and payloads > -- > > Key: LUCENE-6226 > URL: https://issues.apache.org/jira/browse/LUCENE-6226 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Fix For: Trunk, 5.1 > > Attachments: LUCENE-6226.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org