[jira] [Updated] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7918: - Attachment: (was: LUCENE-7918.patch) > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7918: - Attachment: LUCENE-7918.patch New version attached with "lucene-experimental" for public classes and "lucene-internal" for protected ones. The casting of Geopolygon is removed from the test. No warnings when compiling and precommit seems happy. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7918: - Attachment: (was: LUCENE-7918.patch) > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7918: - Attachment: LUCENE-7918.patch Hi [~daddywri], thanks for the tips. I was able to run precommit and actually had a hard time to make it succeed. It seems I had to declare public the abstract class GeoBaseCompositeShape. This is because it holds the ublic methods for a composite. Maybe we should add a new class called GeoComposite with those methods and then have the abstract class protected. Attached new patch that should pass precommit. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7918: - Attachment: LUCENE-7918.patch Hi [~daddywri], I am sorry of hearing that. I will be running the precommit in this patch although it seems I am getting the same errors as you are getting (Lots of Unescaped symbol "->" on line #). I will try to see if I can fix it somewhat. I think I found a good solution. I am using Generic abstract classes and the exposing in the API the concretization of those classes. I attach the solution in case you have any comments. I wonder if it makes sense to have a generic interface for those composite classes Another issue I am having, is that I am not sure what I should do with the toString() methods. Thanks again! Ignacio > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
