[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[
https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-10494:
Attachment: SOLR-10494.patch
bq. ...I'm pretty sure the root problem here is that with the change to default
to indent=true, really deep XML docs are including more newlines in places they
weren't before, and that's causing some bugs in the SOlrJ XMLResponseParse ...
The scope of the bug was much more narrow then i realized: it *only* affected
nested child docs when {{indent=true}} (newlines had nothing to do with it) --
fixed now in SOLR-11136.
bq. I tried to debug theTestHierarchicalDocBuilder.testThreeLevelHierarchy test
failure, and I see that the test data is different but that may be the
intention, to randomize the hierarchy.
that failure is actually really simple: the xpath is badly written. it's using
syntax like {{/arr\[@name='id' and .='"+parentId1+"']}} which only works if
*all* of the accumlated text data inside the {{}} equal {{parentId}} after
they've been concatenated -- but when {{indent=true}} there are additional
(whitespace) text data nodes in the DOM before and after the {{...}}.
In the attached path i simplified & tightened up these xpaths to be explicit
about looking for the {{...}} content.
(NOTE: still haven't actaully reviewed the patch, just focused on getting the
tests to pass)
> Switch Solr's Default Response Type from XML to JSON
>
>
> Key: SOLR-10494
> URL: https://issues.apache.org/jira/browse/SOLR-10494
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Affects Versions: 7.0
>Reporter: Trey Grainger
>Priority: Blocker
> Fix For: 7.0
>
> Attachments: SOLR-10494, SOLR-10494, SOLR-10494.branch_7x.patch,
> SOLR-10494.patch, SOLR-10494.patch, SOLR-10494.patch,
> SOLR-10494-withdocs.patch, SOLR-10494-withdocs.patch
>
>
> Solr's default response format is still XML, despite the fact that Solr has
> supported the JSON response format for over a decade, developer mindshare has
> clearly shifted toward JSON over the years, and most modern/competing systems
> also use JSON format now by default.
> In fact, Solr's admin UI even explicitly adds wt=json to the request (by
> default in the UI) to override the default of wt=xml, so Solr's Admin UI
> effectively has a different default than the API.
> We have now introduced things like the JSON faceting API, and the new more
> modern /V2 apis assume JSON for the areas of Solr they cover, so clearly
> we're moving in the direction of JSON anyway.
> I'd like propose that we switch the default response writer to JSON (wt=json)
> instead of XML for Solr 7.0, as this seems to me like the right direction and
> a good time to make this change with the next major version.
> Based upon feedback from the Lucene Dev's mailing list, we want to:
> 1) Change the default response writer type to "wt=json" and also change to
> "indent=on" by default
> 2) Make no changes on the update handler side; it already works as desired
> (it returns the response in the same content-type as the request unless the
> "wt" is passed in explicitly).
> 3) Keep the /query request handler around since people have already used it
> for years to do JSON queries
> 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks
> on how to change (back) the response format.
> The default format change, plus the addition of "indent=on" are back compat
> changes, so we need to make sure we doc those clearly in the CHANGES.txt.
> There will also need to be significant adjustments to the Solr Ref Guide,
> Tutorial, etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-10494: Attachment: SOLR-10494.patch Here's an update patch against master (58358099bf72b) ... most of the conflicts were in the ref guide, and i'm pretty sure i captured the intent of all the cahnges -- but i haven't reviewed that part in depth. In truth, i haven't reviewed much of the patch at all -- i've been looking into the test failures. I'm pretty sure the root problem here is that with the change to default to indent=true, really deep XML docs are including more newlines in places they weren't before, and that's causing some bugs in the SOlrJ XMLResponseParser because i _think_ it causes the XMLStreamReader to consider that "non-ignorable" whitespace so it's returning it as CHARACTER data in places where the parser doesn't expect CHARACTER data. this seems like a legic bug that we should fix as a blocker to making these changes -- i'll dig in more and file a new jira once i have a more concrete diagnoses > Switch Solr's Default Response Type from XML to JSON > > > Key: SOLR-10494 > URL: https://issues.apache.org/jira/browse/SOLR-10494 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 7.0 >Reporter: Trey Grainger >Priority: Blocker > Fix For: 7.0 > > Attachments: SOLR-10494, SOLR-10494, SOLR-10494.branch_7x.patch, > SOLR-10494.patch, SOLR-10494.patch, SOLR-10494-withdocs.patch, > SOLR-10494-withdocs.patch > > > Solr's default response format is still XML, despite the fact that Solr has > supported the JSON response format for over a decade, developer mindshare has > clearly shifted toward JSON over the years, and most modern/competing systems > also use JSON format now by default. > In fact, Solr's admin UI even explicitly adds wt=json to the request (by > default in the UI) to override the default of wt=xml, so Solr's Admin UI > effectively has a different default than the API. > We have now introduced things like the JSON faceting API, and the new more > modern /V2 apis assume JSON for the areas of Solr they cover, so clearly > we're moving in the direction of JSON anyway. > I'd like propose that we switch the default response writer to JSON (wt=json) > instead of XML for Solr 7.0, as this seems to me like the right direction and > a good time to make this change with the next major version. > Based upon feedback from the Lucene Dev's mailing list, we want to: > 1) Change the default response writer type to "wt=json" and also change to > "indent=on" by default > 2) Make no changes on the update handler side; it already works as desired > (it returns the response in the same content-type as the request unless the > "wt" is passed in explicitly). > 3) Keep the /query request handler around since people have already used it > for years to do JSON queries > 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks > on how to change (back) the response format. > The default format change, plus the addition of "indent=on" are back compat > changes, so we need to make sure we doc those clearly in the CHANGES.txt. > There will also need to be significant adjustments to the Solr Ref Guide, > Tutorial, etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trey Grainger updated SOLR-10494: - Attachment: SOLR-10494.branch_7x.patch Here's the most up-to-date patch against branch_7x. > Switch Solr's Default Response Type from XML to JSON > > > Key: SOLR-10494 > URL: https://issues.apache.org/jira/browse/SOLR-10494 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 7.0 >Reporter: Trey Grainger >Priority: Blocker > Fix For: 7.0 > > Attachments: SOLR-10494, SOLR-10494, SOLR-10494.branch_7x.patch, > SOLR-10494.patch, SOLR-10494-withdocs.patch, SOLR-10494-withdocs.patch > > > Solr's default response format is still XML, despite the fact that Solr has > supported the JSON response format for over a decade, developer mindshare has > clearly shifted toward JSON over the years, and most modern/competing systems > also use JSON format now by default. > In fact, Solr's admin UI even explicitly adds wt=json to the request (by > default in the UI) to override the default of wt=xml, so Solr's Admin UI > effectively has a different default than the API. > We have now introduced things like the JSON faceting API, and the new more > modern /V2 apis assume JSON for the areas of Solr they cover, so clearly > we're moving in the direction of JSON anyway. > I'd like propose that we switch the default response writer to JSON (wt=json) > instead of XML for Solr 7.0, as this seems to me like the right direction and > a good time to make this change with the next major version. > Based upon feedback from the Lucene Dev's mailing list, we want to: > 1) Change the default response writer type to "wt=json" and also change to > "indent=on" by default > 2) Make no changes on the update handler side; it already works as desired > (it returns the response in the same content-type as the request unless the > "wt" is passed in explicitly). > 3) Keep the /query request handler around since people have already used it > for years to do JSON queries > 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks > on how to change (back) the response format. > The default format change, plus the addition of "indent=on" are back compat > changes, so we need to make sure we doc those clearly in the CHANGES.txt. > There will also need to be significant adjustments to the Solr Ref Guide, > Tutorial, etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-10494: - Component/s: Response Writers > Switch Solr's Default Response Type from XML to JSON > > > Key: SOLR-10494 > URL: https://issues.apache.org/jira/browse/SOLR-10494 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 7.0 >Reporter: Trey Grainger >Priority: Blocker > Fix For: 7.0 > > Attachments: SOLR-10494, SOLR-10494, SOLR-10494.patch, > SOLR-10494-withdocs.patch, SOLR-10494-withdocs.patch > > > Solr's default response format is still XML, despite the fact that Solr has > supported the JSON response format for over a decade, developer mindshare has > clearly shifted toward JSON over the years, and most modern/competing systems > also use JSON format now by default. > In fact, Solr's admin UI even explicitly adds wt=json to the request (by > default in the UI) to override the default of wt=xml, so Solr's Admin UI > effectively has a different default than the API. > We have now introduced things like the JSON faceting API, and the new more > modern /V2 apis assume JSON for the areas of Solr they cover, so clearly > we're moving in the direction of JSON anyway. > I'd like propose that we switch the default response writer to JSON (wt=json) > instead of XML for Solr 7.0, as this seems to me like the right direction and > a good time to make this change with the next major version. > Based upon feedback from the Lucene Dev's mailing list, we want to: > 1) Change the default response writer type to "wt=json" and also change to > "indent=on" by default > 2) Make no changes on the update handler side; it already works as desired > (it returns the response in the same content-type as the request unless the > "wt" is passed in explicitly). > 3) Keep the /query request handler around since people have already used it > for years to do JSON queries > 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks > on how to change (back) the response format. > The default format change, plus the addition of "indent=on" are back compat > changes, so we need to make sure we doc those clearly in the CHANGES.txt. > There will also need to be significant adjustments to the Solr Ref Guide, > Tutorial, etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trey Grainger updated SOLR-10494: - Attachment: SOLR-10494.patch Ok, I think I'm nearly done. This patch includes removing all the extraneous "wt=json" and "indent=on" references, adding a commented out version of "wt=xml" to the example solrconfig.xml's, unit test updates, some additional updates to the tutorials and docs (also incorporating [~ctargett]'s), and updating the admin UI (query section) to handle the new defaults. The only issue I'm running into is that for some reason I haven't figured out yet, turning "indent" on has broken some of the parent/child relationship tests (i.e. TestHierarchicalDocBuilder.testThreeLevelHierarchy, SolrExampleTests.testChildDocTransformer. It initially appears to be some xml parsing issue issue with the extra whitespace, which would be odd, but I haven't dug in yet. Once I figure those out, I'll update the patch, and then I think this will be ready for review. > Switch Solr's Default Response Type from XML to JSON > > > Key: SOLR-10494 > URL: https://issues.apache.org/jira/browse/SOLR-10494 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (7.0) >Reporter: Trey Grainger >Priority: Blocker > Fix For: master (7.0) > > Attachments: SOLR-10494, SOLR-10494, SOLR-10494.patch, > SOLR-10494-withdocs.patch, SOLR-10494-withdocs.patch > > > Solr's default response format is still XML, despite the fact that Solr has > supported the JSON response format for over a decade, developer mindshare has > clearly shifted toward JSON over the years, and most modern/competing systems > also use JSON format now by default. > In fact, Solr's admin UI even explicitly adds wt=json to the request (by > default in the UI) to override the default of wt=xml, so Solr's Admin UI > effectively has a different default than the API. > We have now introduced things like the JSON faceting API, and the new more > modern /V2 apis assume JSON for the areas of Solr they cover, so clearly > we're moving in the direction of JSON anyway. > I'd like propose that we switch the default response writer to JSON (wt=json) > instead of XML for Solr 7.0, as this seems to me like the right direction and > a good time to make this change with the next major version. > Based upon feedback from the Lucene Dev's mailing list, we want to: > 1) Change the default response writer type to "wt=json" and also change to > "indent=on" by default > 2) Make no changes on the update handler side; it already works as desired > (it returns the response in the same content-type as the request unless the > "wt" is passed in explicitly). > 3) Keep the /query request handler around since people have already used it > for years to do JSON queries > 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks > on how to change (back) the response format. > The default format change, plus the addition of "indent=on" are back compat > changes, so we need to make sure we doc those clearly in the CHANGES.txt. > There will also need to be significant adjustments to the Solr Ref Guide, > Tutorial, etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trey Grainger updated SOLR-10494: - Priority: Blocker (was: Minor) > Switch Solr's Default Response Type from XML to JSON > > > Key: SOLR-10494 > URL: https://issues.apache.org/jira/browse/SOLR-10494 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (7.0) >Reporter: Trey Grainger >Priority: Blocker > Fix For: master (7.0) > > Attachments: SOLR-10494, SOLR-10494, SOLR-10494-withdocs.patch, > SOLR-10494-withdocs.patch > > > Solr's default response format is still XML, despite the fact that Solr has > supported the JSON response format for over a decade, developer mindshare has > clearly shifted toward JSON over the years, and most modern/competing systems > also use JSON format now by default. > In fact, Solr's admin UI even explicitly adds wt=json to the request (by > default in the UI) to override the default of wt=xml, so Solr's Admin UI > effectively has a different default than the API. > We have now introduced things like the JSON faceting API, and the new more > modern /V2 apis assume JSON for the areas of Solr they cover, so clearly > we're moving in the direction of JSON anyway. > I'd like propose that we switch the default response writer to JSON (wt=json) > instead of XML for Solr 7.0, as this seems to me like the right direction and > a good time to make this change with the next major version. > Based upon feedback from the Lucene Dev's mailing list, we want to: > 1) Change the default response writer type to "wt=json" and also change to > "indent=on" by default > 2) Make no changes on the update handler side; it already works as desired > (it returns the response in the same content-type as the request unless the > "wt" is passed in explicitly). > 3) Keep the /query request handler around since people have already used it > for years to do JSON queries > 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks > on how to change (back) the response format. > The default format change, plus the addition of "indent=on" are back compat > changes, so we need to make sure we doc those clearly in the CHANGES.txt. > There will also need to be significant adjustments to the Solr Ref Guide, > Tutorial, etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-10494: - Attachment: SOLR-10494-withdocs.patch > Switch Solr's Default Response Type from XML to JSON > > > Key: SOLR-10494 > URL: https://issues.apache.org/jira/browse/SOLR-10494 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (7.0) >Reporter: Trey Grainger >Priority: Minor > Fix For: master (7.0) > > Attachments: SOLR-10494, SOLR-10494, SOLR-10494-withdocs.patch, > SOLR-10494-withdocs.patch > > > Solr's default response format is still XML, despite the fact that Solr has > supported the JSON response format for over a decade, developer mindshare has > clearly shifted toward JSON over the years, and most modern/competing systems > also use JSON format now by default. > In fact, Solr's admin UI even explicitly adds wt=json to the request (by > default in the UI) to override the default of wt=xml, so Solr's Admin UI > effectively has a different default than the API. > We have now introduced things like the JSON faceting API, and the new more > modern /V2 apis assume JSON for the areas of Solr they cover, so clearly > we're moving in the direction of JSON anyway. > I'd like propose that we switch the default response writer to JSON (wt=json) > instead of XML for Solr 7.0, as this seems to me like the right direction and > a good time to make this change with the next major version. > Based upon feedback from the Lucene Dev's mailing list, we want to: > 1) Change the default response writer type to "wt=json" and also change to > "indent=on" by default > 2) Make no changes on the update handler side; it already works as desired > (it returns the response in the same content-type as the request unless the > "wt" is passed in explicitly). > 3) Keep the /query request handler around since people have already used it > for years to do JSON queries > 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks > on how to change (back) the response format. > The default format change, plus the addition of "indent=on" are back compat > changes, so we need to make sure we doc those clearly in the CHANGES.txt. > There will also need to be significant adjustments to the Solr Ref Guide, > Tutorial, etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[
https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cassandra Targett updated SOLR-10494:
-
Attachment: SOLR-10494-withdocs.patch
Here's a patch with [~solrtrey]'s changes + ref guide changes. Nearly all of
the changes needed were to simply remove {{&wt=json&indent=true}} from
examples. Of course I found a couple unrelated glaring issues I couldn't let
pass by, but I kept those to an extreme minimum.
I reviewed all the places in the Ref Guide where {{wt}} is mentioned. Turns out
we never actually said XML is the default...just said you had to use
{{wt=json}}. I also updated the solrconfig.xml request handler defaults
examples.
One thing I neglected to look for were places where an example request does not
specify {{wt=xml}} but the example response is XML. I can do another pass for
those at a later time - I would guess there aren't a lot of those.
> Switch Solr's Default Response Type from XML to JSON
>
>
> Key: SOLR-10494
> URL: https://issues.apache.org/jira/browse/SOLR-10494
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: master (7.0)
>Reporter: Trey Grainger
>Priority: Minor
> Fix For: master (7.0)
>
> Attachments: SOLR-10494, SOLR-10494, SOLR-10494-withdocs.patch
>
>
> Solr's default response format is still XML, despite the fact that Solr has
> supported the JSON response format for over a decade, developer mindshare has
> clearly shifted toward JSON over the years, and most modern/competing systems
> also use JSON format now by default.
> In fact, Solr's admin UI even explicitly adds wt=json to the request (by
> default in the UI) to override the default of wt=xml, so Solr's Admin UI
> effectively has a different default than the API.
> We have now introduced things like the JSON faceting API, and the new more
> modern /V2 apis assume JSON for the areas of Solr they cover, so clearly
> we're moving in the direction of JSON anyway.
> I'd like propose that we switch the default response writer to JSON (wt=json)
> instead of XML for Solr 7.0, as this seems to me like the right direction and
> a good time to make this change with the next major version.
> Based upon feedback from the Lucene Dev's mailing list, we want to:
> 1) Change the default response writer type to "wt=json" and also change to
> "indent=on" by default
> 2) Make no changes on the update handler side; it already works as desired
> (it returns the response in the same content-type as the request unless the
> "wt" is passed in explicitly).
> 3) Keep the /query request handler around since people have already used it
> for years to do JSON queries
> 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks
> on how to change (back) the response format.
> The default format change, plus the addition of "indent=on" are back compat
> changes, so we need to make sure we doc those clearly in the CHANGES.txt.
> There will also need to be significant adjustments to the Solr Ref Guide,
> Tutorial, etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trey Grainger updated SOLR-10494: - Attachment: SOLR-10494 New patch fixing a precommit error. Comment earlier about unclosed resources was apparently pre-existing (those are warnings and not errors) and I just noticed it because of an unrelated error, so going to ignore those. Working on indent=on by default for next patch. > Switch Solr's Default Response Type from XML to JSON > > > Key: SOLR-10494 > URL: https://issues.apache.org/jira/browse/SOLR-10494 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (7.0) >Reporter: Trey Grainger >Priority: Minor > Fix For: master (7.0) > > Attachments: SOLR-10494, SOLR-10494 > > > Solr's default response format is still XML, despite the fact that Solr has > supported the JSON response format for over a decade, developer mindshare has > clearly shifted toward JSON over the years, and most modern/competing systems > also use JSON format now by default. > In fact, Solr's admin UI even explicitly adds wt=json to the request (by > default in the UI) to override the default of wt=xml, so Solr's Admin UI > effectively has a different default than the API. > We have now introduced things like the JSON faceting API, and the new more > modern /V2 apis assume JSON for the areas of Solr they cover, so clearly > we're moving in the direction of JSON anyway. > I'd like propose that we switch the default response writer to JSON (wt=json) > instead of XML for Solr 7.0, as this seems to me like the right direction and > a good time to make this change with the next major version. > Based upon feedback from the Lucene Dev's mailing list, we want to: > 1) Change the default response writer type to "wt=json" and also change to > "indent=on" by default > 2) Make no changes on the update handler side; it already works as desired > (it returns the response in the same content-type as the request unless the > "wt" is passed in explicitly). > 3) Keep the /query request handler around since people have already used it > for years to do JSON queries > 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks > on how to change (back) the response format. > The default format change, plus the addition of "indent=on" are back compat > changes, so we need to make sure we doc those clearly in the CHANGES.txt. > There will also need to be significant adjustments to the Solr Ref Guide, > Tutorial, etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
[ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trey Grainger updated SOLR-10494: - Attachment: SOLR-10494 Initial patch, with all unit tests broken by the change now passing. Haven't changed to indent=on by default yet or removed setting of json explicitly in various places yet, though, as I've been trying to change one variable at a time to minimize complications. For some reason, switching to json by default has caused ant precommit to complain about resource leak in about 60 places. I'm not sure what is causing these at the moment, but want to address that first before adding any additional changes to the patch. > Switch Solr's Default Response Type from XML to JSON > > > Key: SOLR-10494 > URL: https://issues.apache.org/jira/browse/SOLR-10494 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (7.0) >Reporter: Trey Grainger >Priority: Minor > Fix For: master (7.0) > > Attachments: SOLR-10494 > > > Solr's default response format is still XML, despite the fact that Solr has > supported the JSON response format for over a decade, developer mindshare has > clearly shifted toward JSON over the years, and most modern/competing systems > also use JSON format now by default. > In fact, Solr's admin UI even explicitly adds wt=json to the request (by > default in the UI) to override the default of wt=xml, so Solr's Admin UI > effectively has a different default than the API. > We have now introduced things like the JSON faceting API, and the new more > modern /V2 apis assume JSON for the areas of Solr they cover, so clearly > we're moving in the direction of JSON anyway. > I'd like propose that we switch the default response writer to JSON (wt=json) > instead of XML for Solr 7.0, as this seems to me like the right direction and > a good time to make this change with the next major version. > Based upon feedback from the Lucene Dev's mailing list, we want to: > 1) Change the default response writer type to "wt=json" and also change to > "indent=on" by default > 2) Make no changes on the update handler side; it already works as desired > (it returns the response in the same content-type as the request unless the > "wt" is passed in explicitly). > 3) Keep the /query request handler around since people have already used it > for years to do JSON queries > 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks > on how to change (back) the response format. > The default format change, plus the addition of "indent=on" are back compat > changes, so we need to make sure we doc those clearly in the CHANGES.txt. > There will also need to be significant adjustments to the Solr Ref Guide, > Tutorial, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
