[jira] [Updated] (SOLR-11372) enable refinement testing in TestCloudJSONFacetJoinDomain
[ https://issues.apache.org/jira/browse/SOLR-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-11372: Attachment: SOLR-11372_fixup.patch whoops. updated patch to fix silly mistake: i had "refactored" a number into a static constant but then forgot to use that constant in the original code > enable refinement testing in TestCloudJSONFacetJoinDomain > - > > Key: SOLR-11372 > URL: https://issues.apache.org/jira/browse/SOLR-11372 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: 7.1 > > Attachments: SOLR-11372_fixup.patch, SOLR-11372_fixup.patch, > SOLR-11372.patch > > > This test has great random tests that ensure that the count returned for a > bucket matches the number of documents returned from an equivalent filter. > We should enable randomly testing smaller limits in conjunction with > refinement to ensure we still get accurate counts for buckets that are > returned. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-11372) enable refinement testing in TestCloudJSONFacetJoinDomain
[ https://issues.apache.org/jira/browse/SOLR-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-11372: Attachment: SOLR-11372_fixup.patch [~ysee...@gmail.com]: here's a patch to fix up the test changes -- i'm beasting now, will plan on committing tomorrow unless i find any failures or you see any obvious problems. > enable refinement testing in TestCloudJSONFacetJoinDomain > - > > Key: SOLR-11372 > URL: https://issues.apache.org/jira/browse/SOLR-11372 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: 7.1 > > Attachments: SOLR-11372_fixup.patch, SOLR-11372.patch > > > This test has great random tests that ensure that the count returned for a > bucket matches the number of documents returned from an equivalent filter. > We should enable randomly testing smaller limits in conjunction with > refinement to ensure we still get accurate counts for buckets that are > returned. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-11372) enable refinement testing in TestCloudJSONFacetJoinDomain
[ https://issues.apache.org/jira/browse/SOLR-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-11372: Attachment: SOLR-11372.patch Here's my current patch. refinement seems to work (and the test fails often when I hardcode refine:false), so it's looking good. I'm going to beast it a while though and see if anything pops out. > enable refinement testing in TestCloudJSONFacetJoinDomain > - > > Key: SOLR-11372 > URL: https://issues.apache.org/jira/browse/SOLR-11372 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Yonik Seeley > Attachments: SOLR-11372.patch > > > This test has great random tests that ensure that the count returned for a > bucket matches the number of documents returned from an equivalent filter. > We should enable randomly testing smaller limits in conjunction with > refinement to ensure we still get accurate counts for buckets that are > returned. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
