[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-06-14 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Høydahl updated SOLR-4791:
--

Fix Version/s: (was: 4.3.1)

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
  Components: multicore
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Fix For: 5.0, 4.4

 Attachments: closeLoader.patch, SOLR-4791.patch, SOLR-4791.patch, 
 SOLR-4791.patch, SOLR-4791-test.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-05-08 Thread Ryan Ernst (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Ernst updated SOLR-4791:
-

Attachment: SOLR-4791.patch

Ok, I went down a rabbit hole and fixed another bug (if quiet was false, no 
files would ever be loaded in the 3 arg version of addToClassPath).  I also 
removed the single arg version of addToClassPath, since it was only used in one 
place, and the documentation was wrong anyway (claimed it worked with a 
directory path, but only worked for a single file).

I added two tests, one which tests adding paths to SolrResourceLoader, and 
another to ensure CoreContainer loads sharedLib correctly (and works with the 
default lib).

All of this is in the new patch.

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Attachments: SOLR-4791.patch, SOLR-4791.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-05-08 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Høydahl updated SOLR-4791:
--

Component/s: multicore

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
  Components: multicore
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Attachments: SOLR-4791.patch, SOLR-4791.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-05-08 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Høydahl updated SOLR-4791:
--

Fix Version/s: 4.4
   5.0

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
  Components: multicore
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Fix For: 5.0, 4.4

 Attachments: SOLR-4791.patch, SOLR-4791.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-05-08 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Høydahl updated SOLR-4791:
--

Fix Version/s: 4.3.1

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
  Components: multicore
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Fix For: 5.0, 4.4, 4.3.1

 Attachments: SOLR-4791.patch, SOLR-4791.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-05-08 Thread Erick Erickson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-4791:
-

Attachment: SOLR-4791.patch

Ryan:

Looks great! I'll check it in today trunk and 4x.

I took out a couple of unused imports I noticed that had probably been hanging 
around since forever but otherwise I didn't change anything

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
  Components: multicore
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Fix For: 5.0, 4.4, 4.3.1

 Attachments: SOLR-4791.patch, SOLR-4791.patch, SOLR-4791.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-05-08 Thread Erick Erickson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-4791:
-

Attachment: SOLR-4791-test.patch

Could someone with a windows machine try this patch out? Other then having to 
indent, all it does is try to delete the directory created in the new test. The 
only changed code is the adding try and the finally block. Passes on my Mac

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
  Components: multicore
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Fix For: 5.0, 4.4, 4.3.1

 Attachments: SOLR-4791.patch, SOLR-4791.patch, SOLR-4791.patch, 
 SOLR-4791-test.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-05-08 Thread Robert Muir (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated SOLR-4791:
--

Attachment: closeLoader.patch

totally untested patch. Ill try it on my windows machien in a few.

I know that Uwe knows a trick for java6 (at least a best-effort we can do, 
which we should). But i still think we should have an assume() for windows 
there since it may not work on all jvms.

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
  Components: multicore
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Fix For: 5.0, 4.4, 4.3.1

 Attachments: closeLoader.patch, SOLR-4791.patch, SOLR-4791.patch, 
 SOLR-4791.patch, SOLR-4791-test.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4791) solr.xml sharedLib does not work in 4.3.0

2013-05-07 Thread Ryan Ernst (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Ernst updated SOLR-4791:
-

Attachment: SOLR-4791.patch

I believe the attached patch should fix the problem.

I haven't come up with a test yet...would need to add a test solr.xml that 
specifies sharedLib (and uses a different name than lib).

On a side note, it is annoying that the 1 argument addToClassLoader expects a 
single file, while the 3 argument one expects a directory...

 solr.xml sharedLib does not work in 4.3.0
 -

 Key: SOLR-4791
 URL: https://issues.apache.org/jira/browse/SOLR-4791
 Project: Solr
  Issue Type: Bug
Affects Versions: 4.3
Reporter: Jan Høydahl
Assignee: Erick Erickson
 Attachments: SOLR-4791.patch


 The sharedLib attribute on {{solr}} tag in solr.xml stopped working in 4.3.
 Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
 load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
 sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org