[jira] [Updated] (SOLR-4839) Jetty 9

2015-04-26 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839-branch_5x.patch

Here's a patch to upgrade branch_5x with Jetty 9. All tests and precommit pass.

This also undoes some of the fixes made in SOLR-7429 simply because Jetty 9 has 
no problem in loading the servlet-api-3.1.0 jar from server/lib

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: Trunk, 5.2

 Attachments: SOLR-4839-branch_5x.patch, 
 SOLR-4839-conform-jetty9_2_10.patch, SOLR-4839-conform-jetty9_2_10.patch, 
 SOLR-4839-fix-eclipse.patch, SOLR-4839-jetty9.2.10, 
 SOLR-4839-mod-JettySolrRunner.patch, 
 SOLR-4839-separate-client-ssl-options.patch, 
 SOLR-4839-ssl-support_patch.patch, SOLR-4839-ssl-support_patch.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-04-25 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839-separate-client-ssl-options.patch

Thanks Steve. I added your suggestions to this patch 
(SOLR-4839-separate-client-ssl-options.patch) to separate the client and Jetty 
SSL config.

I don't think replacing Property with SystemProperty is necessary because 
Property can also be set via SystemProperty plus it can also be overridden 
from one of the module files. However the way we're using them both Property 
and SystemProperty are equivalent.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: Trunk, 5.2

 Attachments: SOLR-4839-conform-jetty9_2_10.patch, 
 SOLR-4839-conform-jetty9_2_10.patch, SOLR-4839-fix-eclipse.patch, 
 SOLR-4839-jetty9.2.10, SOLR-4839-mod-JettySolrRunner.patch, 
 SOLR-4839-separate-client-ssl-options.patch, 
 SOLR-4839-ssl-support_patch.patch, SOLR-4839-ssl-support_patch.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-04-23 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839-ssl-support_patch.patch

This patch removes the property SOLR_SSL_PORT in solr.in.sh because there is 
really no need for another way to configure a port for our start scripts. We 
can use the regular -p switch or SOLR_PORT property to configure the port in 
both http and https/ssl modes.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: Trunk, 5.2

 Attachments: SOLR-4839-conform-jetty9_2_10.patch, 
 SOLR-4839-conform-jetty9_2_10.patch, SOLR-4839-fix-eclipse.patch, 
 SOLR-4839-jetty9.2.10, SOLR-4839-mod-JettySolrRunner.patch, 
 SOLR-4839-ssl-support_patch.patch, SOLR-4839-ssl-support_patch.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-04-23 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839-ssl-support_patch.patch

Changes:
# Threadpool configs: idleTimeout=5000 (5 seconds) and stopTimeout=6 (1 
minute) respectively to match what existed inside JettySolrRunner
# sendServerVersion is set to false by default to match branch_5x
# HTTP and HTTPS connector idleTimeout defaults to 5 ms to match branch_5x
# HTTPS default port property is called solr.jetty.https.port and defaults to 
8983
# I removed the keyManagerPassword property from jetty-ssl.xml because 1) it 
was not specified in branch_5x as well and 2) from reading the docs, it  
defaults to the keyStorePassword but if we ask the user to change it from the 
solr.in.sh then we must introduce another property which should normally be 
always set to the same as keyManagerPassword. I don't know if/how this property 
is useful so I have removed it for the time being. Perhaps someone more 
knowledgeable about security can chime in here.
# SSL property names are changed as follows to fix related issue SOLR-7449 so 
that changes to property values in bin/solr.in.sh is propagated to jetty:
{code}
Set name=KeyStorePathProperty name=javax.net.ssl.keyStore 
default=./etc/solr-ssl.keystore.jks//Set
  Set name=KeyStorePasswordProperty name=javax.net.ssl.keyStorePassword 
default=secret//Set
  Set name=TrustStorePathProperty name=javax.net.ssl.trustStore 
default=./etc/solr-ssl.keystore.jks//Set
  Set name=TrustStorePasswordProperty 
name=javax.net.ssl.trustStorePassword default=secret//Set
  Set name=NeedClientAuthProperty name=jetty.ssl.clientAuth 
default=false//Set
  Set name=WantClientAuthProperty name=jetty.ssl.wantClientAuth 
default=false//Set
{code}
# bin/solr and bin/solr.cmd enable the appropriate module name in jetty (http 
or https)
# Removed unused properties in ssl.mod
# Deleted the start.ini altogether as it was serving no need
# It is no longer possible to run java -jar start.jar directly because by 
default neither http nor https module is enabled. The bin/solr script is the 
only supported way of starting solr. This is required because if we enable the 
http module by default from inside start.ini then it is not possible to disable 
http and enable https using command line arguments to start.jar. Instead both 
are enabled and Solr ends up trying to listen using both http and https 
connectors.

I tested using the SSL setup documentation in the reference guide and it works 
with no modifications required to the setup steps.

The tests and precommit passes at this point. I cannot test the smoke tester 
until I commit so I'll commit this changes and then run the smoke tester.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: Trunk, 5.2

 Attachments: SOLR-4839-conform-jetty9_2_10.patch, 
 SOLR-4839-conform-jetty9_2_10.patch, SOLR-4839-fix-eclipse.patch, 
 SOLR-4839-jetty9.2.10, SOLR-4839-mod-JettySolrRunner.patch, 
 SOLR-4839-ssl-support_patch.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-04-22 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839-conform-jetty9_2_10.patch

Here's patch which conforms our jetty config files to the ones shipped with 
9.2.10 more closely.

# jetty.xml configures the thread pool and common configuration used by both 
http and https connectors
# The Connector for ssl is in jetty-https.xml, not jetty-ssl.xml
# All property names are now prefixed with solr.jetty. so e.g. https.port 
becomes solr.jetty.https.port
# Keystore  Truststore path are no longer relative to jetty.base but they 
default to ./etc/solr-ssl.keystore.jks as in 5x.

I am inclined to change jetty.port to solr.jetty.port and jetty.host to 
solr.jetty.host too but that change needs fixes to start scripts and build 
scripts etc so I will not attempt that in this issue.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: Trunk, 5.2

 Attachments: SOLR-4839-conform-jetty9_2_10.patch, 
 SOLR-4839-fix-eclipse.patch, SOLR-4839-jetty9.2.10, 
 SOLR-4839-mod-JettySolrRunner.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-04-22 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839-conform-jetty9_2_10.patch

This patch fixes the smoke tester to work with the new Jetty configuration. The 
smoke tester looks for the following string 'Started 
SocketConnector@0.0.0.0:8983' but the new jetty prints Started 
ServerConnector@55b53d44{HTTP/1.1}{0.0.0.0:8983} to the logs.

At this point, all tests, precommit and smoke tester passes. I'll commit this 
and then focus on getting SSL support to work.


 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: Trunk, 5.2

 Attachments: SOLR-4839-conform-jetty9_2_10.patch, 
 SOLR-4839-conform-jetty9_2_10.patch, SOLR-4839-fix-eclipse.patch, 
 SOLR-4839-jetty9.2.10, SOLR-4839-mod-JettySolrRunner.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-04-21 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839-jetty9.2.10

Patch to upgrade trunk to jetty 9.2.10

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: Trunk, 5.2

 Attachments: SOLR-4839-fix-eclipse.patch, SOLR-4839-jetty9.2.10, 
 SOLR-4839-mod-JettySolrRunner.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-01-22 Thread Steve Rowe (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated SOLR-4839:
-
Fix Version/s: (was: 5.0)
   5.1

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: Trunk, 5.1

 Attachments: SOLR-4839-fix-eclipse.patch, 
 SOLR-4839-mod-JettySolrRunner.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-01-10 Thread Steve Davids (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Davids updated SOLR-4839:
---
Attachment: SOLR-4839-mod-JettySolrRunner.patch

I found that this broke the 'TestMiniSolrCloudCluster' test (or anything that 
doesn't specify a 'jetty.testMode' system property). If a test doesn't specify 
the 'jetty.testMode' property a null pointer exception is thrown by jetty 
because a ServerConnector is attempting to be created with a null Server. I 
attached a patch to fix the specific issue, though I'm not quite sure why we 
need to branch the code - couldn't we consolidate the two?

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839-fix-eclipse.patch, 
 SOLR-4839-mod-JettySolrRunner.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-01-07 Thread Mark Miller (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Miller updated SOLR-4839:
--
Attachment: SOLR-4839.patch

Something like the attatched patch will work I think.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839-fix-eclipse.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-01-06 Thread Ishan Chattopadhyaya (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ishan Chattopadhyaya updated SOLR-4839:
---
Attachment: SOLR-4839-fix-eclipse.patch

Eclipse was complaining for me with these @Override annotations, attached the 
patch to remove them. 

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839-fix-eclipse.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-01-05 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839.patch

Final patch. I'll commit shortly.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-01-02 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839.patch

Latest patch which includes SOLR-6874. All tests pass.

I think we should commit this and then work on a SSL switch in the bin scripts 
as well as easy to modify https/ssl configuration in the jetty configs.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2015-01-02 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839.patch

This patch removes the tests.jettyConnector sysprop as Uwe mentioned earlier.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2014-12-21 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839.patch

bq. Jetty logging works but somehow the rootLogger for /solr is always null, I 
am not sure why

Actually the same thing happens on branch_5x and it's fine. The logging works 
as expected.

I traced the test failures to double initialization of SolrDispatchFilter in 
JettySolrRunner. The root.addServlet also calls filter init for all filter 
added till that point. This was leading to thread leaks and test failures. I am 
not sure if this is a bug in jetty but adding SolrDispatchFilter after all 
other filters and servlets have been added works around this issue.

bq. Now I will try to upgrade restlet to 2.3

This patch passes all the schema related tests that were failing earlier. I see 
HttpPartitionTest fail with this patch. The failure can be reproduced with:

{quote}
ant test  -Dtestcase=HttpPartitionTest -Dtests.method=testDistribSearch 
-Dtests.seed=B85FF6DC513799E3 -Dtests.slow=true -Dtests.locale=es_GT 
-Dtests.timezone=Asia/Chungking -Dtests.asserts=true 
-Dtests.file.encoding=US-ASCII
{quote}

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2014-12-20 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839.patch

# Solr comes up fine
# Jetty logging works but somehow the rootLogger for /solr is always null, I am 
not sure why
# I added -Djetty.home=$SOLR_SERVER_DIR in bin/solr otherwise jetty resolves 
jetty.home as the path of start.jar in ivy2 cache.

Now I will try to upgrade restlet to 2.3 and see if we can get all tests to 
pass.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch, 
 SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2014-12-19 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839.patch

I'm attaching this patch as a checkpoint.

# Fixed some compile failures in StartSolrJetty and SolrRequestParserTest
# Modified jetty.xml and solr-jetty-context.xml to conform to Jetty 9 changes

Todo:
# Fix the SSL example
# The example doesn't work right now because unlike previous versions of jetty, 
jetty.home is resolved as the location of start.jar which gets resolved to the 
ivy cache path which messes up our configuration.
# Jetty 9 has this concept of modules which can be configured via property 
files and/or by xml. We could do away with XML configuration if we want. 
Opinions?

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2014-12-19 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839.patch

I made some progress getting the modules in place. The example doesn't come up 
yet. The classpath's correct, I think, but it cannot find the context. I'll 
look at this again tomorrow.

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839.patch, SOLR-4839.patch, SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2014-12-18 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-4839:

Attachment: SOLR-4839.patch

Patch to upgrade to Jetty 9.

Some core tests still fail that I need to dig in:
{code}
   [junit4] Tests with failures:
   [junit4]   - org.apache.solr.rest.schema.TestSchemaResource (suite)
   [junit4]   - org.apache.solr.schema.TestCloudSchemaless.testDistribSearch
   [junit4]   - org.apache.solr.rest.schema.TestDynamicFieldResource (suite)
   [junit4]   - org.apache.solr.schema.TestCloudSchemaless (suite)
{code}

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk

 Attachments: SOLR-4839.patch


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-4839) Jetty 9

2014-12-09 Thread Erik Hatcher (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erik Hatcher updated SOLR-4839:
---
Fix Version/s: Trunk
   5.0

 Jetty 9
 ---

 Key: SOLR-4839
 URL: https://issues.apache.org/jira/browse/SOLR-4839
 Project: Solr
  Issue Type: Improvement
Reporter: Bill Bell
Assignee: Shalin Shekhar Mangar
 Fix For: 5.0, Trunk


 Implement Jetty 9



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org