[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-5768:
Attachment: SOLR-5768.diff
The last patch had the test failure because of an incorrect merge. This patch
fixes that problem. I am gonna run all tests and do some manual testing before
committing this.
Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all
fields and skip GET_FIELDS
---
Key: SOLR-5768
URL: https://issues.apache.org/jira/browse/SOLR-5768
Project: Solr
Issue Type: Improvement
Reporter: Shalin Shekhar Mangar
Assignee: Shalin Shekhar Mangar
Priority: Minor
Fix For: 4.9, 5.0
Attachments: SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff,
SOLR-5768.diff
Suggested by Yonik on solr-user:
http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
{quote}
Although it seems like it should be relatively simple to make it work
with other fields as well, by passing down the complete fl requested
if some optional parameter is set (distrib.singlePass?)
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-5768:
Attachment: SOLR-5768.diff
It's probably better to use rb.rsp.getReturnFields() because that is set in the
prepare method and it takes care of missing fl parameter as well. Otherwise
we get a NPE in updateFl method. This patch fixes that problem.
I also added a test to assert that response returned from distrib and
distrib.singlePass method are the same. I think this is ready.
Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all
fields and skip GET_FIELDS
---
Key: SOLR-5768
URL: https://issues.apache.org/jira/browse/SOLR-5768
Project: Solr
Issue Type: Improvement
Reporter: Shalin Shekhar Mangar
Assignee: Shalin Shekhar Mangar
Priority: Minor
Fix For: 4.9, 5.0
Attachments: SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff,
SOLR-5768.diff, SOLR-5768.diff
Suggested by Yonik on solr-user:
http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
{quote}
Although it seems like it should be relatively simple to make it work
with other fields as well, by passing down the complete fl requested
if some optional parameter is set (distrib.singlePass?)
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-5768:
Attachment: SOLR-5768.diff
The last patch had a bug where if uniqueKey was omitted from the fl param
then you'd get a NPE in mergeIds.
This patch adds the uniqueKey field if not requested to the individual shard
requests so that we can always merge the shard responses.
Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all
fields and skip GET_FIELDS
---
Key: SOLR-5768
URL: https://issues.apache.org/jira/browse/SOLR-5768
Project: Solr
Issue Type: Improvement
Reporter: Shalin Shekhar Mangar
Assignee: Shalin Shekhar Mangar
Priority: Minor
Fix For: 4.9, 5.0
Attachments: SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff,
SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff
Suggested by Yonik on solr-user:
http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
{quote}
Although it seems like it should be relatively simple to make it work
with other fields as well, by passing down the complete fl requested
if some optional parameter is set (distrib.singlePass?)
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-5768:
Attachment: SOLR-5768.diff
Here's an updated patch which applies to trunk.
The DistributedQueryComponentOptimizationTest doesn't pass with the patch. This
is the error:
{code}
org.apache.solr.client.solrj.impl.HttpSolrServer$RemoteSolrException:
java.lang.NullPointerException
at
org.apache.solr.handler.component.QueryComponent.regularFinishStage(QueryComponent.java:779)
at
org.apache.solr.handler.component.QueryComponent.finishStage(QueryComponent.java:733)
at
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:333)
at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
at org.apache.solr.core.SolrCore.execute(SolrCore.java:1980)
at
org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:780)
at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:420)
at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:208)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
at
org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:136)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:229)
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
at
org.eclipse.jetty.server.handler.GzipHandler.handle(GzipHandler.java:301)
at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1077)
at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:384)
at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1009)
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
at org.eclipse.jetty.server.Server.handle(Server.java:368)
at
org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
at
org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:942)
at
org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1004)
at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:640)
at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
at
org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)
at org.eclipse.jetty.io.nio.SslConnection.handle(SslConnection.java:196)
at
org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:628)
at
org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52)
at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
at
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
at java.lang.Thread.run(Thread.java:744)
at
__randomizedtesting.SeedInfo.seed([5353CAD02801E6C4:D2B544C85F5E86F8]:0)
at
org.apache.solr.client.solrj.impl.HttpSolrServer.executeMethod(HttpSolrServer.java:554)
at
org.apache.solr.client.solrj.impl.HttpSolrServer.request(HttpSolrServer.java:210)
at
org.apache.solr.client.solrj.impl.HttpSolrServer.request(HttpSolrServer.java:206)
at
org.apache.solr.client.solrj.request.QueryRequest.process(QueryRequest.java:91)
at org.apache.solr.client.solrj.SolrServer.query(SolrServer.java:301)
at
org.apache.solr.BaseDistributedSearchTestCase.queryServer(BaseDistributedSearchTestCase.java:508)
at
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:556)
at
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:538)
at
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:517)
at
org.apache.solr.handler.component.DistributedQueryComponentOptimizationTest.doTest(DistributedQueryComponentOptimizationTest.java:83)
at
org.apache.solr.BaseDistributedSearchTestCase.testDistribSearch(BaseDistributedSearchTestCase.java:863)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregg Donovan updated SOLR-5768:
Attachment: SOLR-5768.diff
Updated patch with better matching of whether score was requested in request
params.
Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all
fields and skip GET_FIELDS
---
Key: SOLR-5768
URL: https://issues.apache.org/jira/browse/SOLR-5768
Project: Solr
Issue Type: Improvement
Reporter: Shalin Shekhar Mangar
Assignee: Shalin Shekhar Mangar
Priority: Minor
Fix For: 4.8, 5.0
Attachments: SOLR-5768.diff, SOLR-5768.diff
Suggested by Yonik on solr-user:
http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
{quote}
Although it seems like it should be relatively simple to make it work
with other fields as well, by passing down the complete fl requested
if some optional parameter is set (distrib.singlePass?)
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregg Donovan updated SOLR-5768:
Attachment: SOLR-5768.diff
Updated patch.
Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all
fields and skip GET_FIELDS
---
Key: SOLR-5768
URL: https://issues.apache.org/jira/browse/SOLR-5768
Project: Solr
Issue Type: Improvement
Reporter: Shalin Shekhar Mangar
Priority: Minor
Fix For: 4.8, 5.0
Attachments: SOLR-5768.diff
Suggested by Yonik on solr-user:
http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
{quote}
Although it seems like it should be relatively simple to make it work
with other fields as well, by passing down the complete fl requested
if some optional parameter is set (distrib.singlePass?)
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregg Donovan updated SOLR-5768:
Attachment: (was: SOLR-5768.diff)
Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all
fields and skip GET_FIELDS
---
Key: SOLR-5768
URL: https://issues.apache.org/jira/browse/SOLR-5768
Project: Solr
Issue Type: Improvement
Reporter: Shalin Shekhar Mangar
Priority: Minor
Fix For: 4.8, 5.0
Attachments: SOLR-5768.diff
Suggested by Yonik on solr-user:
http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
{quote}
Although it seems like it should be relatively simple to make it work
with other fields as well, by passing down the complete fl requested
if some optional parameter is set (distrib.singlePass?)
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregg Donovan updated SOLR-5768:
Attachment: SOLR-5768.diff
Is this all that's needed for a distrib.singlePass parameter? It seems like
SOLR-1880 may have done most of the work.
Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all
fields and skip GET_FIELDS
---
Key: SOLR-5768
URL: https://issues.apache.org/jira/browse/SOLR-5768
Project: Solr
Issue Type: Improvement
Reporter: Shalin Shekhar Mangar
Priority: Minor
Fix For: 4.8, 5.0
Attachments: SOLR-5768.diff
Suggested by Yonik on solr-user:
http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
{quote}
Although it seems like it should be relatively simple to make it work
with other fields as well, by passing down the complete fl requested
if some optional parameter is set (distrib.singlePass?)
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
[
https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-5768:
Summary: Add a distrib.singlePass parameter to make EXECUTE_QUERY phase
fetch all fields and skip GET_FIELDS (was: Add a distrib.singlePass parameter
to make GET_FIELDS phase fetch all fields and skip EXECUTE_QUERY)
Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all
fields and skip GET_FIELDS
---
Key: SOLR-5768
URL: https://issues.apache.org/jira/browse/SOLR-5768
Project: Solr
Issue Type: Improvement
Reporter: Shalin Shekhar Mangar
Priority: Minor
Fix For: 4.8, 5.0
Suggested by Yonik on solr-user:
http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
{quote}
Although it seems like it should be relatively simple to make it work
with other fields as well, by passing down the complete fl requested
if some optional parameter is set (distrib.singlePass?)
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
