[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-5852: Attachment: SOLR-5852.patch Updating Varun's patch to trunk. My +1 to commit. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852-SH.patch, SOLR-5852-SH.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852_FK.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-5852: Attachment: SOLR-5852.patch My last patch had messed up javadocs because of a bad merge. This patch fixes it. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852-SH.patch, SOLR-5852-SH.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852_FK.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5852: Attachment: SOLR-5852.patch - Updated [~elyograg]'s patch to trunk - Modified CloudSolrServerMultiConstructorTest to make the tests random. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852-SH.patch, SOLR-5852-SH.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852_FK.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-5852: --- Attachment: SOLR-5852.patch New patch. Will throw IAE if the chroot doesn't start with a forward slash, but no other error checking. It uses Furkan's order change and Collection in the signature. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852-SH.patch, SOLR-5852-SH.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852_FK.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-5852: --- Attachment: SOLR-5852.patch Forgot to change the parameter order in the javadocs. Fixed. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852-SH.patch, SOLR-5852-SH.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852.patch, SOLR-5852_FK.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-5852: --- Attachment: SOLR-5852-SH.patch The patches already submitted didn't have the kind of flexibility and error reporting that I hoped for. I've built a new patch for this issue. This patch also addresses SOLR-4620, eliminates all but one warning in CloudSolrServer, and includes tests for the new constructor. There are probably at least two additional test cases that need to be created. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852-SH.patch, SOLR-5852.patch, SOLR-5852_FK.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-5852: --- Attachment: SOLR-5852-SH.patch New patch against trunk. Previous patch was against trunk too, but a couple of hours after I went to bed, a conflicting patch was committed. This does make a change to CloudSolrServerTest bits that just got added, but only to eliminate warnings. It does not change the function. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852-SH.patch, SOLR-5852-SH.patch, SOLR-5852.patch, SOLR-5852_FK.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Furkan KAMACI updated SOLR-5852: Attachment: SOLR-5852_FK.patch I've improved the javadoc. We can use whether SOLR-4620 or this. On the other hand I can implement another patch according to second approach at my previous comment. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852.patch, SOLR-5852_FK.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-5852: Attachment: SOLR-5852.patch Simple Patch. - Adds Javadocs to the current constructor to detail on how to connect to a ZK ensemble - Adds another constructor which takes an list of servers and converts them into a comma separated list of servers. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5852) Add CloudSolrServer helper method to connect to a ZK ensemble
[ https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Furkan KAMACI updated SOLR-5852: Attachment: SOLR-5852_FK.patch [~varunthacker] I've improved your patched and attached. You can check it. Add CloudSolrServer helper method to connect to a ZK ensemble - Key: SOLR-5852 URL: https://issues.apache.org/jira/browse/SOLR-5852 Project: Solr Issue Type: Improvement Reporter: Varun Thacker Attachments: SOLR-5852.patch, SOLR-5852_FK.patch We should have a CloudSolrServer constructor which takes a list of ZK servers to connect to. Something Like {noformat} public CloudSolrServer(String... zkHost); {noformat} - Document the current constructor better to mention that to connect to a ZK ensemble you can pass a comma-delimited list of ZK servers like zk1:2181,zk2:2181,zk3:2181 - Thirdly should getLbServer() and getZKStatereader() be public? -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org