[jira] [Updated] (SOLR-6886) Grouping.java tweaks

2015-04-17 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-6886:

Attachment: SOLR-6886.patch

Patch in sync with trunk. There was another place where the finish method was 
not being called so I fixed that too.

 Grouping.java tweaks
 

 Key: SOLR-6886
 URL: https://issues.apache.org/jira/browse/SOLR-6886
 Project: Solr
  Issue Type: Wish
Reporter: Christine Poerschke
Priority: Minor
 Attachments: SOLR-6886.patch


 There's a size0 check which seems to be redundant and some 
 DelegatingCollector.finish calls seem to be missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-6886) Grouping.java tweaks

2015-04-17 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-6886:

Attachment: SOLR-6886.patch

Refactored to call finish in one place regardless of the branch executed. I'll 
commit this shortly.

 Grouping.java tweaks
 

 Key: SOLR-6886
 URL: https://issues.apache.org/jira/browse/SOLR-6886
 Project: Solr
  Issue Type: Wish
Reporter: Christine Poerschke
Priority: Minor
 Attachments: SOLR-6886.patch, SOLR-6886.patch


 There's a size0 check which seems to be redundant and some 
 DelegatingCollector.finish calls seem to be missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org