[jira] [Updated] (SOLR-7115) UpdateLog can miss closing transaction log objects.
[ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-7115: -- Fix Version/s: (was: 6.x) > UpdateLog can miss closing transaction log objects. > --- > > Key: SOLR-7115 > URL: https://issues.apache.org/jira/browse/SOLR-7115 > Project: Solr > Issue Type: Bug >Reporter: Mark Miller >Assignee: Yonik Seeley > Fix For: 6.4, master (7.0) > > Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt, > SOLR-7115.patch, SOLR-7115.patch, tests-failures-7115.txt > > > I've seen this happen on YourKit and in various tests - especially since > adding resource release tracking to the log objects. Now I've got a test that > catches it in SOLR-7113. > It seems that in precommit, if prevTlog is not null, we need to close it > because we are going to overwrite prevTlog with a new log. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7115) UpdateLog can miss closing transaction log objects.
[ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-7115: --- Fix Version/s: 6.4 > UpdateLog can miss closing transaction log objects. > --- > > Key: SOLR-7115 > URL: https://issues.apache.org/jira/browse/SOLR-7115 > Project: Solr > Issue Type: Bug >Reporter: Mark Miller >Assignee: Yonik Seeley > Fix For: 6.4, 6.x, master (7.0) > > Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt, > SOLR-7115.patch, SOLR-7115.patch, tests-failures-7115.txt > > > I've seen this happen on YourKit and in various tests - especially since > adding resource release tracking to the log objects. Now I've got a test that > catches it in SOLR-7113. > It seems that in precommit, if prevTlog is not null, we need to close it > because we are going to overwrite prevTlog with a new log. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7115) UpdateLog can miss closing transaction log objects.
[ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-7115: --- Fix Version/s: (was: 6.3) master (7.0) 6.x Patch is ready, but there is no review. Fix it next time. > UpdateLog can miss closing transaction log objects. > --- > > Key: SOLR-7115 > URL: https://issues.apache.org/jira/browse/SOLR-7115 > Project: Solr > Issue Type: Bug >Reporter: Mark Miller > Fix For: 6.x, master (7.0) > > Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt, > SOLR-7115.patch, SOLR-7115.patch, tests-failures-7115.txt > > > I've seen this happen on YourKit and in various tests - especially since > adding resource release tracking to the log objects. Now I've got a test that > catches it in SOLR-7113. > It seems that in precommit, if prevTlog is not null, we need to close it > because we are going to overwrite prevTlog with a new log. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7115) UpdateLog can miss closing transaction log objects.
[ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-7115: --- Attachment: tests-failures-7115.txt Damn. The test is too brutal to be fixed, it still leaks [^tests-failures-7115.txt]. There is a small probability of a mistake, but I think the fix was applied at the time of that run... Will run it more.. > UpdateLog can miss closing transaction log objects. > --- > > Key: SOLR-7115 > URL: https://issues.apache.org/jira/browse/SOLR-7115 > Project: Solr > Issue Type: Bug >Reporter: Mark Miller > Fix For: 6.3 > > Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt, > SOLR-7115.patch, SOLR-7115.patch, tests-failures-7115.txt > > > I've seen this happen on YourKit and in various tests - especially since > adding resource release tracking to the log objects. Now I've got a test that > catches it in SOLR-7113. > It seems that in precommit, if prevTlog is not null, we need to close it > because we are going to overwrite prevTlog with a new log. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7115) UpdateLog can miss closing transaction log objects.
[ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-7115: --- Attachment: SOLR-7115.patch The fix is trivial, but I hardly want to commit in DUH2 without review. > UpdateLog can miss closing transaction log objects. > --- > > Key: SOLR-7115 > URL: https://issues.apache.org/jira/browse/SOLR-7115 > Project: Solr > Issue Type: Bug >Reporter: Mark Miller > Fix For: 6.3 > > Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt, > SOLR-7115.patch, SOLR-7115.patch > > > I've seen this happen on YourKit and in various tests - especially since > adding resource release tracking to the log objects. Now I've got a test that > catches it in SOLR-7113. > It seems that in precommit, if prevTlog is not null, we need to close it > because we are going to overwrite prevTlog with a new log. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7115) UpdateLog can miss closing transaction log objects.
[ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-7115: --- Fix Version/s: 6.3 > UpdateLog can miss closing transaction log objects. > --- > > Key: SOLR-7115 > URL: https://issues.apache.org/jira/browse/SOLR-7115 > Project: Solr > Issue Type: Bug >Reporter: Mark Miller > Fix For: 6.3 > > Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt, > SOLR-7115.patch > > > I've seen this happen on YourKit and in various tests - especially since > adding resource release tracking to the log objects. Now I've got a test that > catches it in SOLR-7113. > It seems that in precommit, if prevTlog is not null, we need to close it > because we are going to overwrite prevTlog with a new log. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7115) UpdateLog can miss closing transaction log objects.
[
https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-7115:
---
Attachment: SOLR-7115.patch
[^SOLR-7115.patch] straightforward test
{code}
java.lang.AssertionError: ObjectTracker found 158 object(s) that were not
released!!! [TransactionLog, TransactionLog, ]
org.apache.solr.common.util.ObjectReleaseTracker$ObjectTrackerException
at
org.apache.solr.common.util.ObjectReleaseTracker.track(ObjectReleaseTracker.java:43)
at org.apache.solr.update.TransactionLog.(TransactionLog.java:188)
at
org.apache.solr.update.UpdateLog.newTransactionLog(UpdateLog.java:344)
at org.apache.solr.update.UpdateLog.ensureLog(UpdateLog.java:859)
at org.apache.solr.update.UpdateLog.add(UpdateLog.java:428)
at org.apache.solr.update.UpdateLog.add(UpdateLog.java:415)
at
org.apache.solr.update.DirectUpdateHandler2.doNormalUpdate(DirectUpdateHandler2.java:299)
at
org.apache.solr.update.DirectUpdateHandler2.addDoc0(DirectUpdateHandler2.java:211)
at
org.apache.solr.update.DirectUpdateHandler2.addDoc(DirectUpdateHandler2.java:166)
at
org.apache.solr.update.processor.RunUpdateProcessor.processAdd(RunUpdateProcessorFactory.java:67)
...
at org.apache.solr.SolrTestCaseJ4.assertU(SolrTestCaseJ4.java:740)
at
org.apache.solr.core.TestMaxOnDeckSearchersException$1.run(TestMaxOnDeckSearchersException.java:68)
{code}
> UpdateLog can miss closing transaction log objects.
> ---
>
> Key: SOLR-7115
> URL: https://issues.apache.org/jira/browse/SOLR-7115
> Project: Solr
> Issue Type: Bug
>Reporter: Mark Miller
> Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt,
> SOLR-7115.patch
>
>
> I've seen this happen on YourKit and in various tests - especially since
> adding resource release tracking to the log objects. Now I've got a test that
> catches it in SOLR-7113.
> It seems that in precommit, if prevTlog is not null, we need to close it
> because we are going to overwrite prevTlog with a new log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7115) UpdateLog can miss closing transaction log objects.
[ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-7115: --- Attachment: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt https://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/899/testReport/junit.framework/TestSuite/org_apache_solr_client_solrj_embedded_LargeVolumeEmbeddedTest/ [^SOLR-7115-LargeVolumeEmbeddedTest-fail.txt] > UpdateLog can miss closing transaction log objects. > --- > > Key: SOLR-7115 > URL: https://issues.apache.org/jira/browse/SOLR-7115 > Project: Solr > Issue Type: Bug >Reporter: Mark Miller > Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt > > > I've seen this happen on YourKit and in various tests - especially since > adding resource release tracking to the log objects. Now I've got a test that > catches it in SOLR-7113. > It seems that in precommit, if prevTlog is not null, we need to close it > because we are going to overwrite prevTlog with a new log. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
