[jira] [Updated] (SOLR-7913) Add stream.body support to MLT QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-7913: --- Attachment: SOLR-7913_tag_7.5.0.patch > Add stream.body support to MLT QParser > -- > > Key: SOLR-7913 > URL: https://issues.apache.org/jira/browse/SOLR-7913 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Priority: Major > Attachments: SOLR-7913.patch, SOLR-7913.patch, SOLR-7913.patch, > SOLR-7913_fixTests.patch, SOLR-7913_tag_7.5.0.patch > > > Continuing from > https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011. > It'd be good to have stream.body be supported by the mlt qparser. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7913) Add stream.body support to MLT QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-7913: --- Attachment: SOLR-7913_fixTests.patch Oops! My patch on Solr 6.6.0 makes these 3 tests fail : org.apache.solr.search.TestSmileRequest.testDistribJsonRequest org.apache.solr.search.json.TestJsonRequest.testLocalJsonRequest org.apache.solr.search.json.TestJsonRequest.testDistribJsonRequest Adding SOLR-7913_fixTests.patch, to be applied on top of SOLR-7913.patch (2017-07-20). It contains a ridiculous, horrifying hack. But the advantage is that the 3 search tests listed above pass, and it also allows to re-enable org.apache.solr.request.TestRemoteStreaming.testNoUrlAccess(). A boolean to filter only MLT with stream.body has a lot less impact everywhere else. I ran all solr tests, this time ;) > Add stream.body support to MLT QParser > -- > > Key: SOLR-7913 > URL: https://issues.apache.org/jira/browse/SOLR-7913 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta > Attachments: SOLR-7913_fixTests.patch, SOLR-7913.patch, > SOLR-7913.patch, SOLR-7913.patch > > > Continuing from > https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011. > It'd be good to have stream.body be supported by the mlt qparser. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7913) Add stream.body support to MLT QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-7913: --- Attachment: SOLR-7913.patch Patch SOLR-7913, updated to Solr 6.6.0. Adding unit tests. First 2 unit tests in CloudMLTQParserTest look scary, because the results are so different, between the MLT query with id, and the "equivalent" query with stream.body. I tested locally, to compare results with Solr 5.4.1 + patch (in our product, currently) and Solr 6.6.0 + patch, and there is no important difference, when comparing results of MLT with stream.body between Solr versions. That's the important thing for us... Your opinion may differ. I'm actually more puzzled that SimpleMLTQParser retrieves exactly the same results with id, and with stream.body! How does it know what document to remove? One note about that weird "TODO" in RequestUtils : why not let the handler propagate the content-type it expects, if any, instead of trying to guess in the utility method? I'm not sure exactly where/how to do that, and how much impact it would have. > Add stream.body support to MLT QParser > -- > > Key: SOLR-7913 > URL: https://issues.apache.org/jira/browse/SOLR-7913 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta > Attachments: SOLR-7913.patch, SOLR-7913.patch, SOLR-7913.patch > > > Continuing from > https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011. > It'd be good to have stream.body be supported by the mlt qparser. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7913) Add stream.body support to MLT QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Molloy updated SOLR-7913: --- Attachment: SOLR-7913.patch Properly propagate content streams to shards so they can parse request properly. > Add stream.body support to MLT QParser > -- > > Key: SOLR-7913 > URL: https://issues.apache.org/jira/browse/SOLR-7913 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta > Attachments: SOLR-7913.patch, SOLR-7913.patch > > > Continuing from > https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011. > It'd be good to have stream.body be supported by the mlt qparser. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-7913) Add stream.body support to MLT QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Molloy updated SOLR-7913: --- Attachment: SOLR-7913.patch Patch allowing to use stream.body in mlt QParser. Need to align RequestUtil logic and TestRemoteStreaming, both of which would prevent stream from getting to QParser in there current state. Hacked the RequestUtil and ignored one of the TestRemoteStreaming for now, everything else passes on 5.3.1 code and applies cleanly on trunk. > Add stream.body support to MLT QParser > -- > > Key: SOLR-7913 > URL: https://issues.apache.org/jira/browse/SOLR-7913 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta > Attachments: SOLR-7913.patch > > > Continuing from > https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011. > It'd be good to have stream.body be supported by the mlt qparser. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
