[jira] [Updated] (SOLR-8184) Negative tests for JDBC Connection String
[ https://issues.apache.org/jira/browse/SOLR-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-8184: --- Fix Version/s: (was: 6.0) master (7.0) Manually correcting fixVersion per Step #S5 of LUCENE-7271 > Negative tests for JDBC Connection String > - > > Key: SOLR-8184 > URL: https://issues.apache.org/jira/browse/SOLR-8184 > Project: Solr > Issue Type: Test > Environment: Trunk >Reporter: Susheel Kumar >Assignee: Kevin Risden >Priority: Minor > Fix For: 6.1, master (7.0) > > Attachments: SOLR-8184.patch, SOLR-8184.patch, SOLR-8184.patch, > SOLR-8184.patch > > > Ticket to track negative tests for JDBC connection string SOLR-7986 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8184) Negative tests for JDBC Connection String
[ https://issues.apache.org/jira/browse/SOLR-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8184: --- Attachment: SOLR-8184.patch Attaching patch updated to master. Running precommit now. > Negative tests for JDBC Connection String > - > > Key: SOLR-8184 > URL: https://issues.apache.org/jira/browse/SOLR-8184 > Project: Solr > Issue Type: Test > Environment: Trunk >Reporter: Susheel Kumar >Assignee: Kevin Risden >Priority: Minor > Attachments: SOLR-8184.patch, SOLR-8184.patch, SOLR-8184.patch, > SOLR-8184.patch > > > Ticket to track negative tests for JDBC connection string SOLR-7986 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8184) Negative tests for JDBC Connection String
[ https://issues.apache.org/jira/browse/SOLR-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8184: -- Attachment: SOLR-8184.patch Updated patch takes the approach mentioned in the comments above (drop duplicate test, move tests into JdbcDriverTest where possible, fold remaining test into same test case of JdbcTest). Should be ready to go as far as I know, unless anyone knows of error cases they'd like covered by this story? > Negative tests for JDBC Connection String > - > > Key: SOLR-8184 > URL: https://issues.apache.org/jira/browse/SOLR-8184 > Project: Solr > Issue Type: Test > Environment: Trunk >Reporter: Susheel Kumar >Priority: Minor > Attachments: SOLR-8184.patch, SOLR-8184.patch, SOLR-8184.patch > > > Ticket to track negative tests for JDBC connection string SOLR-7986 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8184) Negative tests for JDBC Connection String
[ https://issues.apache.org/jira/browse/SOLR-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-8184: -- Attachment: SOLR-8184.patch I've updated this patch to work on the latest trunk. I had to make a few changes to allow the tests to pass: 1.) {{testConnectionStringWithWrongCollection}} expected {{SolrException}} in the original patch, however it turns out that on the latest trunk, it's {{SQLException}} that's actually thrown. I changed the exception-catching to reflect this. 2.) {{testConnectionStringWithWrongCollection}}'s use of ExpectedException prevented it from closing the db connection. I had to tweak this so that it could be closed. Still looking into whether the tests would run more efficiently under a different base-class. Though I did baseline the performance of the tests in JdbcTest. Without the additions in this patch, JdbcTest takes about 2min 15sec to run on my machine. With this patch, it takes about 3 mins to run. The ~45sec delta makes me suspect that the cases are being run inefficiently, but I haven't verified that yet. > Negative tests for JDBC Connection String > - > > Key: SOLR-8184 > URL: https://issues.apache.org/jira/browse/SOLR-8184 > Project: Solr > Issue Type: Test > Environment: Trunk >Reporter: Susheel Kumar >Priority: Minor > Attachments: SOLR-8184.patch, SOLR-8184.patch > > > Ticket to track negative tests for JDBC connection string SOLR-7986 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8184) Negative tests for JDBC Connection String
[ https://issues.apache.org/jira/browse/SOLR-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Susheel Kumar updated SOLR-8184: Environment: Trunk (was: Trunl) > Negative tests for JDBC Connection String > - > > Key: SOLR-8184 > URL: https://issues.apache.org/jira/browse/SOLR-8184 > Project: Solr > Issue Type: Test > Environment: Trunk >Reporter: Susheel Kumar >Priority: Minor > > Ticket to track negative tests for JDBC connection string SOLR-7986 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8184) Negative tests for JDBC Connection String
[ https://issues.apache.org/jira/browse/SOLR-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Susheel Kumar updated SOLR-8184: Flags: Patch > Negative tests for JDBC Connection String > - > > Key: SOLR-8184 > URL: https://issues.apache.org/jira/browse/SOLR-8184 > Project: Solr > Issue Type: Test > Environment: Trunk >Reporter: Susheel Kumar >Priority: Minor > > Ticket to track negative tests for JDBC connection string SOLR-7986 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8184) Negative tests for JDBC Connection String
[ https://issues.apache.org/jira/browse/SOLR-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Susheel Kumar updated SOLR-8184: Attachment: SOLR-8184.patch Negative tests for JDBC Connection String > Negative tests for JDBC Connection String > - > > Key: SOLR-8184 > URL: https://issues.apache.org/jira/browse/SOLR-8184 > Project: Solr > Issue Type: Test > Environment: Trunk >Reporter: Susheel Kumar >Priority: Minor > Attachments: SOLR-8184.patch > > > Ticket to track negative tests for JDBC connection string SOLR-7986 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org