[jira] [Updated] (SOLR-8315) Remove default core checks in the dispatch filter

2015-11-19 Thread Varun Thacker (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Thacker updated SOLR-8315:

Fix Version/s: Trunk

> Remove default core checks in the dispatch filter
> -
>
> Key: SOLR-8315
> URL: https://issues.apache.org/jira/browse/SOLR-8315
> Project: Solr
>  Issue Type: Improvement
>Reporter: Varun Thacker
>Assignee: Varun Thacker
>Priority: Minor
> Fix For: 5.4, Trunk
>
> Attachments: SOLR-8315.patch
>
>
> There are two occurrences in {{HttpSolrCall}} that still make checks for a 
> default core.
> {code}
> // try the default core
> if (core == null) {
> core = cores.getCore("");
> }
> {code}
> Is that needed anymore? I removed them and the tests seems to pass . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-8315) Remove default core checks in the dispatch filter

2015-11-19 Thread Varun Thacker (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Thacker updated SOLR-8315:

Attachment: SOLR-8315.patch

Simple patch which removes the two checks for default core. I'll commit this 
soon

> Remove default core checks in the dispatch filter
> -
>
> Key: SOLR-8315
> URL: https://issues.apache.org/jira/browse/SOLR-8315
> Project: Solr
>  Issue Type: Improvement
>Reporter: Varun Thacker
>Priority: Minor
> Attachments: SOLR-8315.patch
>
>
> There are two occurrences in {{HttpSolrCall}} that still make checks for a 
> default core.
> {code}
> // try the default core
> if (core == null) {
> core = cores.getCore("");
> }
> {code}
> Is that needed anymore? I removed them and the tests seems to pass . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org