[jira] [Updated] (SOLR-8353) Support regex for skipping license checksums
[ https://issues.apache.org/jira/browse/SOLR-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Chanan updated SOLR-8353: - Attachment: SOLR-8353.patch Thanks for taking a look, Mark. New patch fixes one of the log messages. > Support regex for skipping license checksums > > > Key: SOLR-8353 > URL: https://issues.apache.org/jira/browse/SOLR-8353 > Project: Solr > Issue Type: Improvement > Components: Build >Reporter: Gregory Chanan >Assignee: Gregory Chanan > Attachments: SOLR-8353.patch, SOLR-8353.patch > > > It would be useful to be able to specify a regex for license checksums to > skip in the build. Currently there are only two supported values: > 1) skipChecksum (i.e. regex=*) > 2) skipSnapshotsChecksum (i.e. regex=*-SNAPSHOT-*) > A regex would be more flexible and allow testing the entire build while > skipping a more limited set of checksums, e.g.: > a) an individual library (i.e. regex=joda-time*) > b) a suite of libraries (i.e. regex=hadoop*) > We could make skipChecksum and skipSnapshotsChecksum continue to work for > backwards compatbility reasons. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8353) Support regex for skipping license checksums
[ https://issues.apache.org/jira/browse/SOLR-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Chanan updated SOLR-8353: - Attachment: SOLR-8353.patch New patch. Perhaps there is a better way to do this, but defining the property to "" under the check-licenses target in both lucene and solr seems to work. Also, changed skipChecksumRegex to skipRegexChecksum to keep the ordering consistent with skipSnapshotsChecksum. > Support regex for skipping license checksums > > > Key: SOLR-8353 > URL: https://issues.apache.org/jira/browse/SOLR-8353 > Project: Solr > Issue Type: Improvement > Components: Build >Reporter: Gregory Chanan >Assignee: Gregory Chanan > Attachments: SOLR-8353.patch, SOLR-8353.patch, SOLR-8353.patch > > > It would be useful to be able to specify a regex for license checksums to > skip in the build. Currently there are only two supported values: > 1) skipChecksum (i.e. regex=*) > 2) skipSnapshotsChecksum (i.e. regex=*-SNAPSHOT-*) > A regex would be more flexible and allow testing the entire build while > skipping a more limited set of checksums, e.g.: > a) an individual library (i.e. regex=joda-time*) > b) a suite of libraries (i.e. regex=hadoop*) > We could make skipChecksum and skipSnapshotsChecksum continue to work for > backwards compatbility reasons. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8353) Support regex for skipping license checksums
[ https://issues.apache.org/jira/browse/SOLR-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Chanan updated SOLR-8353: - Attachment: SOLR-8353.patch Here's a patch that implements regex skiping while leaving skipChecksum and skipSnapshotsChecksum intact. I tested by changing the hadoop version and httpcore version (and passing -DskipChecksumRegex='hadoop.*') and verified that only httpcore complained. > Support regex for skipping license checksums > > > Key: SOLR-8353 > URL: https://issues.apache.org/jira/browse/SOLR-8353 > Project: Solr > Issue Type: Improvement > Components: Build >Reporter: Gregory Chanan > Attachments: SOLR-8353.patch > > > It would be useful to be able to specify a regex for license checksums to > skip in the build. Currently there are only two supported values: > 1) skipChecksum (i.e. regex=*) > 2) skipSnapshotsChecksum (i.e. regex=*-SNAPSHOT-*) > A regex would be more flexible and allow testing the entire build while > skipping a more limited set of checksums, e.g.: > a) an individual library (i.e. regex=joda-time*) > b) a suite of libraries (i.e. regex=hadoop*) > We could make skipChecksum and skipSnapshotsChecksum continue to work for > backwards compatbility reasons. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
