[jira] [Updated] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8519: --- Attachment: SOLR-8519.patch Added some comments to explain the added MetadataStream and includeMetadata parameter. No new tests since existing tests should cover this. The only thing I don't like about this approach is "fields" and "aliases" are hardcoded in the tuple.fields map. [~joel.bernstein] - I think this should be good to go. > Implement ResultSetMetaDataImpl.getColumnCount() > > > Key: SOLR-8519 > URL: https://issues.apache.org/jira/browse/SOLR-8519 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8519.patch, SOLR-8519.patch, SOLR-8519.patch, > SOLR-8519.patch > > > DBVisualizer uses getColumnCount to determine how many columns to try to > display from the result. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8519: --- Attachment: SOLR-8519.patch Here is an initial patch based on [~joel.bernstein]'s outline. It needs to be cleaned up a bit with comments and some more tests. I passed fields and aliases back as just a starting point. > Implement ResultSetMetaDataImpl.getColumnCount() > > > Key: SOLR-8519 > URL: https://issues.apache.org/jira/browse/SOLR-8519 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8519.patch, SOLR-8519.patch, SOLR-8519.patch > > > DBVisualizer uses getColumnCount to determine how many columns to try to > display from the result. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8519: --- Flags: Patch > Implement ResultSetMetaDataImpl.getColumnCount() > > > Key: SOLR-8519 > URL: https://issues.apache.org/jira/browse/SOLR-8519 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8519.patch, SOLR-8519.patch > > > DBVisualizer uses getColumnCount to determine how many columns to try to > display from the result. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8519: --- Attachment: SOLR-8519.patch This patch adds some framework to get information about a tuples fields which will be used for type information as well. The fields List will be in a random order until Tuple.fields returns a Map that is backed by LinkedHashMap for the keys. [~joel.bernstein] It might make sense to add to the Tuple instead of trying to do this all directly in the ResultSet metadata. This would make the Tuple more usable without the JDBC driver component. Thoughts on this approach? > Implement ResultSetMetaDataImpl.getColumnCount() > > > Key: SOLR-8519 > URL: https://issues.apache.org/jira/browse/SOLR-8519 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8519.patch > > > DBVisualizer uses getColumnCount to determine how many columns to try to > display from the result. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8519) Implement ResultSetMetaDataImpl.getColumnCount()
[ https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8519: --- Attachment: SOLR-8519.patch Improve patch to not create ResultSetMetaData on each call to ResultSet#getMetadata. > Implement ResultSetMetaDataImpl.getColumnCount() > > > Key: SOLR-8519 > URL: https://issues.apache.org/jira/browse/SOLR-8519 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8519.patch, SOLR-8519.patch > > > DBVisualizer uses getColumnCount to determine how many columns to try to > display from the result. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
