[jira] [Updated] (SOLR-8570) Make discountOverlaps' initialization value consistent across subclasses of SimilarityFactory

2016-01-27 Thread Ahmet Arslan (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SOLR-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ahmet Arslan updated SOLR-8570:
---
Fix Version/s: 5.5

> Make discountOverlaps' initialization value consistent across subclasses of 
> SimilarityFactory 
> --
>
> Key: SOLR-8570
> URL: https://issues.apache.org/jira/browse/SOLR-8570
> Project: Solr
>  Issue Type: Improvement
>Affects Versions: 5.4
>Reporter: Ahmet Arslan
>Priority: Minor
>  Labels: similarity
> Fix For: 5.5, Trunk
>
> Attachments: SOLR-8570.patch, SOLR-8570.patch
>
>
> Subclasses of SimilarityFactory have a member variable named 
> {{discountOverlaps}}.
> In ClassicSimilarityFactory, it is initialized to {{true}} in SOLR-5561.
> Since discountOverlaps' default value is true, we should do the same in 
> remaining subclasses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Updated] (SOLR-8570) Make discountOverlaps' initialization value consistent across subclasses of SimilarityFactory

2016-01-26 Thread Ahmet Arslan (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SOLR-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ahmet Arslan updated SOLR-8570:
---
Attachment: SOLR-8570.patch

Patch generated by {{git diff origin/master..SOLR-8570}} .

> Make discountOverlaps' initialization value consistent across subclasses of 
> SimilarityFactory 
> --
>
> Key: SOLR-8570
> URL: https://issues.apache.org/jira/browse/SOLR-8570
> Project: Solr
>  Issue Type: Improvement
>Affects Versions: 5.4
>Reporter: Ahmet Arslan
>Priority: Minor
>  Labels: similarity
> Fix For: Trunk
>
> Attachments: SOLR-8570.patch, SOLR-8570.patch
>
>
> Subclasses of SimilarityFactory have a member variable named 
> {{discountOverlaps}}.
> In ClassicSimilarityFactory, it is initialized to {{true}} in SOLR-5561.
> Since discountOverlaps' default value is true, we should do the same in 
> remaining subclasses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Updated] (SOLR-8570) Make discountOverlaps' initialization value consistent across subclasses of SimilarityFactory

2016-01-19 Thread Ahmet Arslan (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SOLR-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ahmet Arslan updated SOLR-8570:
---
Attachment: SOLR-8570.patch

I had this patch handy. However, does moving {{protected boolean 
discountOverlaps = true;}} into the SimilarityFactory breaks any good practices?

> Make discountOverlaps' initialization value consistent across subclasses of 
> SimilarityFactory 
> --
>
> Key: SOLR-8570
> URL: https://issues.apache.org/jira/browse/SOLR-8570
> Project: Solr
>  Issue Type: Improvement
>Affects Versions: 5.4
>Reporter: Ahmet Arslan
>Priority: Minor
>  Labels: similarity
> Fix For: Trunk
>
> Attachments: SOLR-8570.patch
>
>
> Subclasses of SimilarityFactory have a member variable named 
> {{discountOverlaps}}.
> In ClassicSimilarityFactory, it is initialized to {{true}} in SOLR-5561.
> Since discountOverlaps' default value is true, we should do the same in 
> remaining subclasses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org