[jira] [Updated] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8602: --- Fix Version/s: (was: master) 6.0 > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: master >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: 6.0 > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8602: --- Attachment: SOLR-8602.patch Improve exception handling so that the underlying exception is thrown where applicable. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8602: --- Attachment: SOLR-8602.patch Updated complete patch with tests for missing column. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-8602: - Attachment: SOLR-8602.patch Patch that moves the responsibility for setting the StreamContext to the SQLTupleStreamParser. This resolves the bug that [~risdenk] found. The test has been changed to numWorkers=2 and now passes and existing SQL tests pass. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8602: --- Attachment: SOLR-8602.patch The error is related to numWorkers > 1 and partitionKeys not being set. I set the numWorkers to 1 currently to work around this. If limit is not used and there is a missing column then it fails getting the first tuple saying missing column. This only happens when limit is not used. The two tests for not limits are commented out. This patch improves the testing by separating out the test method to allow changing connection parameters and sql query. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden >Assignee: Joel Bernstein > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch, > SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8602: --- Attachment: SOLR-8602.patch Improved implementation and added tests > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8602: --- Attachment: SOLR-8602.patch Fixed on top of SOLR-8520. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Fix For: Trunk > > Attachments: SOLR-8602.patch, SOLR-8602.patch, SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8602) Implement ResultSetImpl.wasNull()
[ https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-8602: --- Attachment: SOLR-8602.patch Implemented wasNull but need to add tests. This will require putting in a new column and null values in the indexr. > Implement ResultSetImpl.wasNull() > - > > Key: SOLR-8602 > URL: https://issues.apache.org/jira/browse/SOLR-8602 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Fix For: Trunk > > Attachments: SOLR-8602.patch > > > ResultSetImpl.wasNull is necessary for SQL clients to display a SQL NULL > instead of 0 or false for certain get* commands. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
