[ 
https://issues.apache.org/jira/browse/SOLR-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated SOLR-8793:
-----------------------------
    Attachment: SOLR-8793.patch

Patch fixes the bug by catching the {{IOException}} and returning -1. In that 
case, the index info will should a file size of -1, until the reader is 
refreshed.

I chose to return a -1 over setting an empty string, or not returning the value 
at all since I feel it's better, but if others think otherwise, please comment.

> Fix stale commit files' size computation in LukeRequestHandler
> --------------------------------------------------------------
>
>                 Key: SOLR-8793
>                 URL: https://issues.apache.org/jira/browse/SOLR-8793
>             Project: Solr
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 5.5
>            Reporter: Shai Erera
>            Priority: Minor
>         Attachments: SOLR-8793.patch
>
>
> SOLR-8587 added segments file information and its size to core admin status 
> API. However in case of stale commits, calling that API may result on 
> {{FileNotFoundException}} or {{NoSuchFileException}}, if the segments file no 
> longer exists due to a new commit. We should fix that by returning a proper 
> value for the file's length in this case, maybe -1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to