[jira] [Updated] (SOLR-9314) Add all known transformers to TestRandomFlRTGCloud and fix any bugs found
[ https://issues.apache.org/jira/browse/SOLR-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-9314: --- Attachment: SOLR-9314.patch RawValueTransformerFactory is in fact broken in cloud mode (RTG or otherwise) -- spun that off into SOLR-9376. Also filed SOLR-9377 to track fixing {{\[subquery\]}} ... both of those are going to be tricky, and i don't want the rest of these tests to be held up waiting for a fix. This updated patch cleans up all the nocommits, adds coverage for {{\[shard\]}} testing (which i thought i already had, but evidently not) and punts on the issue of testing {{\[child\]}} -- i just don't see any straight forward way of incorporating testing of that into this class w/o some serious changes to how the randomized updates happen, so i've filed SOLR-9379 to look into that further. --- I think this patch is good to go as is. > Add all known transformers to TestRandomFlRTGCloud and fix any bugs found > - > > Key: SOLR-9314 > URL: https://issues.apache.org/jira/browse/SOLR-9314 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Hoss Man > Attachments: SOLR-9314.patch, SOLR-9314.patch, SOLR-9314.patch > > > SOLR-9285 is/has added a new TestRandomFlRTGCloud for testing out random > permutations of {{fl}} params in RTG requests. > simple field names, field renames, field globs, and ValueSources/functions > are already tested -- adding additional DocTransformers is fairly straight > forward by implementing a simple FlValidator. > This issue is being filed to track the work needed to: > * review the list of all DocTransformers in solr and add test coverage of > them in this method > * file any blocker issues if new bugs are found in this process > * once all DocTransformers are accounted for, update TestRandomFlRTGCloud to > programatically compare the list of FlValidator's it knows about with the > list of all DocTransformers (similar to how > QueryEqualityTest.testParserCoverage works) to fail the test if anyone adds a > DocTransformer w/o adding corisponding test coverage to this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9314) Add all known transformers to TestRandomFlRTGCloud and fix any bugs found
[ https://issues.apache.org/jira/browse/SOLR-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-9314: --- Attachment: SOLR-9314.patch Updated patch to include a "testCoverage" that compares what validators we have with {{TransformerFactory.defaultFactories}} and a new RawFieldValueValidator for testing the {{\[json\]}} and {{\[xml\]}} transformers (backed by RawValueTransformerFactory) There's currently test failures related to RawFieldValueValidator -- i haven't dug in in depth, but it doesn't look like a test bug, it might be an actual bug in RawValueTransformerFactory when dealing with uncommited docs -- need to do some manual testing to sanity check. (I skimmed teh code in RawValueTransformerFactory but nothing jumped out at me) > Add all known transformers to TestRandomFlRTGCloud and fix any bugs found > - > > Key: SOLR-9314 > URL: https://issues.apache.org/jira/browse/SOLR-9314 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Hoss Man > Attachments: SOLR-9314.patch, SOLR-9314.patch > > > SOLR-9285 is/has added a new TestRandomFlRTGCloud for testing out random > permutations of {{fl}} params in RTG requests. > simple field names, field renames, field globs, and ValueSources/functions > are already tested -- adding additional DocTransformers is fairly straight > forward by implementing a simple FlValidator. > This issue is being filed to track the work needed to: > * review the list of all DocTransformers in solr and add test coverage of > them in this method > * file any blocker issues if new bugs are found in this process > * once all DocTransformers are accounted for, update TestRandomFlRTGCloud to > programatically compare the list of FlValidator's it knows about with the > list of all DocTransformers (similar to how > QueryEqualityTest.testParserCoverage works) to fail the test if anyone adds a > DocTransformer w/o adding corisponding test coverage to this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9314) Add all known transformers to TestRandomFlRTGCloud and fix any bugs found
[ https://issues.apache.org/jira/browse/SOLR-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-9314: --- Attachment: SOLR-9314.patch WIP patch with new validators for {{\[shard\]}}, {{\[explain\]}}, {{\[value\]}}, {{\[geo\]}}, and {{\[subquery\]}} The subquery validation tries to search for all docs with teh same field value as the current doc, asserting that there is always at least 1 match -- but this assertion currently fails ... by the looks of it this is (obviously) because it doesn't know to to use the realtime seracher re-opened by the RTG ... but based on how the SubQueryAugmenter is implemented, i'm not even certain how to go about it. > Add all known transformers to TestRandomFlRTGCloud and fix any bugs found > - > > Key: SOLR-9314 > URL: https://issues.apache.org/jira/browse/SOLR-9314 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Hoss Man > Attachments: SOLR-9314.patch > > > SOLR-9285 is/has added a new TestRandomFlRTGCloud for testing out random > permutations of {{fl}} params in RTG requests. > simple field names, field renames, field globs, and ValueSources/functions > are already tested -- adding additional DocTransformers is fairly straight > forward by implementing a simple FlValidator. > This issue is being filed to track the work needed to: > * review the list of all DocTransformers in solr and add test coverage of > them in this method > * file any blocker issues if new bugs are found in this process > * once all DocTransformers are accounted for, update TestRandomFlRTGCloud to > programatically compare the list of FlValidator's it knows about with the > list of all DocTransformers (similar to how > QueryEqualityTest.testParserCoverage works) to fail the test if anyone adds a > DocTransformer w/o adding corisponding test coverage to this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org