[jira] [Updated] (SOLR-9935) When hl.method=unified add support for hl.fragsize param

2017-01-07 Thread David Smiley (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated SOLR-9935:
---
Attachment: SOLR_9935_UH_fragsize.patch

Updated patch to account for API change in LUCENE-7620. Clarified the test a 
bit and some other related test methods.  I'll commit later today.  In 
CHANGES.txt I'll remove the note about UH not supporting hl.fragsize (yay).

Features in the original highlighter that are _not_ in the UH (as seen through 
Solr) are:
* influence passage scoring from boosts in the query
* {{hl.mergeContiguous}} defaults to false.  In the UH, DefaultPassageFormatter 
always merges contiguous passages.  
* {{hl.alternateField}} and related options
* {{hl.maxMultiValueToExamine}} (a performance circuit-breaker). Doesn't seem 
as pertinent to the UH as the original Highlighter.
* regex based Passage delineation option
* {{hl.preserveMulti}} the original Highlighter supports "true" (false by 
default) but the UH doesn't do this.

> When hl.method=unified add support for hl.fragsize param
> 
>
> Key: SOLR-9935
> URL: https://issues.apache.org/jira/browse/SOLR-9935
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: highlighter
>Reporter: David Smiley
>Assignee: David Smiley
> Attachments: SOLR_9935_UH_fragsize.patch, SOLR_9935_UH_fragsize.patch
>
>
> In LUCENE-7620 the UnifiedHighlighter is getting a BreakIterator that allows 
> it to support the equivalent of Solr's {{hl.fragsize}}.  So lets support this 
> on the Solr side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Updated] (SOLR-9935) When hl.method=unified add support for hl.fragsize param

2017-01-05 Thread David Smiley (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated SOLR-9935:
---
Attachment: SOLR_9935_UH_fragsize.patch

Here's a patch.  The default fragsize chosen is 70 as that is the same used 
when the regex fragmenter (of the original Highlighter) is used in Solr.  These 
are both similar in that you typically want to shoot for a passage about a 
sentence in length.

Note the regex fragmenter has a "slop" feature that is 60% of the fragsize... 
this is not (yet) supported by the UH's LengthGoalBreakIterator.

When LUCENE-7620 lands (this weekend?), I plan to commit this immediately after.

> When hl.method=unified add support for hl.fragsize param
> 
>
> Key: SOLR-9935
> URL: https://issues.apache.org/jira/browse/SOLR-9935
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: highlighter
>Reporter: David Smiley
>Assignee: David Smiley
> Attachments: SOLR_9935_UH_fragsize.patch
>
>
> In LUCENE-7620 the UnifiedHighlighter is getting a BreakIterator that allows 
> it to support the equivalent of Solr's {{hl.fragsize}}.  So lets support this 
> on the Solr side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org