[jira] [Commented] (SOLR-2415) Change XMLWriter version parameter to wt.xml.version
[
https://issues.apache.org/jira/browse/SOLR-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011390#comment-13011390
]
Ryan McKinley commented on SOLR-2415:
-
Looks like most of the tests send params={wt=javabinversion=2} this does not
do anything...
Hoss, I now agree that wt.version should apply to whatever WT we are talking to.
The discussion about structure changes should be elsewhere
Change XMLWriter version parameter to wt.xml.version
--
Key: SOLR-2415
URL: https://issues.apache.org/jira/browse/SOLR-2415
Project: Solr
Issue Type: Improvement
Reporter: Ryan McKinley
Priority: Trivial
Fix For: 4.0
The XMLWriter has a parameter called 'version'. This controls some specifics
about how the XMLWriter works. Using the parameter name 'version' made sense
back when the XMLWriter was the only option, but with all the various writers
and different places where 'version' makes sense, I think we should change
this parameter name to wt.xml.version so that it specifically refers to the
XMLWriter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2415) Change XMLWriter version parameter to wt.xml.version
[ https://issues.apache.org/jira/browse/SOLR-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010308#comment-13010308 ] Hoss Man commented on SOLR-2415: bq. how should we handle the desire to change the faceting format (to make it easier to add metadata like total number of constraints, etc)? version would be one way. facet.format would be another way. i don't think the *structure* of the response (ie: the facet response section) should be driven by the same param as the *format* of the response, which is what version currently is. Something like facet.format seems more appropriate when dealing with a specific component like that ... but i don't think it should be a numeric version equse property, i think it should be descriptive (ie: flat, vs nested or something) bq. perhaps we should add a getVersion() parameter on SolrQueryRequest and have that used across all components. when i suggested we have a common wt.version param that all of the response writers could use, i didn't mean to suggest that it should have a singular id space. my suggestion was that the specific values specified for version or wt.version or whatever would only be meaningful to the specific response writer used -- just as the current values of the version param that the XMLResponseWriter uses are meaninless to the JSONResponseWriter. the overlap would only be in reusing the param name (in the same way that q is the common param name for the main query, regardless of what query parser is specified by defType) bq. Look at how long the existing response writers have hung around in their current format, independent of the version # changes (1.2, 1.3, 1.4, and now 3.1) the version param of the XML response writer has never been in sync with the solr version, it was never intended to be. it's always been the version number of the xml format. Change XMLWriter version parameter to wt.xml.version -- Key: SOLR-2415 URL: https://issues.apache.org/jira/browse/SOLR-2415 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Priority: Trivial Fix For: 4.0 The XMLWriter has a parameter called 'version'. This controls some specifics about how the XMLWriter works. Using the parameter name 'version' made sense back when the XMLWriter was the only option, but with all the various writers and different places where 'version' makes sense, I think we should change this parameter name to wt.xml.version so that it specifically refers to the XMLWriter. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2415) Change XMLWriter version parameter to wt.xml.version
[ https://issues.apache.org/jira/browse/SOLR-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007688#comment-13007688 ] Hoss Man commented on SOLR-2415: i'm with ryan. if it had always been respversion or something i wouldn't mind, and would encourage other response writers to use it for their own versioning purposes (ie: the json writer could have change the default for json.nl based on version). but version is just so damn generic, it's really hard to have any idea what it's taking about. (even xml.version is ambiguious: is it the format coming in, or going out? I'd suggest either adding wt.version or wt.xml.version (depending on how people feel about the idea that it should/can be reused by all response writers in their own way) to 3.x with a fallback to using version if it's specified and mark version deprecated ... then remove it completley at a much later date (maybe 4.0, depends on when it comes out and how many 3.x releases come first) Change XMLWriter version parameter to wt.xml.version -- Key: SOLR-2415 URL: https://issues.apache.org/jira/browse/SOLR-2415 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Priority: Trivial Fix For: 4.0 The XMLWriter has a parameter called 'version'. This controls some specifics about how the XMLWriter works. Using the parameter name 'version' made sense back when the XMLWriter was the only option, but with all the various writers and different places where 'version' makes sense, I think we should change this parameter name to wt.xml.version so that it specifically refers to the XMLWriter. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2415) Change XMLWriter version parameter to wt.xml.version
[ https://issues.apache.org/jira/browse/SOLR-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007695#comment-13007695 ] Yonik Seeley commented on SOLR-2415: On a highly related question, how should we handle the desire to change the faceting format (to make it easier to add metadata like total number of constraints, etc)? version would be one way. facet.format would be another way. Change XMLWriter version parameter to wt.xml.version -- Key: SOLR-2415 URL: https://issues.apache.org/jira/browse/SOLR-2415 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Priority: Trivial Fix For: 4.0 The XMLWriter has a parameter called 'version'. This controls some specifics about how the XMLWriter works. Using the parameter name 'version' made sense back when the XMLWriter was the only option, but with all the various writers and different places where 'version' makes sense, I think we should change this parameter name to wt.xml.version so that it specifically refers to the XMLWriter. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2415) Change XMLWriter version parameter to wt.xml.version
[ https://issues.apache.org/jira/browse/SOLR-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007805#comment-13007805 ] Ryan McKinley commented on SOLR-2415: - I see two approaches to the general problem: 1. each component gets its own version (wt.xml.version, facet.version, hl.version, etc) 2. a single 'version' param that multiple components use. I think option #2 makes more sense, perhaps we should add a getVersion() parameter on SolrQueryRequest and have that used across all components. For facet format (SOLR-2242) this should work, but I also hope that major versions (4.0 etc) can drop old formats since maintaining these for a long time can be a PIA. Change XMLWriter version parameter to wt.xml.version -- Key: SOLR-2415 URL: https://issues.apache.org/jira/browse/SOLR-2415 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Priority: Trivial Fix For: 4.0 The XMLWriter has a parameter called 'version'. This controls some specifics about how the XMLWriter works. Using the parameter name 'version' made sense back when the XMLWriter was the only option, but with all the various writers and different places where 'version' makes sense, I think we should change this parameter name to wt.xml.version so that it specifically refers to the XMLWriter. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2415) Change XMLWriter version parameter to wt.xml.version
[ https://issues.apache.org/jira/browse/SOLR-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007814#comment-13007814 ] Chris A. Mattmann commented on SOLR-2415: - At the rate of release cycles on this project, I'd seriously recommend against actually specifying versions, and fallbacks, etc., specifically for response writers other than the existing Solr version. Look at how long the existing response writers have hung around in their current format, independent of the version # changes (1.2, 1.3, 1.4, and now 3.1). In all of these cases, you simply could keep docs that say 1.2 is compatible (forwards) with 1.x, etc., and 3.x is compatible (backwards) with 1.x, etc. Change XMLWriter version parameter to wt.xml.version -- Key: SOLR-2415 URL: https://issues.apache.org/jira/browse/SOLR-2415 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Priority: Trivial Fix For: 4.0 The XMLWriter has a parameter called 'version'. This controls some specifics about how the XMLWriter works. Using the parameter name 'version' made sense back when the XMLWriter was the only option, but with all the various writers and different places where 'version' makes sense, I think we should change this parameter name to wt.xml.version so that it specifically refers to the XMLWriter. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2415) Change XMLWriter version parameter to wt.xml.version
[ https://issues.apache.org/jira/browse/SOLR-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004834#comment-13004834 ] Yonik Seeley commented on SOLR-2415: version doesn't have to just apply to the XML response format - it could apply to any response formats that change. If we were starting off fresh, something like xml.version might make sense... but for people using version right now, it would be nice if the XML format didn't change out from under them next time we upgrade the format? Change XMLWriter version parameter to wt.xml.version -- Key: SOLR-2415 URL: https://issues.apache.org/jira/browse/SOLR-2415 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Priority: Trivial Fix For: 4.0 The XMLWriter has a parameter called 'version'. This controls some specifics about how the XMLWriter works. Using the parameter name 'version' made sense back when the XMLWriter was the only option, but with all the various writers and different places where 'version' makes sense, I think we should change this parameter name to wt.xml.version so that it specifically refers to the XMLWriter. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
