[jira] [Updated] (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Rowe updated LUCENE-2609: Priority: Blocker (was: Minor) Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Steven Rowe Priority: Blocker Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Rowe updated LUCENE-2609: Attachment: LUCENE-2609-naming-fixes.patch Patch against branches/lucene_solr_3_1 that addresses the naming issues. Testing now - if no problems, I will commit shortly. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Steven Rowe Priority: Blocker Fix For: 3.1, 4.0 Attachments: LUCENE-2609-naming-fixes.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Rowe updated LUCENE-2609: Attachment: LUCENE-2609-naming-fixes.patch This version of the patch adds an include pattern to {{lucene/build.xml}}'s {{binary.build.dist.patterns}} patternset for the renamed {{lucene-test-framework-version.jar}}, so that the test-framework binary and javaodc jars will be included in the binary packages, and adds an exclude pattern so that the test-framework source jar is excluded from the non-Maven binary packages. Everything seems to work with this patch. Committing shortly. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Steven Rowe Priority: Blocker Fix For: 3.1, 4.0 Attachments: LUCENE-2609-naming-fixes.patch, LUCENE-2609-naming-fixes.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Rowe updated LUCENE-2609: Attachment: LUCENE-2609.patch This patch includes a new POM template for the Lucene test framework. I ran into an issue with circular dependence: Lucene core can't depend on the test framework, because the test framework depends on Lucene core. I solved this problem by including {{src/test-framework/}} in Lucene core's test source directories, so that no dependency is required on the test framework. {{ant generate-maven-artifacts}} is also modified to include the binary, source, and javadoc jars for the test framework. I tried to make all other modules depend only on the test framework, but several Lucene contrib modules refer to Lucene test classes that were not included in {{src/test-framework}}: analyzers/common, icu, misc, queryparser, and remote. For these, I kept the previous dependency on the full Lucene tests jar. One other minor change in this patch: the {{jarify}} macro now has an optional {{excludes}} attribute that defaults to {{**/pom.xml}}, so that {{pom.xml}} files don't end up in any jars. This patch includes all of Shai's patch, as well as a minor addition mentioned by Uwe on IRC: title attributes are included for all test-framework jarify calls. Like Shai's patch, I excluded the moved java files from the patch. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Shai Erera Priority: Minor Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2609: --- Attachment: LUCENE-2609.patch Fix some more Ant targets and adds javadocs-test-framework and jar-test-framework-src. Also adds dependencies on both of these. Don't forget to run the svn mv commands from above and also svn rm dev-tools/testjar Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Shai Erera Priority: Minor Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2609: --- Attachment: LUCENE-2609.patch Last patch had misplaced text outside a target. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Shai Erera Priority: Minor Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2609: --- Attachment: LUCENE-2609.patch Patch fixes the manifest issue Uwe raised. I exposed a title attribute in jarify, which defaults to whatever build-manifest defaults, and is set by jar-test-framework to Lucene Search Engine: Test Framework. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Shai Erera Priority: Minor Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2609: --- Attachment: LUCENE-2609.patch Previous patch was hard to review IMO. This patch includes the changes to the .xml files only. If you run the 'svn mv' commands I pasted before and then apply this patch, all should work. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Shai Erera Priority: Minor Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2609: --- Attachment: LUCENE-2609.patch Patch fixes Solr build.xmls to depend only on lucene's test-framework, as well as removing dev-tools/testjar. Again, I only included the .xml changes in the path - the rest are just svn moves. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Shai Erera Priority: Minor Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2609: --- Attachment: LUCENE-2609.patch Patch includes changes to build.xmls (ignore the other changes, they are caused by svn moves -- I didn't touch the source files). I'd appreciate an Ant 'expert' looking at them. Since some tests depend on other tests (e.g. through extension) and other classes that are not under test-framework, I couldn't make a test.classpath that references test-framework only. So I modified test.classpath to reference both classes/test and classes/test-framework. If you want to apply the patch, make sure to run the following commands: {noformat} svn mkdir lucene/src/test-framework svn mv --parents lucene/src/test/org/apache/lucene/util/_TestUtil.java lucene/src/test-framework/org/apache/lucene/util/_TestUtil.java svn mv --parents lucene/src/test/org/apache/lucene/util/LineFileDocs.java lucene/src/test-framework/org/apache/lucene/util/LineFileDocs.java svn mv --parents lucene/src/test/org/apache/lucene/util/LuceneJUnitDividingSelector.java lucene/src/test-framework/org/apache/lucene/util/LuceneJUnitDividingSelector.java svn mv --parents lucene/src/test/org/apache/lucene/util/LuceneJUnitResultFormatter.java lucene/src/test-framework/org/apache/lucene/util/LuceneJUnitResultFormatter.java svn mv --parents lucene/src/test/org/apache/lucene/util/LuceneTestCase.java lucene/src/test-framework/org/apache/lucene/util/LuceneTestCase.java svn mv --parents lucene/src/test/org/apache/lucene/search/QueryUtils.java lucene/src/test-framework/org/apache/lucene/search/QueryUtils.java svn mv --parents lucene/src/test/org/apache/lucene/search/CheckHits.java lucene/src/test-framework/org/apache/lucene/search/CheckHits.java svn mv --parents lucene/src/test/org/apache/lucene/analysis/BaseTokenStreamTestCase.java lucene/src/test-framework/org/apache/lucene/analysis/BaseTokenStreamTestCase.java svn mv --parents lucene/src/test/org/apache/lucene/analysis/MockAnalyzer.java lucene/src/test-framework/org/apache/lucene/analysis/MockAnalyzer.java svn mv --parents lucene/src/test/org/apache/lucene/index/MockIndexInput.java lucene/src/test-framework/org/apache/lucene/index/MockIndexInput.java svn mv --parents lucene/src/test/org/apache/lucene/index/RandomIndexWriter.java lucene/src/test-framework/org/apache/lucene/index/RandomIndexWriter.java svn mv --parents lucene/src/test/org/apache/lucene/index/DocHelper.java lucene/src/test-framework/org/apache/lucene/index/DocHelper.java svn mv --parents lucene/src/test/org/apache/lucene/store/_TestHelper.java lucene/src/test-framework/org/apache/lucene/store/_TestHelper.java svn mv --parents lucene/src/test/org/apache/lucene/store/MockDirectoryWrapper.java lucene/src/test-framework/org/apache/lucene/store/MockDirectoryWrapper.java svn mv --parents lucene/src/test/org/apache/lucene/store/MockIndexInputWrapper.java lucene/src/test-framework/org/apache/lucene/store/MockIndexInputWrapper.java svn mv --parents lucene/src/test/org/apache/lucene/store/MockIndexOutputWrapper.java lucene/src/test-framework/org/apache/lucene/store/MockIndexOutputWrapper.java {noformat} I did not convert Solr build yet - will do so after we review the 'lucene' patch. Also, can someone please list the Solr test-framework classes? I will handle them as well. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Shai Erera Priority: Minor Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-2609) Generate jar containing test classes.
[ https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2609: --- Attachment: LUCENE-2609.patch * Moves jar-core-test to build.xml * Adds dev-tools/testjar/testfiles with a list of files (includes what Simon listed so far) -- we can add more as we go ** Both .java and .class are added. Generate jar containing test classes. - Key: LUCENE-2609 URL: https://issues.apache.org/jira/browse/LUCENE-2609 Project: Lucene - Java Issue Type: Improvement Components: Build Affects Versions: 3.0.2 Reporter: Drew Farris Assignee: Shai Erera Priority: Minor Fix For: 3.1, 4.0 Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch The test classes are useful for writing unit tests for code external to the Lucene project. It would be helpful to build a jar of these classes and publish them as a maven dependency. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org