RE: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL in standalone-mode master/slave auth with local security.json

2017-02-24 Thread Uwe Schindler
Thanks!

 

-

Uwe Schindler

Achterdiek 19, D-28357 Bremen

http://www.thetaphi.de  

eMail: u...@thetaphi.de

 

From: Jan Høydahl [mailto:jan@cominvent.com] 
Sent: Saturday, February 25, 2017 12:49 AM
To: dev@lucene.apache.org
Subject: Re: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL 
in standalone-mode master/slave auth with local security.json

 

Reverted.

 

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com  

 

25. feb. 2017 kl. 00.13 skrev Jan Høydahl  >:

 

Looking…

 

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com  

 

24. feb. 2017 kl. 19.48 skrev Uwe Schindler  >:

 

I have the feeling this broke Jenkins. Millions of NPEs with JDK 8u121:

  
https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/19042/console

130 test failures by NPE in 
org.apache.solr.core.CoreContainer.getNodeNameLocal()

-
Uwe Schindler
Achterdiek 19, D-28357 Bremen
  http://www.thetaphi.de
eMail:   u...@thetaphi.de




-Original Message-
From: jan...@apache.org   [mailto:jan...@apache.org]
Sent: Friday, February 24, 2017 2:31 PM
To: comm...@lucene.apache.org  
Subject: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL
in standalone-mode master/slave auth with local security.json

Repository: lucene-solr
Updated Branches:
 refs/heads/master 5eeb8136f -> 95d6fc251


SOLR-9640: Support PKI authentication and SSL in standalone-mode
master/slave auth with local security.json


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-
solr/commit/95d6fc25
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/95d6fc25
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/95d6fc25

Branch: refs/heads/master
Commit: 95d6fc2512d6525b2354165553f0d6cc4d0d6310
Parents: 5eeb813
Author: Jan HC8ydahl  >
Authored: Fri Feb 24 14:26:48 2017 +0100
Committer: Jan HC8ydahl  >
Committed: Fri Feb 24 14:30:42 2017 +0100

--
solr/CHANGES.txt|   2 +
.../org/apache/solr/core/CoreContainer.java |   9 +-
.../solr/security/PKIAuthenticationPlugin.java  |  42 +-
.../org/apache/solr/servlet/HttpSolrCall.java   |   4 +-
.../apache/solr/servlet/SolrDispatchFilter.java |  11 +-
.../solr/security/BasicAuthDistributedTest.java | 136 +++
.../security/TestPKIAuthenticationPlugin.java   |  38 +-
.../solr/BaseDistributedSearchTestCase.java |  37 -
8 files changed, 260 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/lucene-
solr/blob/95d6fc25/solr/CHANGES.txt
--
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 0302615..2c5f0db 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -134,6 +134,8 @@ New Features
  field must both be stored=false, indexed=false, docValues=true. (Ishan
Chattopadhyaya, hossman, noble,
  shalin, yonik)

+* SOLR-9640: Support PKI authentication and SSL in standalone-mode
master/slave auth with local security.json (janhoy)
+
Bug Fixes
--


http://git-wip-us.apache.org/repos/asf/lucene-
solr/blob/95d6fc25/solr/core/src/java/org/apache/solr/core/CoreContainer.
java
--
diff --git a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
index e3977d7..6115562 100644
--- a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
+++ b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
@@ -497,7 +497,9 @@ public class CoreContainer {
hostName = cfg.getNodeName();

zkSys.initZooKeeper(this, solrHome, cfg.getCloudConfig());
-if(isZooKeeperAware())  pkiAuthenticationPlugin = new
PKIAuthenticationPlugin(this, zkSys.getZkController().getNodeName());
+pkiAuthenticationPlugin = isZooKeeperAware() ?
+new PKIAuthenticationPlugin(this,
zkSys.getZkController().getNodeName()) :
+new PKIAuthenticationPlugin(this, getNodeNameLocal());

MDCLoggingContext.setNode(this);

@@ -618,6 +620,11 @@ public class CoreContainer {
}
  }

+  // Builds a node name to be used with PKIAuth.
+  private String getNodeNameLocal() {
+return
getConfig().getCloudConfig().getHost()+":"+getConfig().getCloudConfig().getS
olrHostPort()+"_solr";
+  

Re: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL in standalone-mode master/slave auth with local security.json

2017-02-24 Thread Jan Høydahl
Reverted.

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

> 25. feb. 2017 kl. 00.13 skrev Jan Høydahl :
> 
> Looking…
> 
> --
> Jan Høydahl, search solution architect
> Cominvent AS - www.cominvent.com 
> 
>> 24. feb. 2017 kl. 19.48 skrev Uwe Schindler > >:
>> 
>> I have the feeling this broke Jenkins. Millions of NPEs with JDK 8u121:
>> 
>> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/19042/console 
>> 
>> 
>> 130 test failures by NPE in 
>> org.apache.solr.core.CoreContainer.getNodeNameLocal()
>> 
>> -
>> Uwe Schindler
>> Achterdiek 19, D-28357 Bremen
>> http://www.thetaphi.de 
>> eMail: u...@thetaphi.de 
>> 
>>> -Original Message-
>>> From: jan...@apache.org  
>>> [mailto:jan...@apache.org ]
>>> Sent: Friday, February 24, 2017 2:31 PM
>>> To: comm...@lucene.apache.org 
>>> Subject: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL
>>> in standalone-mode master/slave auth with local security.json
>>> 
>>> Repository: lucene-solr
>>> Updated Branches:
>>>  refs/heads/master 5eeb8136f -> 95d6fc251
>>> 
>>> 
>>> SOLR-9640: Support PKI authentication and SSL in standalone-mode
>>> master/slave auth with local security.json
>>> 
>>> 
>>> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo 
>>> 
>>> Commit: http://git-wip-us.apache.org/repos/asf/lucene- 
>>> 
>>> solr/commit/95d6fc25
>>> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/95d6fc25 
>>> 
>>> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/95d6fc25 
>>> 
>>> 
>>> Branch: refs/heads/master
>>> Commit: 95d6fc2512d6525b2354165553f0d6cc4d0d6310
>>> Parents: 5eeb813
>>> Author: Jan HC8ydahl >
>>> Authored: Fri Feb 24 14:26:48 2017 +0100
>>> Committer: Jan HC8ydahl >
>>> Committed: Fri Feb 24 14:30:42 2017 +0100
>>> 
>>> --
>>> solr/CHANGES.txt|   2 +
>>> .../org/apache/solr/core/CoreContainer.java |   9 +-
>>> .../solr/security/PKIAuthenticationPlugin.java  |  42 +-
>>> .../org/apache/solr/servlet/HttpSolrCall.java   |   4 +-
>>> .../apache/solr/servlet/SolrDispatchFilter.java |  11 +-
>>> .../solr/security/BasicAuthDistributedTest.java | 136 +++
>>> .../security/TestPKIAuthenticationPlugin.java   |  38 +-
>>> .../solr/BaseDistributedSearchTestCase.java |  37 -
>>> 8 files changed, 260 insertions(+), 19 deletions(-)
>>> --
>>> 
>>> 
>>> http://git-wip-us.apache.org/repos/asf/lucene- 
>>> 
>>> solr/blob/95d6fc25/solr/CHANGES.txt
>>> --
>>> diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
>>> index 0302615..2c5f0db 100644
>>> --- a/solr/CHANGES.txt
>>> +++ b/solr/CHANGES.txt
>>> @@ -134,6 +134,8 @@ New Features
>>>   field must both be stored=false, indexed=false, docValues=true. (Ishan
>>> Chattopadhyaya, hossman, noble,
>>>   shalin, yonik)
>>> 
>>> +* SOLR-9640: Support PKI authentication and SSL in standalone-mode
>>> master/slave auth with local security.json (janhoy)
>>> +
>>> Bug Fixes
>>> --
>>> 
>>> 
>>> http://git-wip-us.apache.org/repos/asf/lucene-
>>> solr/blob/95d6fc25/solr/core/src/java/org/apache/solr/core/CoreContainer.
>>> java
>>> --
>>> diff --git a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>>> b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>>> index e3977d7..6115562 100644
>>> --- a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>>> +++ b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>>> @@ -497,7 +497,9 @@ public class CoreContainer {
>>> hostName = cfg.getNodeName();
>>> 
>>> zkSys.initZooKeeper(this, solrHome, cfg.getCloudConfig());
>>> -if(isZooKeeperAware())  pkiAuthenticationPlugin = new
>>> PKIAuthenticationPlugin(this, zkSys.getZkController().getNodeName());
>>> +pkiAuthenticationPlugin = isZooKeeperAware() ?
>>> +new PKIAuthenticationPlugin(this,
>>> zkSys.getZkController().getNodeName()) :
>>> +new PKIAuthenticationPlugin(this, getNodeNameLocal());
>>> 
>>> MDCLoggingContext.setNode(this);
>>> 
>>> @@ -618,6 

Re: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL in standalone-mode master/slave auth with local security.json

2017-02-24 Thread Jan Høydahl
Looking…

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

> 24. feb. 2017 kl. 19.48 skrev Uwe Schindler :
> 
> I have the feeling this broke Jenkins. Millions of NPEs with JDK 8u121:
> 
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/19042/console 
> 
> 
> 130 test failures by NPE in 
> org.apache.solr.core.CoreContainer.getNodeNameLocal()
> 
> -
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> http://www.thetaphi.de 
> eMail: u...@thetaphi.de 
> 
>> -Original Message-
>> From: jan...@apache.org  [mailto:jan...@apache.org 
>> ]
>> Sent: Friday, February 24, 2017 2:31 PM
>> To: comm...@lucene.apache.org 
>> Subject: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL
>> in standalone-mode master/slave auth with local security.json
>> 
>> Repository: lucene-solr
>> Updated Branches:
>>  refs/heads/master 5eeb8136f -> 95d6fc251
>> 
>> 
>> SOLR-9640: Support PKI authentication and SSL in standalone-mode
>> master/slave auth with local security.json
>> 
>> 
>> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/lucene-
>> solr/commit/95d6fc25
>> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/95d6fc25
>> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/95d6fc25
>> 
>> Branch: refs/heads/master
>> Commit: 95d6fc2512d6525b2354165553f0d6cc4d0d6310
>> Parents: 5eeb813
>> Author: Jan HC8ydahl >
>> Authored: Fri Feb 24 14:26:48 2017 +0100
>> Committer: Jan HC8ydahl >
>> Committed: Fri Feb 24 14:30:42 2017 +0100
>> 
>> --
>> solr/CHANGES.txt|   2 +
>> .../org/apache/solr/core/CoreContainer.java |   9 +-
>> .../solr/security/PKIAuthenticationPlugin.java  |  42 +-
>> .../org/apache/solr/servlet/HttpSolrCall.java   |   4 +-
>> .../apache/solr/servlet/SolrDispatchFilter.java |  11 +-
>> .../solr/security/BasicAuthDistributedTest.java | 136 +++
>> .../security/TestPKIAuthenticationPlugin.java   |  38 +-
>> .../solr/BaseDistributedSearchTestCase.java |  37 -
>> 8 files changed, 260 insertions(+), 19 deletions(-)
>> --
>> 
>> 
>> http://git-wip-us.apache.org/repos/asf/lucene-
>> solr/blob/95d6fc25/solr/CHANGES.txt
>> --
>> diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
>> index 0302615..2c5f0db 100644
>> --- a/solr/CHANGES.txt
>> +++ b/solr/CHANGES.txt
>> @@ -134,6 +134,8 @@ New Features
>>   field must both be stored=false, indexed=false, docValues=true. (Ishan
>> Chattopadhyaya, hossman, noble,
>>   shalin, yonik)
>> 
>> +* SOLR-9640: Support PKI authentication and SSL in standalone-mode
>> master/slave auth with local security.json (janhoy)
>> +
>> Bug Fixes
>> --
>> 
>> 
>> http://git-wip-us.apache.org/repos/asf/lucene-
>> solr/blob/95d6fc25/solr/core/src/java/org/apache/solr/core/CoreContainer.
>> java
>> --
>> diff --git a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>> b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>> index e3977d7..6115562 100644
>> --- a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>> +++ b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
>> @@ -497,7 +497,9 @@ public class CoreContainer {
>> hostName = cfg.getNodeName();
>> 
>> zkSys.initZooKeeper(this, solrHome, cfg.getCloudConfig());
>> -if(isZooKeeperAware())  pkiAuthenticationPlugin = new
>> PKIAuthenticationPlugin(this, zkSys.getZkController().getNodeName());
>> +pkiAuthenticationPlugin = isZooKeeperAware() ?
>> +new PKIAuthenticationPlugin(this,
>> zkSys.getZkController().getNodeName()) :
>> +new PKIAuthenticationPlugin(this, getNodeNameLocal());
>> 
>> MDCLoggingContext.setNode(this);
>> 
>> @@ -618,6 +620,11 @@ public class CoreContainer {
>> }
>>   }
>> 
>> +  // Builds a node name to be used with PKIAuth.
>> +  private String getNodeNameLocal() {
>> +return
>> getConfig().getCloudConfig().getHost()+":"+getConfig().getCloudConfig().getS
>> olrHostPort()+"_solr";
>> +  }
>> +
>>   public void securityNodeChanged() {
>> log.info("Security node changed, reloading security.json");
>> reloadSecurityProperties();
>> 
>> http://git-wip-us.apache.org/repos/asf/lucene-
>> solr/blob/95d6fc25/solr/core/src/java/org/apache/solr/security/PKIAuthenti
>> cationPlugin.java
>> 

RE: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL in standalone-mode master/slave auth with local security.json

2017-02-24 Thread Uwe Schindler
I have the feeling this broke Jenkins. Millions of NPEs with JDK 8u121:

https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/19042/console

130 test failures by NPE in 
org.apache.solr.core.CoreContainer.getNodeNameLocal()

-
Uwe Schindler
Achterdiek 19, D-28357 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de

> -Original Message-
> From: jan...@apache.org [mailto:jan...@apache.org]
> Sent: Friday, February 24, 2017 2:31 PM
> To: comm...@lucene.apache.org
> Subject: lucene-solr:master: SOLR-9640: Support PKI authentication and SSL
> in standalone-mode master/slave auth with local security.json
> 
> Repository: lucene-solr
> Updated Branches:
>   refs/heads/master 5eeb8136f -> 95d6fc251
> 
> 
> SOLR-9640: Support PKI authentication and SSL in standalone-mode
> master/slave auth with local security.json
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
> Commit: http://git-wip-us.apache.org/repos/asf/lucene-
> solr/commit/95d6fc25
> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/95d6fc25
> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/95d6fc25
> 
> Branch: refs/heads/master
> Commit: 95d6fc2512d6525b2354165553f0d6cc4d0d6310
> Parents: 5eeb813
> Author: Jan HC8ydahl 
> Authored: Fri Feb 24 14:26:48 2017 +0100
> Committer: Jan HC8ydahl 
> Committed: Fri Feb 24 14:30:42 2017 +0100
> 
> --
>  solr/CHANGES.txt|   2 +
>  .../org/apache/solr/core/CoreContainer.java |   9 +-
>  .../solr/security/PKIAuthenticationPlugin.java  |  42 +-
>  .../org/apache/solr/servlet/HttpSolrCall.java   |   4 +-
>  .../apache/solr/servlet/SolrDispatchFilter.java |  11 +-
>  .../solr/security/BasicAuthDistributedTest.java | 136 +++
>  .../security/TestPKIAuthenticationPlugin.java   |  38 +-
>  .../solr/BaseDistributedSearchTestCase.java |  37 -
>  8 files changed, 260 insertions(+), 19 deletions(-)
> --
> 
> 
> http://git-wip-us.apache.org/repos/asf/lucene-
> solr/blob/95d6fc25/solr/CHANGES.txt
> --
> diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
> index 0302615..2c5f0db 100644
> --- a/solr/CHANGES.txt
> +++ b/solr/CHANGES.txt
> @@ -134,6 +134,8 @@ New Features
>field must both be stored=false, indexed=false, docValues=true. (Ishan
> Chattopadhyaya, hossman, noble,
>shalin, yonik)
> 
> +* SOLR-9640: Support PKI authentication and SSL in standalone-mode
> master/slave auth with local security.json (janhoy)
> +
>  Bug Fixes
>  --
> 
> 
> http://git-wip-us.apache.org/repos/asf/lucene-
> solr/blob/95d6fc25/solr/core/src/java/org/apache/solr/core/CoreContainer.
> java
> --
> diff --git a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
> b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
> index e3977d7..6115562 100644
> --- a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
> +++ b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
> @@ -497,7 +497,9 @@ public class CoreContainer {
>  hostName = cfg.getNodeName();
> 
>  zkSys.initZooKeeper(this, solrHome, cfg.getCloudConfig());
> -if(isZooKeeperAware())  pkiAuthenticationPlugin = new
> PKIAuthenticationPlugin(this, zkSys.getZkController().getNodeName());
> +pkiAuthenticationPlugin = isZooKeeperAware() ?
> +new PKIAuthenticationPlugin(this,
> zkSys.getZkController().getNodeName()) :
> +new PKIAuthenticationPlugin(this, getNodeNameLocal());
> 
>  MDCLoggingContext.setNode(this);
> 
> @@ -618,6 +620,11 @@ public class CoreContainer {
>  }
>}
> 
> +  // Builds a node name to be used with PKIAuth.
> +  private String getNodeNameLocal() {
> +return
> getConfig().getCloudConfig().getHost()+":"+getConfig().getCloudConfig().getS
> olrHostPort()+"_solr";
> +  }
> +
>public void securityNodeChanged() {
>  log.info("Security node changed, reloading security.json");
>  reloadSecurityProperties();
> 
> http://git-wip-us.apache.org/repos/asf/lucene-
> solr/blob/95d6fc25/solr/core/src/java/org/apache/solr/security/PKIAuthenti
> cationPlugin.java
> --
> diff --git
> a/solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
> b/solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
> index fdd4408..d185bc9 100644
> ---
> a/solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
> +++
> b/solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
> @@ -22,7 +22,9 @@ import javax.servlet.ServletResponse;
>  import javax.servlet.http.HttpServletRequest;
>  import