[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

[csharptest]

Github user csharptest commented on the issue:

https://github.com/apache/lucenenet/pull/188
  
No problem, glad you like it. Should serve you well as its been in 
production for years now without issue. Do let me know if you need advice on 
usage. 


-- Roger


> On Oct 3, 2016, at 2:03 PM, Shad Storhaug  
wrote:
> 
> Okay, I added the LurchTable to the Support namespace - turned out to be 
pretty straightforward. This one is now ready to pull (I still can't push...).
> 
> Thanks @csharptest for permission to use your creation. And thanks 
@eladmarg for tracking it down.
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

[NightOwl888]

GitHub user NightOwl888 opened a pull request:

https://github.com/apache/lucenenet/pull/190

Ported Analysis.Stempel

All 16 tests are passing.

I ended up porting over `DataInputStream` and `DataOutputStream` and their 
corresponding interfaces from Java to save time. There is probably a way to 
make `Egothor.Stemmer` work with `BinaryReader` and `BinaryReader`, but these 
classes write the bytes in reverse order from Java and also do not have the 
corresponding `WriteUTF` and `ReadUTF` methods that use a proprietary UTF-8 
format. The upside is that it now writes files that are *probably* compatible 
with Java, however since these are temp files I doubt it matters very much.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NightOwl888/lucenenet analysis-stempel

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucenenet/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #190


commit dd8d0a05ee472611900422027935d9696a54ad28
Author: Shad Storhaug 
Date:   2016-10-02T14:37:26Z

Ported Analysis.Stempel + tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---