[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-17 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/madlib/pull/320


---

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-17 Thread d 
Github user d commented on a diff in the pull request:

https://github.com/apache/madlib/pull/320#discussion_r218152329
  
--- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake ---
@@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)
 set(VERSION "4.3ORCA")
 endif()
 elseif(${PORT_UC} STREQUAL "POSTGRESQL" AND
-(${${PORT_UC}_VERSION_MAJOR} EQUAL 10 OR
-${${PORT_UC}_VERSION_PATCH} GREATER 10))
--- End diff --

oops now I understand why the `GREATER` check was there! Yeah go ahead!


---