[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-17 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/madlib/pull/320


---

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-17 Thread d 
Github user d commented on a diff in the pull request:

https://github.com/apache/madlib/pull/320#discussion_r218152329
  
--- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake ---
@@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)
 set(VERSION "4.3ORCA")
 endif()
 elseif(${PORT_UC} STREQUAL "POSTGRESQL" AND
-(${${PORT_UC}_VERSION_MAJOR} EQUAL 10 OR
-${${PORT_UC}_VERSION_PATCH} GREATER 10))
--- End diff --

oops now I understand why the `GREATER` check was there! Yeah go ahead!


---

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-13 Thread iyerr3 
Github user iyerr3 commented on a diff in the pull request:

https://github.com/apache/madlib/pull/320#discussion_r217489096
  
--- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake ---
@@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)
 set(VERSION "4.3ORCA")
 endif()
 elseif(${PORT_UC} STREQUAL "POSTGRESQL" AND
-(${${PORT_UC}_VERSION_MAJOR} EQUAL 10 OR
-${${PORT_UC}_VERSION_PATCH} GREATER 10))
--- End diff --

@d Do you mind if I merge this with the minor change (as described above)?


---

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-12 Thread iyerr3 
Github user iyerr3 commented on a diff in the pull request:

https://github.com/apache/madlib/pull/320#discussion_r217260823
  
--- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake ---
@@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)
 set(VERSION "4.3ORCA")
 endif()
 elseif(${PORT_UC} STREQUAL "POSTGRESQL" AND
-(${${PORT_UC}_VERSION_MAJOR} EQUAL 10 OR
-${${PORT_UC}_VERSION_PATCH} GREATER 10))
--- End diff --

The intention was to check for `...VERSION_MAJOR >= 10`. Hence the two 
checks - there was, however a typo with the second version input as `...PATCH` 
instead of `...MAJOR`. The correction should be to replace the `_PATCH` with 
`_MAJOR`. 


---

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-12 Thread d 
GitHub user d opened a pull request:

https://github.com/apache/madlib/pull/320

Fix false positive for Postgres 10+

We used to mistake 9.3.24 as a higher version than Postgres 10 and stop
matching it to the correct "port". This patch fixes that.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/d/madlib jz-detect-pg10

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/madlib/pull/320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #320


commit bfa929b14b757f1ffc0d6bdf1259f476292eb274
Author: Jesse Zhang 
Date:   2018-09-13T01:53:35Z

Fix false positive for Postgres 10+

We used to mistake 9.3.24 as a higher version than Postgres 10 and stop
matching it to the correct "port". This patch fixes that.




---