[GitHub] maven-scm pull request: Change: Added consumeProcessOutput() to st...
GitHub user ChrisGWarp opened a pull request: https://github.com/apache/maven-scm/pull/32 Change: Added consumeProcessOutput() to stop hang. This is a simple fix to stop the build from hanging when executing svn --version. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChrisGWarp/maven-scm SCM-795 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-scm/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit b1ab76eba177ea64e824dc23bca82303497ccb3e Author: ChrisGWarp chrisgw...@gmail.com Date: 2015-04-04T10:33:44Z Change: Added consume --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Switch to official Guice 4.0
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/45#issuecomment-97413566 To be clear are you saying that the injection of loggers is not supported with Guice 4? I don't think it's used much but I believe it is used. Yes, I have been using the static factory method, or lombok. Maybe this is the impetus to get the perf harness back up and running to check. I'll merge it here locally and try it for a week. On Apr 29, 2015, at 6:03 AM, Stuart McCulloch notificati...@github.com wrote: The only difference remaining between this and sisu-guice is support for @Injection of SLF4J loggers, but I don't believe that's used much, if at all. Personally these days I prefer to create loggers using the static factory method. Performance should be comparable, although I have yet to run a detailed comparison - I'd be interested in feedback from people using large or complicated builds. � Reply to this email directly or view it on GitHub. Thanks, Jason -- Jason van Zyl Founder, Takari and Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - A master in the art of living draws no sharp distinction between his work and his play; his labor and his leisure; his mind and his body; his education and his recreation. He hardly knows which is which. He simply pursues his vision of excellence through whatever he is doing, and leaves others to determine whether he is working or playing. To himself, he always appears to be doing both. -- Fran�ois-Ren� de Chateaubriand --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Switch to official Guice 4.0
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/45#issuecomment-97418800 Thanks for the clarification. I'm not too concerned about not being able to @Inject SLFJ loggers any longer but we can't break components that might be doing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Switch to official Guice 4.0
Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/45#issuecomment-97418554 To be absolutely clear: * injection of SLF4J loggers using `@Inject` is not supported in the official Guice library * injection of SLF4J loggers using `@Requirement` is supported by Sisu's Plexus shim * injection of j.u.l loggers using `@Inject` is supported in the official Guice library Adding support for injection of SLF4J loggers is possible outside of Guice, but it requires you to use a custom annotation rather than `@Inject`: https://github.com/google/guice/wiki/CustomInjections --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Switch to official Guice 4.0
Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/45#issuecomment-97376230 The only difference remaining between this and sisu-guice is support for `@Inject`ion of SLF4J loggers, but I don't believe that's used much, if at all. Personally these days I prefer to create loggers using the static factory method. Performance should be comparable, although I have yet to run a detailed comparison - I'd be interested in feedback from people using large or complicated builds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
SCM: ClearCase tests failing on Windows
Hi All.
I'm getting these (this is one of three) failures when being built on
windows:
ClearCaseEditCommandTest.testCommand:41-ScmTestCase.assertCommandLine:367
expected:...C cleartool co -nc [C:\Documents and
Settings\admin\workspace\maven-scm\maven-scm-providers\maven-scm-provider-clearcase\test.java]
but was:...C cleartool co -nc [C:\Documents and
Settings\admin\workspace\maven-scm\maven-scm-providers\maven-scm-provider-clearcase\test.java]
It is because this test routine:
public class ClearCaseEditCommandTest
extends ScmTestCase
{
public void testCommand()
throws Exception
{
File file = new File( test.java );
ScmFileSet scmFileSet = new ScmFileSet( getWorkingDirectory(), file
);
Commandline commandLine = ClearCaseEditCommand.createCommandLine(
new DefaultLog(), scmFileSet );
assertCommandLine( cleartool co -nc + file.getAbsolutePath(),
getWorkingDirectory(), commandLine );
}
}
does not expect file.getAbsolutePath() to quote the path, whereas the
commandLine.toString() eventually calls:
getCommandLine() - getRawCommandLine() - StringUtils.quoteAndEscape()
The space in the path triggers the quoting in quoteAndEscape() , and so the
test fails.
Now that I understand the mechanics of this, am I the only one seeing this?
What has been done in the past to fix them? I've got enough on with the
jazz provider at the moment, I'd rather not add too it!
Suggestions as to how best to proceed would be greatly appreciated.
-Chris
[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...
GitHub user tssp opened a pull request: https://github.com/apache/maven/pull/46 [MNG-5812] Project base dir not fully working in Cygwin Converted project base dir from Cygwin path to Windows path before executing Maven when running Maven in a Cygwin environment. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tssp/maven MNG-5812 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/46.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #46 commit 65e413f613a1032e790f00ee0fbe29c199a29cfe Author: tssp t...@web.de Date: 2015-04-29T06:02:05Z [MNG-5812] Project base dir not fully working in Cygwin Converted project base dir from Cygwin path to Windows path before executing Maven. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-5816] Empy maven.config cause Maven to ex...
GitHub user tssp opened a pull request: https://github.com/apache/maven/pull/47 [MNG-5816] Empy maven.config cause Maven to exit with failure Avoided adding a non empty configuration argument that causes exception. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tssp/maven MNG-5816 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/47.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #47 commit 70ba4b9bee480fa0af02dc59de30d898afd7c1d3 Author: tssp t...@web.de Date: 2015-04-29T08:22:38Z [MNG-5816] Empy maven.config cause Maven to exit with failure Avoid adding non empty configuration argument that causes exception. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[ANN] Apache Software Foundation Parent POM Version 17 Released
The Apache Maven team is pleased to announce the release of the Apache Software Foundation Parent POM Version 17. http://maven.apache.org/pom/asf/ You should specify the version in your project as parent like the following: parent groupIdorg.apache/groupId artifactIdapache/artifactId version17/version /parent Release Notes - Apache Software Foundation Parent POM - Version 17 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250version=12329009 Bug: * [MPOM-69] - avoid Rat plugin warning Improvement: * [MPOM-47] - Source release assembly can't do tar.gz only * [MPOM-64] - Change maven-source-goal from jar to jar-no-fork * [MPOM-65] - Add maven-war-plugin definition * [MPOM-66] - The ASF global pom should upgrade SUREFIRE@2.18.1 * [MPOM-71] - remove Maven 2.x support in ASF parent * [MPOM-74] - Upgrade maven compiler source/target to 1.5 * [MPOM-75] - Upgrade maven-resources-plugin to 2.7 * [MPOM-76] - Upgrade maven-source-plugin to 2.4 * [MPOM-77] - Upgrade maven-compiler-plugin to 3.2 Changes since version 16: http://svn.apache.org/viewvc/maven/pom/tags/apache-17/pom.xml?r1=HEADr2=1639452diff_format=h Enjoy, -The Apache Maven team - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Do we want to go for gitpubsub?
http://bit.ly/1QLwWGS (Source: https://twitter.com/planetapache/status/593535338074611712) Sent from my iPad - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
