[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696991#comment-14696991
]
Stephen Connolly commented on MPIR-234:
---
It should not be displayed, or inferred from any other (ie sub module)
location.
If you are looking at a module's site and you have to go changing it, you want
to know how to check out *that module*.
So there should be a Source Repository for sub-modules.
So let's take a concrete example: Surefire
http://maven.apache.org/surefire/source-repository.html
I have no major complaints with the above page:
This has sub-module within the same GIT repo... let's pick one of them:
http://maven.apache.org/surefire/surefire-api/source-repository.html
What I want is that the fact that this is a sub-component of the main
repository should be called out more explicitly, e.g.
{code}
$ git clone https://git-wip-us.apache.org/repos/asf/maven-surefire.git
$ cd maven-surefire/surefire-api
{code}
would be better checkout instructions.
NIT: those checkout instructions do not checkout the branch that the report was
generated from... so better yet would be
{code}
$ git clone -b surefire-2.18.1_vote-1
https://git-wip-us.apache.org/repos/asf/maven-surefire.git
$ cd maven-surefire/surefire-api
{code}
On the other hand, it is really annoying with SVN to always be having the URL
in the report as that of the tag... really great would be to give the links for
the branch the release was cut from as well as the links to the tag
So you'd have
{code}
The source can be checked out anonymously from GIT. To checkout the source code
that for this release use the following command:
$ git clone -b surefire-2.18.1_vote-1
https://git-wip-us.apache.org/repos/asf/maven-surefire.git
$ cd maven-surefire/surefire-api
Alternatively if you want to check out the development stream you can use the
following command:
$ git clone https://git-wip-us.apache.org/repos/asf/maven-surefire.git
$ cd maven-surefire/surefire-api
{code}
Now that page also brings up an additional topic... namely the Web Access
section.
The Web Access section currently assumes that you will navigate the repo
exactly like the file system... this is not entirely an unreasonable
assumption... but it need not remain true, for example there are some web
browsers that use a query parameter for the repo path... so the path needs to
be encoded appropriately.
To me it would make more sense to have the Web Access link generated by a
plugable strategy and injected into the report using a role-hint...
so if I inject the {{webAccessgithub/webAccess}} into the report... well
that assumes that GIT urls are for GitHub / GitHub enterprise and can compute
the web access url from the git url... much less for the user to configure and
therefore much less to go wrong.
If the role is not injected, we could ask all providers to sniff check... so a
github.com URL would be auto-sniffed by the github implementation and bonus the
user didn't have to configure anything... an implementation of {{none}} would
suppress the link entirely for those people who feel the need to hide.
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail:
Jetspeed 2.3
Hi Team, Got source code for Jetspeed 2.3 and built it. We tried deploying jetspeed2.3.war file. Then we are facing error as org.apache.ojb.broker.accesslayer.JdbcAccessImpl] ERROR: SQLException during the execution of the query (for org.apache.jetspeed.capabilities.impl.ClientImpl): ORA-00942: table or view does not exist ORA-00942: table or view does not exist java.sql.SQLSyntaxErrorException: ORA-00942: table or view does not exist at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:450) at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:399) at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:1059) at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:522) at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:257) at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:587) at oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:225) at oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:53) at oracle.jdbc.driver.T4CPreparedStatement.executeForDescribe(T4CPreparedStatement.java:774) at oracle.jdbc.driver.OracleStatement.executeMaybeDescribe(OracleStatement.java:925) at oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:) at oracle.jdbc.driver.OraclePreparedStatement.executeInternal(OraclePreparedStatement.java:4798) at oracle.jdbc.driver.OraclePreparedStatement.executeQuery(OraclePreparedStatement.java:4845) at oracle.jdbc.driver.OraclePreparedStatementWrapper.executeQuery(OraclePreparedStatementWrapper.java:1501) at weblogic.jdbc.wrapper.PreparedStatement.executeQuery(PreparedStatement.java:141) at org.apache.ojb.broker.accesslayer.JdbcAccessImpl.executeQuery(JdbcAccessImpl.java:312) at org.apache.ojb.broker.accesslayer.RsQueryObject.performQuery(RsQueryObject.java:74) at org.apache.ojb.broker.accesslayer.RsIterator.init(RsIterator.java:185) at org.apache.ojb.broker.core.RsIteratorFactoryImpl.createRsIterator(RsIteratorFactoryImpl.java:58) at org.apache.ojb.broker.core.PersistenceBrokerImpl.getRsIteratorFromQuery(PersistenceBrokerImpl.java:1918) at org.apache.ojb.broker.core.PersistenceBrokerImpl.getIteratorFromQuery(PersistenceBrokerImpl.java:1493) at org.apache.ojb.broker.core.QueryReferenceBroker.getCollectionByQuery(QueryReferenceBroker.java:112) at org.apache.ojb.broker.core.QueryReferenceBroker.getCollectionByQuery(QueryReferenceBroker.java:251) at org.apache.ojb.broker.core.QueryReferenceBroker.getCollectionByQuery(QueryReferenceBroker.java:271) at org.apache.ojb.broker.core.PersistenceBrokerImpl.getCollectionByQuery(PersistenceBrokerImpl.java:1367) at org.apache.ojb.broker.core.DelegatingPersistenceBroker.getCollectionByQuery(DelegatingPersistenceBroker.java:338) at org.apache.ojb.broker.core.DelegatingPersistenceBroker.getCollectionByQuery(DelegatingPersistenceBroker.java:338) at org.springframework.orm.ojb.PersistenceBrokerTemplate$3.doInPersistenceBroker(PersistenceBrokerTemplate.java:192) at org.springframework.orm.ojb.PersistenceBrokerTemplate.execute(PersistenceBrokerTemplate.java:138) at org.springframework.orm.ojb.PersistenceBrokerTemplate.executeFind(PersistenceBrokerTemplate.java:159) at org.springframework.orm.ojb.PersistenceBrokerTemplate.getCollectionByQuery(PersistenceBrokerTemplate.java:190) at org.apache.jetspeed.capabilities.impl.JetspeedCapabilities.getClients(JetspeedCapabilities.java:392) at org.apache.jetspeed.capabilities.impl.JetspeedCapabilities.findClient(JetspeedCapabilities.java:327) at org.apache.jetspeed.capabilities.impl.JetspeedCapabilities.getCapabilityMap(JetspeedCapabilities.java:196) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:96) at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:260) at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:94) at
Re: Jetspeed 2.3
Moving the developers list to BCC... To invoke Maven as you discovered, you run: mvn lifecycle-phase Or: mvn plugin-goal The second error is because you are trying to invoke a plugin goal directly but Maven cannot locate the plugin based on your name. The way to invoke plugin goals is: mvn plugin-groupId:plugin-artifactId[:plugin-version]:plugin-goal If the plugin has a register short name, then you can use the short name in place of the groupId:artifactId portion of the plugin goal specification. The third error is due to you specifying an unrecognized build lifecycle phase. You can find a list of the Jetspeed plugins at: http://mvnrepository.com/artifact/org.apache.portals.jetspeed-2 Robert Patrick robert.patr...@oracle.com VP, Development, Oracle Corporation Mobile: +1.469.556.9450 Sent from my iDevice On Aug 14, 2015, at 7:11 AM, Lalitha Bourishetty lalitha.bourishe...@oracle.com wrote: Hi Team, Got source code for Jetspeed 2.3 and built it. We tried deploying jetspeed2.3.war file. Then we are facing error as org.apache.ojb.broker.accesslayer.JdbcAccessImpl] ERROR: SQLException during the execution of the query (for org.apache.jetspeed.capabilities.impl.ClientImpl): ORA-00942: table or view does not exist ORA-00942: table or view does not exist java.sql.SQLSyntaxErrorException: ORA-00942: table or view does not exist at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:450) at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:399) at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:1059) at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:522) at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:257) at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:587) at oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:225) at oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:53) at oracle.jdbc.driver.T4CPreparedStatement.executeForDescribe(T4CPreparedStatement.java:774) at oracle.jdbc.driver.OracleStatement.executeMaybeDescribe(OracleStatement.java:925) at oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:) at oracle.jdbc.driver.OraclePreparedStatement.executeInternal(OraclePreparedStatement.java:4798) at oracle.jdbc.driver.OraclePreparedStatement.executeQuery(OraclePreparedStatement.java:4845) at oracle.jdbc.driver.OraclePreparedStatementWrapper.executeQuery(OraclePreparedStatementWrapper.java:1501) at weblogic.jdbc.wrapper.PreparedStatement.executeQuery(PreparedStatement.java:141) at org.apache.ojb.broker.accesslayer.JdbcAccessImpl.executeQuery(JdbcAccessImpl.java:312) at org.apache.ojb.broker.accesslayer.RsQueryObject.performQuery(RsQueryObject.java:74) at org.apache.ojb.broker.accesslayer.RsIterator.init(RsIterator.java:185) at org.apache.ojb.broker.core.RsIteratorFactoryImpl.createRsIterator(RsIteratorFactoryImpl.java:58) at org.apache.ojb.broker.core.PersistenceBrokerImpl.getRsIteratorFromQuery(PersistenceBrokerImpl.java:1918) at org.apache.ojb.broker.core.PersistenceBrokerImpl.getIteratorFromQuery(PersistenceBrokerImpl.java:1493) at org.apache.ojb.broker.core.QueryReferenceBroker.getCollectionByQuery(QueryReferenceBroker.java:112) at org.apache.ojb.broker.core.QueryReferenceBroker.getCollectionByQuery(QueryReferenceBroker.java:251) at org.apache.ojb.broker.core.QueryReferenceBroker.getCollectionByQuery(QueryReferenceBroker.java:271) at org.apache.ojb.broker.core.PersistenceBrokerImpl.getCollectionByQuery(PersistenceBrokerImpl.java:1367) at org.apache.ojb.broker.core.DelegatingPersistenceBroker.getCollectionByQuery(DelegatingPersistenceBroker.java:338) at org.apache.ojb.broker.core.DelegatingPersistenceBroker.getCollectionByQuery(DelegatingPersistenceBroker.java:338) at org.springframework.orm.ojb.PersistenceBrokerTemplate$3.doInPersistenceBroker(PersistenceBrokerTemplate.java:192) at org.springframework.orm.ojb.PersistenceBrokerTemplate.execute(PersistenceBrokerTemplate.java:138) at org.springframework.orm.ojb.PersistenceBrokerTemplate.executeFind(PersistenceBrokerTemplate.java:159) at org.springframework.orm.ojb.PersistenceBrokerTemplate.getCollectionByQuery(PersistenceBrokerTemplate.java:190) at org.apache.jetspeed.capabilities.impl.JetspeedCapabilities.getClients(JetspeedCapabilities.java:392) at org.apache.jetspeed.capabilities.impl.JetspeedCapabilities.findClient(JetspeedCapabilities.java:327) at org.apache.jetspeed.capabilities.impl.JetspeedCapabilities.getCapabilityMap(JetspeedCapabilities.java:196) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697645#comment-14697645
]
Robert Scholte commented on MPIR-234:
-
I really wonder if we should call it a URL. IMHO it is a connection String, the
scmSpecific part is not unified.
We should question: what does the scm section contain and where is it used for?
Git is an example where in doesn't only contain the location, but it can also
contain fetch+push information. So here it also contains the release strategy.
Let's assume that we want to construct the connection, because for some SCMs it
makes more sense to add it somewhere in the middle (e.g. the connection uses an
additional arguments like
[h2|http://www.h2database.com/html/features.html#database_url])
We would need to use as extensions, which I don't like for Maven core.
So what do we gain by inheriting + expanding it for modules: reports are much
better in creating proper instructions. I still think it has introduced too
much complexity for the effective pom for modules which doesn't add true value.
{quote}
So the question becomes what do we put on the Source Repository page for a
module without an explicit scm section.
We don't. Either N/A or See Root SCM URL.
{quote}
I'd say: leave it up to the SCM implementation, they know the best answer. IIRC
with SoftwareAG the SCM and IDE are that much integrated with each other that
it doesn't make sense to try to access it on filesystem.
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697360#comment-14697360
]
Hervé Boutemy edited comment on MPIR-234 at 8/14/15 4:53 PM:
-
bq. NIT: those checkout instructions do not checkout the branch that the report
was generated from
I already did that in MPIR-291, available in MPIR 2.8
the only mising part is that, in MPIR-290, I don't display {{cd
maven-surefire/surefire-api}}
was (Author: hboutemy):
bq. NIT: those checkout instructions do not checkout the branch that the report
was generated from
if already did that in MPIR-291, available in MPIR 2.8
the only mising part is that, in MPIR-290, I don't display {{cd
maven-surefire/surefire-api}}
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697360#comment-14697360
]
Hervé Boutemy commented on MPIR-234:
bq. NIT: those checkout instructions do not checkout the branch that the report
was generated from
if already did that in MPIR-291, available in MPIR 2.8
the only mising part is that, in MPIR-290, I don't display {{cd
maven-surefire/surefire-api}}
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697836#comment-14697836
]
Hervé Boutemy commented on MPIR-234:
yes SCM urls can be really complex
core needs to remain simple and let MPIR (or other tools) interpret the scm
value to dispatch every information to proper usable info
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697908#comment-14697908
]
Benson Margulies commented on MPIR-234:
---
I am going to put in a fruitless reminder that it would be a lot cleaner to add
more elements under scm/ than to keep making the URL longer and longer.
Everyone says, 'oh, we can't do that, we might bust some crappily-written tool
that reads POMs.' I think we should just rev the POM schema to allow for
arbitrary 'foreign namespace' elements, and use namespace for this kind of
extension, and the tools that are still using 15-year-old XML parsing
technology can go ahead and croak.
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698032#comment-14698032
]
Chris Graham commented on MPIR-234:
---
+1
Making the URL's longer just increases the complexity of the existing parsing
code (which in some cases, is already complex enough).
Add more elements.
And if your going to do that, I'd say that it's time to start looking at SCM
API 2.0 and making it MORE abstracted (not less).
It's not all about Git...
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698029#comment-14698029
]
Chris Graham commented on MPIR-234:
---
It should not be displayed, or inferred from any other (ie sub module)
location.
If you are looking at a module's site and you have to go changing it, you want
to know how to check out bthat module/b.
Perhaps I was not clear, or you missed by point.
Which is: In some SCM's checking out a sub module, it is impossible. It's an
all or nothing operation, not a cherry picking one.
So there should be a Source Repository for sub-modules.
No there should not. Or, at best, it is only meaningful for those SCM's that
can support it.
All you are doing in your example is cloning the bentire repo/b [you cann't
not] and then checking out (-b) the branch. How is this a sub module?
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698029#comment-14698029
]
Chris Graham edited comment on MPIR-234 at 8/15/15 2:16 AM:
It should not be displayed, or inferred from any other (ie sub module)
location.
If you are looking at a module's site and you have to go changing it, you want
to know how to check out bthat module/b.
Perhaps I was not clear, or you missed my point.
Which is: In some SCM's checking out a sub module, it is impossible. It's an
all or nothing operation, not a cherry picking one.
So there should be a Source Repository for sub-modules.
No there should not. Or, at best, it is only meaningful for those SCM's that
can support it.
All you are doing in your example is cloning the bentire repo/b [you cann't
not] and then checking out (-b) the branch. How is this a sub module?
was (Author: chrisgwarp):
It should not be displayed, or inferred from any other (ie sub module)
location.
If you are looking at a module's site and you have to go changing it, you want
to know how to check out bthat module/b.
Perhaps I was not clear, or you missed by point.
Which is: In some SCM's checking out a sub module, it is impossible. It's an
all or nothing operation, not a cherry picking one.
So there should be a Source Repository for sub-modules.
No there should not. Or, at best, it is only meaningful for those SCM's that
can support it.
All you are doing in your example is cloning the bentire repo/b [you cann't
not] and then checking out (-b) the branch. How is this a sub module?
SCM-link in site of multimodule projects should not append module name by
default (at least for git)
Key: MPIR-234
URL: https://issues.apache.org/jira/browse/MPIR-234
Project: Maven Project Info Reports Plugin
Issue Type: Bug
Components: scm
Affects Versions: 2.4
Reporter: Mirko Friedenhagen
I have setup a simple multi module project (see
https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by
default add the name of the module to the SCM-URLs in source-repository.html.
So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
https://github.com/mfriedenhagen/multi-module-sample/core/,
g...@github.com:mfriedenhagen/multi-module-sample.git/core and
git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
the core module. All these URLs are invalid. For SVN this could be assumed to
be the right behaviour, for git and probably other SCMs this is not true. As
a workaround I have to reconfigure the scm section (see
https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
{code:xml}
scm
connection${project.parent.scm.connection}/connection
developerConnection${project.parent.scm.developerConnection}/developerConnection
url${project.parent.scm.url}/url
/scm
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
