[GitHub] maven-indexer issue #15: MINDEXER-101 Forward port OSGI improvements to mast...

[carlspring]

Github user carlspring commented on the issue:

https://github.com/apache/maven-indexer/pull/15
  
@sesuncedu,

One thing to mention though -- (nothing critical, just cosmetic) -- you 
don't seem to be following convention, which is making the checkstyle plugin 
complain.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-indexer issue #13: MINDEXER-97: Index/Store Extra OSGI Headers

[sesuncedu]

Github user sesuncedu commented on the issue:

https://github.com/apache/maven-indexer/pull/13
  
@cstamas Squashbasing gives the cleanest trees. Just make sure to give 
yourself credit for the commits of yours that were cherry-picked. 

index-reader should be identical for both branches. There's only a single 
package, and  I bumped the OSGI package version to 5.2.0, since the additional 
public static fields are a minor API change over 5.1.2 .  Since nexus is using 
karaf features / pax-aether-url , this isn't as necessary or helpful or as it 
might be, but it does mean that the feature assembly can safely refer to the 
6.0 index-reader snapshot, since the osgi package version is explicitly 
backwards compatible. 

I actually ended up doing a third version of the changes as kludges on top 
of the nexus-public maven repository plugin. The main annoyance with 
index-reader was having to subclass  Expander / Compactor to handle the 
additional fields,  where a default mapping would have been simple.  

  Since I needed to build some mapping tables anyway to stash the relevant 
manifest headers in an asset child map where they wouldn't get in the way, 
doing Expander/Compactor wasn't that much of an extra hassle, but if the 
index-reader is used to build federations, it is useful to be able to have 
unrecognized fields be passed through as strings (e.g. if jigsaw is released, 
exchanging headers from module-info.class (and now possibly the manifest?) will 
be useful for federated systems).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: All go for 3.5.0

[Michael Osipov]

Am 2017-04-01 um 15:02 schrieb Stephen Connolly:

I think all issues remaining are addressed.

If anyone wants to take some final manual testing of core, please do so as
my plan is to shoot direct for 3.5.0 rather than spinning RCs... this means
if there's a blocker then it will be on to 3.5.1


I have constant failures on the mng5753CustomMojoExecutionConfigurator 
IT on several Oses. Tibor has the issue too. I wrote about it couple of 
days ago.


Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

All go for 3.5.0

[Stephen Connolly]

I think all issues remaining are addressed.

If anyone wants to take some final manual testing of core, please do so as
my plan is to shoot direct for 3.5.0 rather than spinning RCs... this means
if there's a blocker then it will be on to 3.5.1
-- 
Sent from my phone

Prepare Maven Archetype Plugin 3.0.1

[Robert Scholte]

Hi,

I've done some regression fixes for the Maven Archetype Plugin and want to  
do a release within a week.
Would be nice if these fixes could be confirmed to prevent more negative  
reactions.


thanks,
Robert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Perms for https://github.com/apache/maven-indexer

[Hervé BOUTEMY]

and I don't like to have a commit just to tell GitHub issue tracker to do 
something

would it work in a branch, that we can delete after?
that would be much better

Regards,

Hervé

Le samedi 1 avril 2017, 12:09:03 CEST Robert Scholte a écrit :
> There are some magic keywords for closing issues via the commit comment[1]
> However, nothing to close as "Won't fix" or to cleanup from our side.
> 
> Robert
> 
> [1] https://help.github.com/articles/closing-issues-via-commit-messages/
> 
> 
> On Sat, 01 Apr 2017 12:05:50 +0200, Hervé BOUTEMY 
> 
> wrote:
> > Hi,
> > 
> > AFAIK, github mirror is read-only for everybody
> > 
> > see https://reference.apache.org/pmc/github : it does not tell what is
> > not
> > possible, but what is expected
> > 
> > Regards,
> > 
> > Hervé
> > 
> > Le vendredi 31 mars 2017, 21:02:55 CEST Tamás Cservenák a écrit :
> >> Howdy,
> >> 
> >> it seems I have no powers to manage MI mirror at
> >> https://github.com/apache/maven-indexer
> >> 
> >> Could someone help here, or this is infra issue?
> >> 
> >> 
> >> Thanks,
> >> ~t~
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Perms for https://github.com/apache/maven-indexer

[Robert Scholte]

There are some magic keywords for closing issues via the commit comment[1]
However, nothing to close as "Won't fix" or to cleanup from our side.

Robert

[1] https://help.github.com/articles/closing-issues-via-commit-messages/


On Sat, 01 Apr 2017 12:05:50 +0200, Hervé BOUTEMY   
wrote:



Hi,

AFAIK, github mirror is read-only for everybody

see https://reference.apache.org/pmc/github : it does not tell what is  
not

possible, but what is expected

Regards,

Hervé

Le vendredi 31 mars 2017, 21:02:55 CEST Tamás Cservenák a écrit :

Howdy,

it seems I have no powers to manage MI mirror at
https://github.com/apache/maven-indexer

Could someone help here, or this is infra issue?


Thanks,
~t~




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Perms for https://github.com/apache/maven-indexer

[Hervé BOUTEMY]

Hi,

AFAIK, github mirror is read-only for everybody

see https://reference.apache.org/pmc/github : it does not tell what is not 
possible, but what is expected

Regards,

Hervé

Le vendredi 31 mars 2017, 21:02:55 CEST Tamás Cservenák a écrit :
> Howdy,
> 
> it seems I have no powers to manage MI mirror at
> https://github.com/apache/maven-indexer
> 
> Could someone help here, or this is infra issue?
> 
> 
> Thanks,
> ~t~



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org