[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...
Github user etzelc commented on the issue:
https://github.com/apache/maven/pull/128
I will have a closer look next week, right now only tested with Windows
(since only cmd script was modified). In the {{mvn}} script the string of the
{{echo}} is already completely in double quotes, but I will have a look.
I have already an IT with three tests (for space, bracket and ampersand),
but found out that maven has problems with ampersands in folder names. Probably
I will remove that special case. See
https://github.com/etzelc/maven-integration-testing/tree/MNG-6256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...
Github user Tunaki commented on the issue:
https://github.com/apache/maven/pull/128
Shouldn't there be the same fix for `mvn`, and not just `mvn.cmd`?
[`${basedir}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L150)
and
[`${arg}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L154)
are not escaped as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Invoker Plugin version 3.0.1 / Apache Maven Script Interpreter 1.2
Hi Sounds to be a legitimate complain :-). My goal was to have something to be sure running after tests wether were failing or not. (my use case stop a running Jetty instance). But doesn't work for this case. Ok I cancel the vote and will fix that! Thanks! Olivier On 15 July 2017 at 20:59, Guillaume Boué wrote: > Hi, > > I have a question about the post-build invocation change in MINVOKER-223. > With 3.0.0, the post-build script is executed only once, after all Maven > invocations (defined for example with invoker.goals.1, invoker.goals.2, > etc.) are performed successfully. Now, with the fix made in MINVOKER-223, > the post-build script is executed after each Maven invocation, whether it > resulted in a success or a failure. As a consequence, the post-build script > will be ran multiple times, after each successful build, instead of after > all successful builds. > > The fact that the post-build script is executed in case of some invocation > failure is OK. But I wonder if the behavioral change concerning successful > builds was also intended. It is contrary to the pre-build script, which is > ran only once, before all invocations. I think the post-build script should > be executed after either a failed build, or all successful builds. > > An example of ITs which rely on the previous behavior are > "dependencySource-2" and "dependencySource-4" of maven-javadoc-plugin: they > pass with 3.0.0, but fail with staged 3.0.1. > > Guillaume > > > > Le 13/07/2017 à 08:43, Olivier Lamy a écrit : > >> Hi, >> I'd like to release Apache Maven Invoker Plugin version 3.0.1 and Apache >> Maven Script Interpreter 1.2. >> >> We fixed 2 issues for Script interpreter: >> https://s.apache.org/MSCRIPT-INTERPRETER-JIRA-1.2 >> We fixed 4 issues for Invoker plugin: >> https://s.apache.org/MINVOKER-JIRA-3.0.1 >> >> Staging repo: https://repository.apache.org/ >> content/repositories/maven-1345/ >> Source releases: >> * >> https://repository.apache.org/content/repositories/maven-134 >> 5/org/apache/maven/plugins/maven-invoker-plugin/3.0.1/maven- >> invoker-plugin-3.0.1-source-release.zip >> * >> https://repository.apache.org/content/repositories/maven-134 >> 5/org/apache/maven/shared/maven-script-interpreter/1.2/maven >> -script-interpreter-1.2-source-release.zip >> >> Staging sites: >> http://maven.apache.org/components/plugins-archives/maven- >> invoker-plugin-LATEST/ >> http://maven.apache.org/components/shared-archives/maven- >> script-interpreter-LATEST/ >> >> Guide to testing staged releases: >> https://maven.apache.org/guides/development/guide-testing-releases.html >> >> Vote open for at least 72 hours. >> >> [ ] +1 >> [ ] +0 >> [ ] -1 >> >> My +1 >> >> Cheers >> > > > --- > L'absence de virus dans ce courrier électronique a été vérifiée par le > logiciel antivirus Avast. > https://www.avast.com/antivirus > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven Invoker Plugin version 3.0.1 / Apache Maven Script Interpreter 1.2
Hi, I have a question about the post-build invocation change in MINVOKER-223. With 3.0.0, the post-build script is executed only once, after all Maven invocations (defined for example with invoker.goals.1, invoker.goals.2, etc.) are performed successfully. Now, with the fix made in MINVOKER-223, the post-build script is executed after each Maven invocation, whether it resulted in a success or a failure. As a consequence, the post-build script will be ran multiple times, after each successful build, instead of after all successful builds. The fact that the post-build script is executed in case of some invocation failure is OK. But I wonder if the behavioral change concerning successful builds was also intended. It is contrary to the pre-build script, which is ran only once, before all invocations. I think the post-build script should be executed after either a failed build, or all successful builds. An example of ITs which rely on the previous behavior are "dependencySource-2" and "dependencySource-4" of maven-javadoc-plugin: they pass with 3.0.0, but fail with staged 3.0.1. Guillaume Le 13/07/2017 à 08:43, Olivier Lamy a écrit : Hi, I'd like to release Apache Maven Invoker Plugin version 3.0.1 and Apache Maven Script Interpreter 1.2. We fixed 2 issues for Script interpreter: https://s.apache.org/MSCRIPT-INTERPRETER-JIRA-1.2 We fixed 4 issues for Invoker plugin: https://s.apache.org/MINVOKER-JIRA-3.0.1 Staging repo: https://repository.apache.org/content/repositories/maven-1345/ Source releases: * https://repository.apache.org/content/repositories/maven-1345/org/apache/maven/plugins/maven-invoker-plugin/3.0.1/maven-invoker-plugin-3.0.1-source-release.zip * https://repository.apache.org/content/repositories/maven-1345/org/apache/maven/shared/maven-script-interpreter/1.2/maven-script-interpreter-1.2-source-release.zip Staging sites: http://maven.apache.org/components/plugins-archives/maven-invoker-plugin-LATEST/ http://maven.apache.org/components/shared-archives/maven-script-interpreter-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 My +1 Cheers --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
