Re: Adding a new method getPID() in MavenSession

2017-07-16 Thread Robert Scholte

Hi Tibor,

assuming you're talking about  
http://repo1.maven.org/maven2/net/java/dev/jna/jna/4.4.0/jna-4.4.0.jar
AFAIK there's no blacklist of bad packages, only a whitelist of packages  
per jar of exported packages as described in its module descriptor. So as  
long as the com.sun.jna package doesn't collide with any other package,  
there should be no issue. But I agree that with J9 it is a poor chosen  
package name, maybe they decide to rename it after all.


Robert

On Sun, 16 Jul 2017 17:51:08 +0200, Tibor Digana  
 wrote:



@Robert
Do you know if JNA using com.sun packages was re-packaged due to Jigsaw?
I think Jigsaw will not load com.sun packages.

On Sun, Jul 16, 2017 at 5:12 PM, Tibor Digana  


wrote:


Hi all,

I want to ask for your opinion about adding *getPID *method in
MavenSession.

With Michael Osipov we talked about ensuring PID observed from Maven
process.
We need to read PID of Maven process within Surefire plugin. We have
several alternatives however only Java 9 introduced standard API  
providing

the PID.

For me it would be fine to get the PID from MavenSession rather than
discovering it in an individual Maven plugin since it is Maven's
information and all plugins may read it too.

For Java < 9 the JNA call can read PID. We found sources at Hudson which
may help us https://github.com/hudson3-plugins/jna-native-support-plugin

As a standard Java way we can call Java 9 Jigsaw code:
long pid = ProcessHandle.current().pid();

Linux standard way is to read the link on file system
String pid = new File("/proc/self").getCanonicalFile().getName()

Non-standard simplistic way
String pid =  
ManagementFactory.getRuntimeMXBean().getName().split("@")[0]


Bad fact on JMX is the startup cca 50 - 80 milliseconds.

--
Cheers
Tibor






-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire pull request #159: SUREFIRE-1391: Eliminate redundant call in...

2017-07-16 Thread andrew-j-cohen
GitHub user andrew-j-cohen opened a pull request:

https://github.com/apache/maven-surefire/pull/159

SUREFIRE-1391: Eliminate redundant call in calculation of effective 
properties

Eliminate redundant call to copy systemPropertyVariables in the calculation 
of effective properties

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrew-j-cohen/maven-surefire master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-surefire/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #159


commit d2fa7859eed0742b2d6db9b356b29c9e3cf5c04b
Author: Andrew Cohen 
Date:   2017-07-16T15:48:31Z

SUREFIRE-1391: Eliminate redundant call to process systemPropertyVariables 
in the calculation of effective properties

Signed-off-by: Andrew Cohen 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Adding a new method getPID() in MavenSession

2017-07-16 Thread Tibor Digana
@Robert
Do you know if JNA using com.sun packages was re-packaged due to Jigsaw?
I think Jigsaw will not load com.sun packages.

On Sun, Jul 16, 2017 at 5:12 PM, Tibor Digana 
wrote:

> Hi all,
>
> I want to ask for your opinion about adding *getPID *method in
> MavenSession.
>
> With Michael Osipov we talked about ensuring PID observed from Maven
> process.
> We need to read PID of Maven process within Surefire plugin. We have
> several alternatives however only Java 9 introduced standard API providing
> the PID.
>
> For me it would be fine to get the PID from MavenSession rather than
> discovering it in an individual Maven plugin since it is Maven's
> information and all plugins may read it too.
>
> For Java < 9 the JNA call can read PID. We found sources at Hudson which
> may help us https://github.com/hudson3-plugins/jna-native-support-plugin
>
> As a standard Java way we can call Java 9 Jigsaw code:
> long pid = ProcessHandle.current().pid();
>
> Linux standard way is to read the link on file system
> String pid = new File("/proc/self").getCanonicalFile().getName()
>
> Non-standard simplistic way
> String pid = ManagementFactory.getRuntimeMXBean().getName().split("@")[0]
>
> Bad fact on JMX is the startup cca 50 - 80 milliseconds.
>
> --
> Cheers
> Tibor
>



-- 
Cheers
Tibor


Adding a new method getPID() in MavenSession

2017-07-16 Thread Tibor Digana
Hi all,

I want to ask for your opinion about adding *getPID *method in MavenSession.

With Michael Osipov we talked about ensuring PID observed from Maven
process.
We need to read PID of Maven process within Surefire plugin. We have
several alternatives however only Java 9 introduced standard API providing
the PID.

For me it would be fine to get the PID from MavenSession rather than
discovering it in an individual Maven plugin since it is Maven's
information and all plugins may read it too.

For Java < 9 the JNA call can read PID. We found sources at Hudson which
may help us https://github.com/hudson3-plugins/jna-native-support-plugin

As a standard Java way we can call Java 9 Jigsaw code:
long pid = ProcessHandle.current().pid();

Linux standard way is to read the link on file system
String pid = new File("/proc/self").getCanonicalFile().getName()

Non-standard simplistic way
String pid = ManagementFactory.getRuntimeMXBean().getName().split("@")[0]

Bad fact on JMX is the startup cca 50 - 80 milliseconds.

-- 
Cheers
Tibor


Re: MNG-6258 and MNG-5457 for 3.5.1

2017-07-16 Thread Hervé BOUTEMY
too late, but big +1 :)

Regards,

Hervé

Le mercredi 12 juillet 2017, 21:20:01 CEST Michael Osipov a écrit :
> Who seconds
> 
> [MNG-6258] Upgrade to Maven Resolver 1.1.0
> [MNG-5457] Show repository id when downloading or uploading from/to a
> remote repository
> 
> for 3.5.1? Both IT runs pass. MNG-5457 requires MNG-6258.
> 
> Michael
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-enforcer pull request #27: Fixed wrong page title for Dependency Conve...

2017-07-16 Thread arend-von-reinersdorff
GitHub user arend-von-reinersdorff opened a pull request:

https://github.com/apache/maven-enforcer/pull/27

Fixed wrong page title for Dependency Convergence

Check page title here:
http://maven.apache.org/enforcer/enforcer-rules/dependencyConvergence.html

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arend-von-reinersdorff/maven-enforcer patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-enforcer/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 20284954e9d21f1fa4c86fa01e190fb98cc0d799
Author: Arend v. Reinersdorff 
Date:   2017-07-16T10:12:55Z

Fixed wrong page title for Dependency Convergence




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org