[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...

2017-09-12 Thread mpkorstanje 
Github user mpkorstanje commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/150#discussion_r138477890
  
--- Diff: 
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/MatchMethodDescriptions.java
 ---
@@ -0,0 +1,74 @@
+package org.apache.maven.surefire.common.junit48;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.junit.runner.Description;
+import org.junit.runner.manipulation.Filter;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Only run test methods in the given failure set
+ *
+ * @author mpkorstanje
+ */
+final class MatchMethodDescriptions
+extends Filter
+{
+
+private final List filters = new ArrayList();
+
+MatchMethodDescriptions( Iterable descriptions )
+{
+for ( Description description : descriptions )
+{
+filters.add( matchMethodDescription ( description ) );
+}
+}
+
+@Override
+public boolean shouldRun( Description description )
+{
+for ( Filter filter : filters )
+{
+if ( filter.shouldRun( description ) )
+{
+return true;
+}
+}
+return false;
+}
+
+@Override
+public String describe()
+{
+StringBuilder description = new StringBuilder( "Matching 
description " );
+for ( int i = 0; i < filters.size(); i++ )
+{
+description.append( filters.get( i ).describe() );
+if ( i != filters.size() - 1 )
+{
+description.append( " OR " );
+}
+}
+return description.toString();
+}
+}
--- End diff --

Done.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...

2017-09-12 Thread mpkorstanje 
Github user mpkorstanje commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/150#discussion_r138472979
  
--- Diff: 
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/FailingMethodFilter.java
 ---
@@ -1,85 +0,0 @@
-package org.apache.maven.surefire.common.junit48;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import org.apache.maven.shared.utils.io.SelectorUtils;
-import org.junit.runner.Description;
-import org.junit.runner.manipulation.Filter;
-
-import java.util.Map;
-import java.util.Set;
-
-/**
- * Only run test methods in the given input map, indexed by test class
- */
-final class FailingMethodFilter
--- End diff --

This is not really possible as as the way we're dealing selecting the tests 
to rerun has changed fundamentally. I have however added 
`JUnit4ProviderUtilTest#testGenerateFailingTestDescriptions` to show 
equivalence to `JUnit4ProviderUtilTest#testGenerateFailingTests`

This shows that the set of failed tests is the same as before - though 
described in a different format.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-12 Thread Stephen Connolly 
Have we got any feedback from the embedder integrations yet?

On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY  wrote:

> just for the records: it is Windows + Git Bash (MINGW64) only
>
> and there is a chance that adding -Djansi.force=true can force JAnsi
> activation (even if JAnsi fails to detect that it should auto-activate)
>
> details on issue in https://issues.apache.org/jira/browse/MNG-6282 , and a
> future JAnsi issue...
>
> Regards,
>
> Hervé
>
> Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a écrit :
> > So that is windows only, or were they lost on other OSes for you.
> >
> > I have colours on linux (via docker) and os-x
> >
> > On 11 September 2017 at 12:35, dejan2...@gmail.com 
> >
> > wrote:
> > > +1 (conditionally).
> > >
> > > Tested via project that includes dozen of plugins: 1st tier, MojoHaus
> and
> > > few 3rd party plugins (so to say).
> > >
> > > Everything looks good with one notable regression:
> > > https://issues.apache.org/jira/browse/MNG-6282 Console output has no
> > > colors (regression in Maven 3.5.1)
> > >
> > > Regards,
> > > Dejan
> > >
> > > On 2017-09-10 17:39, Stephen Connolly  >
> > >
> > > wrote:
> > > > Hi,
> > > >
> > > > We solved 25 issues:
> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >
> > > version=12338964=Text=12316922
> > >
> > > > There are 350 issues left in JIRA for Maven core:
> > > > https://issues.apache.org/jira/issues/?jql=project%20%
> > >
> > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > >
> > > > Staging repo:
> > > > https://repository.apache.org/content/repositories/maven-1364/
> > > >
> > > > The distributable binaries and sources can be found here:
> > > > https://repository.apache.org/content/repositories/maven-> >
> > > 1364/org/apache/maven/apache-maven/3.5.1/
> > >
> > > > Specifically the zip, tarball and source archives can be found here:
> > > > https://repository.apache.org/content/repositories/maven-> >
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
> > >
> > > > https://repository.apache.org/content/repositories/maven-> >
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz
> > >
> > > > https://repository.apache.org/content/repositories/maven-> >
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
> > >
> > > > https://repository.apache.org/content/repositories/maven-> >
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz
> > >
> > > > Source release checksum(s):
> > > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
> > >
> > > bd2059560d
> > >
> > > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
> > >
> > > 69e698eb0e
> > >
> > > > Git tag:
> > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > >
> > > 094e4e31a5af55bb17be87675da41d9aeca062f3
> > >
> > > > Staging site:
> > > > https://maven.apache.org/components/ref/3-LATEST/
> > > >
> > > > Vote open for 72 hours.
> > > >
> > > > [ ] +1
> > > > [ ] +0
> > > > [ ] -1
> > > >
> > > > Thanks,
> > > >
> > > > Stephen.
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone

Re: [VOTE] Release Apache Maven Dependency Plugin version 3.0.2

2017-09-12 Thread Tibor Digana 
+1: tested in my company project

On Sat, Sep 9, 2017 at 2:34 PM, Karl Heinz Marbaise 
wrote:

> Hi,
>
> We solved 7 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> ctId=12317227=12341254
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> 20MDEP%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
> 20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1360
> https://repository.apache.org/content/repositories/maven-136
> 0/org/apache/maven/plugins/maven-dependency-plugin/3.0.2/mav
> en-dependency-plugin-3.0.2-source-release.zip
>
> Source release checksum(s):
> maven-dependency-plugin-3.0.2-source-release.zip sha1:
> 3c4aa716e28b241834d47d22e1ff5f6e62f16b9b
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Cheers
Tibor

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-09-12 Thread Tibor17 
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/150
  
@mpkorstanje 
Currently we are cutting two versions. This week `2.20.1` and 
`2.21.0.Jigsaw` next week having support with Jigsaw of Java 9.
This PR is planned in `2.20.2` but the version will be renamed to `2.21.1` 
in Jira having 3 fixes which should be fast release, and then `2.20.2` with one 
but big fix which removes 2 blockers. After this the plugins should be stable, 
I hope, and we can cut `3.0.0.M1` and we will break backwards compatibility in 
parameters and their properties.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...

2017-09-12 Thread britter 
Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/141
  
@Tibor17 I'm not working on the 3.0 branch any more. It's up to you. I 
think the 3.0 branch should have version 3.0.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Dependency Plugin version 3.0.2

2017-09-12 Thread Anders Hammar 
+1

Tested with Maven 3.3.9 and IBM JDK 7.1 on Windows 7.

/Anders

On Sat, Sep 9, 2017 at 2:34 PM, Karl Heinz Marbaise 
wrote:

> Hi,
>
> We solved 7 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> ctId=12317227=12341254
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> 20MDEP%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
> 20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1360
> https://repository.apache.org/content/repositories/maven-136
> 0/org/apache/maven/plugins/maven-dependency-plugin/3.0.2/mav
> en-dependency-plugin-3.0.2-source-release.zip
>
> Source release checksum(s):
> maven-dependency-plugin-3.0.2-source-release.zip sha1:
> 3c4aa716e28b241834d47d22e1ff5f6e62f16b9b
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

2017-09-12 Thread Tibor Digana 
Hi Dan,
Yes you can use such version. The URL for snapshots is
https://repository.apache.org/content/repositories/snapshots

On Tue, Sep 12, 2017 at 5:01 AM, Dan Tran  wrote:

> Is there a snapshot i can test with my production? only see 2.21-SNAPSHOT
>
> Thanks
>
> -Dan
>
> On Mon, Sep 11, 2017 at 5:05 AM, Enrico Olivelli 
> wrote:
>
> > +1 (non binding)
> >
> > run unit tests on surefire project itself
> >
> > on  JDK 9+181 run unit tests of other Java8 projects which required
> > java.se.ee module to be present
> >
> > Thank you !
> >
> > Enrico
> >
> >
> > 2017-09-11 5:33 GMT+02:00 Tibor Digana :
> >
> > > Hi,
> > >
> > > We solved 24 issues:
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > projectId=12317927=12340297
> > >
> > > There are 101 issues left in JIRA:
> > > https://issues.apache.org/jira/i#issues/?jql=project+%
> > > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1366/
> > > https://repository.apache.org/content/repositories/maven-
> > > 1366/org/apache/maven/surefire/surefire/2.20.1/surefire-2.20.1-source-
> > > release.zip
> > >
> > > Source release checksum(s):
> > > maven-surefire-plugin-2.20.1-site-source.zip sha1:
> > > 4187a7932268c7ad467973254d87584085e305c1
> > >
> > > Staging site:
> > > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >
> > > Guide to testing staged releases:
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > --
> > > Cheers
> > > Tibor
> > >
> >
>



-- 
Cheers
Tibor

[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...

2017-09-12 Thread KroArtem 
Github user KroArtem commented on the issue:

https://github.com/apache/maven-surefire/pull/141
  
Well, 3.0 also becomes highly appreciated as JUnit 5 was officially 
released recently.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org