Maven-enforcer-plugin's use of aether-util in transitive dependency

2019-03-13 Thread Tomo Suzuki
Hi Maven developers,
(following "Contributing" section of maven-enforcer-plugin
)

I'm thinking to raise a PR to fix an issue below, so that
maven-enforcer-plugin can work with maven-resolver-util without explicit
"exclusion" element. Let me know what you think!

While writing a custom enforcer rule, I encountered NoSuchMethodError
org.eclipse.aether.util.ConfigUtils.getFloat. I believe it is caused by
transitive dependency in org.eclipse.aether:aether-util. The class is also
in org.apache.maven.resolver:maven-resolver-util:1.3.1. A workaround with
exclusion element

just worked fine for me but I'd like to contribute to fix the root cause if
possible.

-- 
Regards,
Tomo


Re: [VOTE] Release Apache Maven Resolver version 1.3.3

2019-03-13 Thread Robert Scholte

+1

On Wed, 13 Mar 2019 11:23:55 +0100, Karl Heinz Marbaise  
 wrote:



Hi,

here is my +1

Kind regards
Karl Heinz Marbaise
On 10.03.19 22:20, Karl Heinz Marbaise wrote:

Hi,
 We solved 2 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12345144=Text  
   
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC  
  Staging repo:

https://repository.apache.org/content/repositories/maven-1491
https://repository.apache.org/content/repositories/maven-1491/org/apache/maven/resolver/maven-resolver/1.3.3/maven-resolver-1.3.3-source-release.zip  
  Source release checksum(s):
 maven-resolver-1.3.3-source-release.zip sha1:  
add6e75be1e9a9867608511bce6bd47caf92afb6
maven-resolver-1.3.3-source-release.zip sha512:  
d87a5257edf0feef813bd48d14c1bce3f64efbbed8d05df1e38d3cc9ca195f73932ac06751465c329bd1f22708d9743d9f34811ebe720266e090ca586ff8a3d3  
  Staging site:

https://maven.apache.org/resolver-archives/resolver-LATEST/
 Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html
 Vote open for at least 72 hours.
 [ ] +1
[ ] +0
[ ] -1
  Kind regards
Karl Heinz Marbaise
 -
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




Mit freundlichem Gruß
Karl-Heinz Marbaise


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Surefire maintenance release

2019-03-13 Thread Enrico Olivelli
Very good!

Enrico

Il mer 13 mar 2019, 16:09 Stephane Nicoll  ha
scritto:

> Hey,
>
> I've created a `2.22.x` branch based on the 2.22.1 tag and I've
> cherry-picked the issue we need to get proper support for the vintage
> engine[1]
>
> This 2.22.2-SNAPSHOT works for our purpose so I was wondering if more fixes
> could be backported and/or if someone would like to review those changes.
>
> Thanks,
> S.
>
>
> [1] https://github.com/snicoll/maven-surefire/tree/2.22.x
>
> On Wed, Feb 27, 2019 at 1:46 PM Tibor Digana 
> wrote:
>
> > Hi  Stephane,
> >
> > We are talking only about these two commits [1]?
> > Notice that 001e807 modifies file names to the verbose one which breaks
> > backwards compatibility and this should not forcibly (by default) happen
> in
> > your version/branch.
> > Try to fork the project, make a local branch and then reset HEAD to [2],
> > i.e. git reset --hard 19006aa70f36705f399b8c105a16f636904f00f3
> > And then cherrypick both commits [1].
> > Make sure the order is correct but it won't be so straightforward. The
> > tests have to pass (mvn install -P run-its).
> >
> > [1]:
> >
> >
> https://github.com/apache/maven-surefire/commit/f517d349ede0e15229e3c48f45d10dabc72a3fc9
> >
> >
> https://github.com/apache/maven-surefire/commit/001e8075b8db7861aaefb5af4c256d919a9b2e7a
> >
> > [2]:
> >
> >
> https://github.com/apache/maven-surefire/commit/19006aa70f36705f399b8c105a16f636904f00f3
> >
> > Cheers
> > Tibor
> >
> > On Mon, Feb 25, 2019 at 8:54 AM Stephane Nicoll <
> stephane.nic...@gmail.com
> > >
> > wrote:
> >
> > > Hi everyone,
> > >
> > > It's great to see the progress on Surefire 3.0 and I wanted to reach
> out
> > to
> > > discuss a practicable problem with the 2.x line. There are a number of
> > > fixes for JUnit 5 that are only available in the 3.x line that isn't GA
> > > yet. [1][2]
> > >
> > > Putting my Spring Boot hat for a min, this actually prevents us from
> > > upgrading our test support to JUnit 5: our plan is to offer maximum
> > > flexibility by providing the vintage engine (so that users can keep
> their
> > > tests and migrate at their own pace).
> > >
> > > We can't upgrade to a milestone as our upgrade policy prevents that
> > > (regardless of how stable this is and especially since backward
> > > incompatible changes have been pushed to the latest milestone). So
> we're
> > > kind of stuck.
> > >
> > > Would there be an appetite to backport those fixes and release a
> 2.22.2?
> > >
> > > Thanks,
> > > S.
> > >
> > > [1] https://issues.apache.org/jira/browse/SUREFIRE-1614
> > > [2]
> > https://issues.apache.org/jira/projects/SUREFIRE/issues/SUREFIRE-1546
> > >
> >
>


Re: Surefire maintenance release

2019-03-13 Thread Stephane Nicoll
Hey,

I've created a `2.22.x` branch based on the 2.22.1 tag and I've
cherry-picked the issue we need to get proper support for the vintage
engine[1]

This 2.22.2-SNAPSHOT works for our purpose so I was wondering if more fixes
could be backported and/or if someone would like to review those changes.

Thanks,
S.


[1] https://github.com/snicoll/maven-surefire/tree/2.22.x

On Wed, Feb 27, 2019 at 1:46 PM Tibor Digana  wrote:

> Hi  Stephane,
>
> We are talking only about these two commits [1]?
> Notice that 001e807 modifies file names to the verbose one which breaks
> backwards compatibility and this should not forcibly (by default) happen in
> your version/branch.
> Try to fork the project, make a local branch and then reset HEAD to [2],
> i.e. git reset --hard 19006aa70f36705f399b8c105a16f636904f00f3
> And then cherrypick both commits [1].
> Make sure the order is correct but it won't be so straightforward. The
> tests have to pass (mvn install -P run-its).
>
> [1]:
>
> https://github.com/apache/maven-surefire/commit/f517d349ede0e15229e3c48f45d10dabc72a3fc9
>
> https://github.com/apache/maven-surefire/commit/001e8075b8db7861aaefb5af4c256d919a9b2e7a
>
> [2]:
>
> https://github.com/apache/maven-surefire/commit/19006aa70f36705f399b8c105a16f636904f00f3
>
> Cheers
> Tibor
>
> On Mon, Feb 25, 2019 at 8:54 AM Stephane Nicoll  >
> wrote:
>
> > Hi everyone,
> >
> > It's great to see the progress on Surefire 3.0 and I wanted to reach out
> to
> > discuss a practicable problem with the 2.x line. There are a number of
> > fixes for JUnit 5 that are only available in the 3.x line that isn't GA
> > yet. [1][2]
> >
> > Putting my Spring Boot hat for a min, this actually prevents us from
> > upgrading our test support to JUnit 5: our plan is to offer maximum
> > flexibility by providing the vintage engine (so that users can keep their
> > tests and migrate at their own pace).
> >
> > We can't upgrade to a milestone as our upgrade policy prevents that
> > (regardless of how stable this is and especially since backward
> > incompatible changes have been pushed to the latest milestone). So we're
> > kind of stuck.
> >
> > Would there be an appetite to backport those fixes and release a 2.22.2?
> >
> > Thanks,
> > S.
> >
> > [1] https://issues.apache.org/jira/browse/SUREFIRE-1614
> > [2]
> https://issues.apache.org/jira/projects/SUREFIRE/issues/SUREFIRE-1546
> >
>


Re: [VOTE] Release Apache Maven Resolver version 1.3.3

2019-03-13 Thread Karl Heinz Marbaise

Hi,

here is my +1

Kind regards
Karl Heinz Marbaise
On 10.03.19 22:20, Karl Heinz Marbaise wrote:

Hi,

We solved 2 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12345144=Text 



https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC 



Staging repo:
https://repository.apache.org/content/repositories/maven-1491
https://repository.apache.org/content/repositories/maven-1491/org/apache/maven/resolver/maven-resolver/1.3.3/maven-resolver-1.3.3-source-release.zip 



Source release checksum(s):

maven-resolver-1.3.3-source-release.zip sha1: 
add6e75be1e9a9867608511bce6bd47caf92afb6
maven-resolver-1.3.3-source-release.zip sha512: 
d87a5257edf0feef813bd48d14c1bce3f64efbbed8d05df1e38d3cc9ca195f73932ac06751465c329bd1f22708d9743d9f34811ebe720266e090ca586ff8a3d3 



Staging site:
https://maven.apache.org/resolver-archives/resolver-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1


Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





Mit freundlichem Gruß
Karl-Heinz Marbaise
--
SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893
Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579
Hauptstrasse 177
52146 Würselen   http://www.soebes.de

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org