Re: [VOTE] Release Apache Maven Version 3.6.1

2019-04-05 Thread Eric Lilja
+1 (non-binding), tested with Java 8 on Windows 10 and Linux, both 
personal projects and at work


- Eric L

On 2019-04-04 21:55, Karl Heinz Marbaise wrote:

Hi,

We have solved 42 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12338966 



There are issues left in JIRA for Maven core:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC 



Staging repo:
https://repository.apache.org/content/repositories/maven-1496

The distributable binaries and sources can be found here:
https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/ 



Specifically the zip, tarball and source archives can be found here:

https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-bin.zip 

https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-bin.tar.gz 



https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-src.zip 

https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-src.tar.gz 



The release artifacts are staged for distribution in:
https://dist.apache.org/repos/dist/dev/maven/maven-3/3.6.0

Source release checksum(s):
apache-maven-3.6.1-src.tar.gz

  sha1: 4e87c962ed505a0158085f99d92a0ade8c7fd197
sha512:
11a31022cffa0518584703fffd9fce998332ac5f6c2a50db3b590e90f3bdd1508d9e0cb5ba89a699ef6536b237bcc96166cfde3d45bce6346fa21b05b4d12bf8 



apache-maven-3.6.1-src.zip:

  sha1: ec0618f981f9367f133a29fbfcaa8e073cb8ac85
sha512:
b92d8ed72585c4e05debe4d15eb9ae5dd72e814b6413bcba78d01282c9eccc38e79755654e0d0b4e5a650f0226c116a4a4faad731918a465ad424a2a81582a67 



Git tag:
https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555 



Staging site:
https://maven.apache.org/components/ref/3-LATEST/

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Read-only parameter can be set

2019-04-05 Thread Sylwester Lachiewicz
Hi,
I think I found a place where you can add the verification of read-only
Mojo parameters, see [1]

For few tests looks it works correctly, we have one ITs failing [2].
Could you help with more testing? The code can be found in MNG-5001 branch
and compiled version - ready for download from our CI [3]

Sylwester


[ERROR] Failed to execute goal
org.apache.maven.its.plugins:maven-it-plugin-artifact:2.1-SNAPSHOT:install
(install) on project dependency: The parameters 'pomFile' for goal
org.apache.maven.its.plugins:maven-it-plugin-artifact:2.1-SNAPSHOT:install
are missing, read-only or invalid -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal
org.apache.maven.its.plugins:maven-it-plugin-artifact:2.1-SNAPSHOT:install
(install) on project dependency: The parameters 'pomFile' for goal
org.apache.maven.its.plugins:maven-it-plugin-artifact:2.1-SNAPSHOT:install
are missing, read-only or invalid


[1] https://github.com/apache/maven/pull/240
[2]
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-5001/
[3]
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-5001/lastSuccessfulBuild/artifact/org/apache/maven/apache-maven/3.6.2-SNAPSHOT/

pt., 5 kwi 2019 o 09:06 Stephane Nicoll 
napisał(a):

> Thank you very much for confirming Hervé. It would be nice if we had a way
> to identify that the value was set and then take an appropriate action in a
> custom plugin forthe time being.
>
> Has anybody done that to workaround the issue maybe?
>
> On Fri, Apr 5, 2019 at 8:21 AM Hervé BOUTEMY 
> wrote:
>
> > sadly nothing: this is a known limitation in Maven 3 (that did not exist
> > in
> > Maven 2)
> > https://issues.apache.org/jira/browse/MNG-5001
> >
> > I never had time to dig precisely into source code to see how hard the
> fix
> > would be. What I know is that when the fix will be available, we'll
> > probably
> > need a grace period with warnings for people setting such read-only
> > parameters
> > before really breaking such abnormal builds
> >
> > Regards,
> >
> > Hervé
> >
> > Le jeudi 4 avril 2019, 13:22:17 CEST Stephane Nicoll a écrit :
> > > Hey,
> > >
> > > I have a weird case trying to deprecate a "finalName" property where
> said
> > > property can still be set by the user.
> > >
> > > Here is the definition:
> > >
> > > /**
> > >  * Name of the generated archive.
> > >  * @since 1.0
> > >  */
> > > @Parameter(defaultValue = "${project.build.finalName}", readonly =
> true)
> > > private String finalName;
> > >
> > > That property can be set when configuring the plugin and its value is
> > > injected.
> > >
> > > What am I missing?
> > >
> > > Thanks,
> > > S.
> >
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>


Re: How to list config parameter names in MOJO used by a plugin in POM?

2019-04-05 Thread Robert Scholte

@Parameter( defaultValue = "${mojoExecution}", readonly = true )
private MojoExecution mojo;

private void verifyRemovedParameter( String paramName )
{
Xpp3Dom configDom = mojo.getConfiguration();
if ( configDom != null )
{
if ( configDom.getChild( paramName ) != null )
{
throw new IllegalArgumentException( "parameter '" +  
paramName
+ "' has been removed from the plugin, please verify  
documentation." );

}
}
}

private void verifyReplacedParameter( String oldParamName, String  
newParamNew )

{
Xpp3Dom configDom = mojo.getConfiguration();
if ( configDom != null )
{
if ( configDom.getChild( oldParamName ) != null )
{
throw new IllegalArgumentException( "parameter '" +  
oldParamName
+ "' has been replaced with " + newParamNew + ",  
please verify documentation." );

}
}
}

On Fri, 05 Apr 2019 17:37:41 +0200, Tibor Digana   
wrote:



I want to observe a list of config parameters (names) in MOJO plugin
without injecting @Param for each.

If the customer still uses old parameter, the MOJO wouldn't know it.
Therefore I want to read the list of paramaters. And if he stil uses the
old name, the plugin would fail with a hint saying how to fix this  
problem.


Is this possible in MOJO?

Thx
Tibor


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



How to list config parameter names in MOJO used by a plugin in POM?

2019-04-05 Thread Tibor Digana
I want to observe a list of config parameters (names) in MOJO plugin
without injecting @Param for each.

If the customer still uses old parameter, the MOJO wouldn't know it.
Therefore I want to read the list of paramaters. And if he stil uses the
old name, the plugin would fail with a hint saying how to fix this problem.

Is this possible in MOJO?

Thx
Tibor


Re: [VOTE] Release Maven Resolver Ant Tasks version 1.2.0

2019-04-05 Thread Michael Osipov

Am 2019-04-05 um 11:39 schrieb Robert Scholte:
Just wondering why this is not 1.1.2, updating versions and a bugfix 
don't reflect the 1.2.0 to me.


It contains a huge bump in the Resolver version. I thought this would 
justify this bump too.


Michael

On Mon, 01 Apr 2019 22:49:21 +0200, Michael Osipov  
wrote:



Hi,

We solved 11 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12345231 



There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22ant%20tasks%22%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC 



Staging repo:
https://repository.apache.org/content/repositories/maven-1495/
https://repository.apache.org/content/repositories/maven-1495/org/apache/maven/resolver/maven-resolver-ant-tasks/1.2.0/maven-resolver-ant-tasks-1.2.0-source-release.zip 



Source release checksum(s):
maven-resolver-ant-tasks-1.2.0-source-release.zip
sha512: 
46f58229848118fc8a3664f9ac41a1356d9f2b0e50f7259e3bd13dce030422d0dd8040300872cf598f862fcdd6a6fce7f1064ad62dcae656b030d5404be80568 



Staging site:
https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Maven Resolver Ant Tasks version 1.2.0

2019-04-05 Thread Robert Scholte
Just wondering why this is not 1.1.2, updating versions and a bugfix don't  
reflect the 1.2.0 to me.


+1

Robert

On Mon, 01 Apr 2019 22:49:21 +0200, Michael Osipov   
wrote:



Hi,

We solved 11 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12345231

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22ant%20tasks%22%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1495/
https://repository.apache.org/content/repositories/maven-1495/org/apache/maven/resolver/maven-resolver-ant-tasks/1.2.0/maven-resolver-ant-tasks-1.2.0-source-release.zip

Source release checksum(s):
maven-resolver-ant-tasks-1.2.0-source-release.zip
sha512:  
46f58229848118fc8a3664f9ac41a1356d9f2b0e50f7259e3bd13dce030422d0dd8040300872cf598f862fcdd6a6fce7f1064ad62dcae656b030d5404be80568


Staging site:
https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Maven Resolver Ant Tasks version 1.2.0

2019-04-05 Thread Michael Osipov

Am 2019-04-01 um 22:49 schrieb Michael Osipov:

Hi,

We solved 11 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12345231 



There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22ant%20tasks%22%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC 



Staging repo:
https://repository.apache.org/content/repositories/maven-1495/
https://repository.apache.org/content/repositories/maven-1495/org/apache/maven/resolver/maven-resolver-ant-tasks/1.2.0/maven-resolver-ant-tasks-1.2.0-source-release.zip 



Source release checksum(s):
maven-resolver-ant-tasks-1.2.0-source-release.zip
sha512: 
46f58229848118fc8a3664f9ac41a1356d9f2b0e50f7259e3bd13dce030422d0dd8040300872cf598f862fcdd6a6fce7f1064ad62dcae656b030d5404be80568 



Staging site:
https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.


One more PMC vote, folks!

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Read-only parameter can be set

2019-04-05 Thread Stephane Nicoll
Thank you very much for confirming Hervé. It would be nice if we had a way
to identify that the value was set and then take an appropriate action in a
custom plugin forthe time being.

Has anybody done that to workaround the issue maybe?

On Fri, Apr 5, 2019 at 8:21 AM Hervé BOUTEMY  wrote:

> sadly nothing: this is a known limitation in Maven 3 (that did not exist
> in
> Maven 2)
> https://issues.apache.org/jira/browse/MNG-5001
>
> I never had time to dig precisely into source code to see how hard the fix
> would be. What I know is that when the fix will be available, we'll
> probably
> need a grace period with warnings for people setting such read-only
> parameters
> before really breaking such abnormal builds
>
> Regards,
>
> Hervé
>
> Le jeudi 4 avril 2019, 13:22:17 CEST Stephane Nicoll a écrit :
> > Hey,
> >
> > I have a weird case trying to deprecate a "finalName" property where said
> > property can still be set by the user.
> >
> > Here is the definition:
> >
> > /**
> >  * Name of the generated archive.
> >  * @since 1.0
> >  */
> > @Parameter(defaultValue = "${project.build.finalName}", readonly = true)
> > private String finalName;
> >
> > That property can be set when configuring the plugin and its value is
> > injected.
> >
> > What am I missing?
> >
> > Thanks,
> > S.
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [VOTE] Release Apache Maven Version 3.6.1

2019-04-05 Thread Enrico Olivelli
+1 (non binding)
built from source with jdk8
used in some big and complex project with JDK-11 + linux

Enrico

Il giorno ven 5 apr 2019 alle ore 07:36 Francois Papon
 ha scritto:
>
> +1 (non-binding)
>
> Thanks!
>
> regards,
>
> François Papon
> fpa...@apache.org
>
> Le 04/04/2019 à 23:55, Karl Heinz Marbaise a écrit :
> > Hi,
> >
> > We have solved 42 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12338966
> >
> >
> > There are issues left in JIRA for Maven core:
> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC
> >
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1496
> >
> > The distributable binaries and sources can be found here:
> > https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/
> >
> >
> > Specifically the zip, tarball and source archives can be found here:
> >
> > https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-bin.zip
> >
> > https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-bin.tar.gz
> >
> >
> > https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-src.zip
> >
> > https://repository.apache.org/content/repositories/maven-1496/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-src.tar.gz
> >
> >
> > The release artifacts are staged for distribution in:
> > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.6.0
> >
> > Source release checksum(s):
> > apache-maven-3.6.1-src.tar.gz
> >
> >   sha1: 4e87c962ed505a0158085f99d92a0ade8c7fd197
> > sha512:
> > 11a31022cffa0518584703fffd9fce998332ac5f6c2a50db3b590e90f3bdd1508d9e0cb5ba89a699ef6536b237bcc96166cfde3d45bce6346fa21b05b4d12bf8
> >
> >
> > apache-maven-3.6.1-src.zip:
> >
> >   sha1: ec0618f981f9367f133a29fbfcaa8e073cb8ac85
> > sha512:
> > b92d8ed72585c4e05debe4d15eb9ae5dd72e814b6413bcba78d01282c9eccc38e79755654e0d0b4e5a650f0226c116a4a4faad731918a465ad424a2a81582a67
> >
> >
> > Git tag:
> > https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555
> >
> >
> > Staging site:
> > https://maven.apache.org/components/ref/3-LATEST/
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Kind regards
> > Karl Heinz Marbaise
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Read-only parameter can be set

2019-04-05 Thread Hervé BOUTEMY
sadly nothing: this is a known limitation in Maven 3 (that did not exist in 
Maven 2)
https://issues.apache.org/jira/browse/MNG-5001

I never had time to dig precisely into source code to see how hard the fix 
would be. What I know is that when the fix will be available, we'll probably 
need a grace period with warnings for people setting such read-only parameters 
before really breaking such abnormal builds

Regards,

Hervé

Le jeudi 4 avril 2019, 13:22:17 CEST Stephane Nicoll a écrit :
> Hey,
> 
> I have a weird case trying to deprecate a "finalName" property where said
> property can still be set by the user.
> 
> Here is the definition:
> 
> /**
>  * Name of the generated archive.
>  * @since 1.0
>  */
> @Parameter(defaultValue = "${project.build.finalName}", readonly = true)
> private String finalName;
> 
> That property can be set when configuring the plugin and its value is
> injected.
> 
> What am I missing?
> 
> Thanks,
> S.





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org