Fixing LICENCE and NOTICE for binary distributions
Hello, as Vladimir reported in [1] we have problems of our binary distributions. Short version of the story: - we are missing some entries in LICENSE, in my opinion we should cite every other ASLv2 licenced project that is not of property of ASF (like Plexus), but we are currently skipping them - we are not handling correctly some hidden (shaded/relocated) dependencies - some of our direct dependencies of Maven Core messed with their LICENSE, so the data that we can download automatically (from Maven central) is not consistent with other sources (websites for instance) Please follow up on JIRA for the detailed discussion about every single dependency. I have also started a branch for the fixes, but it is only a playground for me currently as we should decide how the LICENSE/NOTICE/.license files should look like before actually doing this. I have experience of this kind of discussions in Apache BookKeeper project and we came out with this doc [3] and a Pull request validation script that validates as much as possible those rules. I am tyring to understand our dependencies and our packaging of licensing material, in order to come with a complete proposal. Any thought or suggestion is very welcome ! Enrico [1] https://issues.apache.org/jira/browse/MNG-6771 [2] https://github.com/apache/maven/pull/297 [3] http://bookkeeper.apache.org/community/licensing/
Re: Dynamic phases proposal
On Sat 26 Oct 2019 at 10:50, Robert Scholte wrote: > To avoid confusion, let's call it stages. > > Stage 1: Always call post-bound executions (MNG-5665[1]) > Stage 2: before and after > Stage 3: priorities (MNG-3522[2]) > Stage 4: transitional lifecycle I have a prototype of stages 1-3 nearly (80%) done... just have to polish up and validate the bound executions with some tests > > For both all you need to start evaluating the value of phase. > For now we can assume that after:clean is just another label for > post-clean and will have exactly the same effect. > MNG-5665 contains a proposal to change the xml, but we shouldn't do that > (yet). Let's start with a hardcoded list of postphases (or in case a goal > fails, see if a post-x phase exists). Stage 1 is to make it work, stage 2 > to make it configurable. > IIRC you cannot ask from inside a Mojo if is was called explicitly or > because it was bound to a phase, nor can you ask for the value of this > phase. I kind of like this, plugins shouldn't care about this. > However, inside Maven it will become important at which phase it is to > know if there are more executions to call OR create blocks of executions. > Now it is just a list of executions: loop and fail fast. > > thanks, > Robert > > [1] https://issues.apache.org/jira/browse/MNG-5665 > [2] https://issues.apache.org/jira/browse/MNG-3522 > On 25-10-2019 21:33:14, Stephen Connolly > wrote: > Robert, > > I would be fine splitting out into, pardon the pun, phases: > > Phase 1: before and after > Phase 2: priorities > Phase 3: transitional lifecycle > > Might have a phase 1.5 of before:* and after:* to catch the start of a > lifecycle and the end of a lifecycle... > > On Fri 25 Oct 2019 at 20:30, Stephen Connolly < > stephen.alan.conno...@gmail.com [mailto:stephen.alan.conno...@gmail.com]> > wrote: > > Robert, Michael, Tibor, let’s continue here (though I asked Infra and it’s > fine that anyone in the community can join our Slack) > > On Fri 25 Oct 2019 at 20:01, Stephen Connolly < > stephen.alan.conno...@gmail.com [mailto:stephen.alan.conno...@gmail.com]> > wrote: > > https://cwiki.apache.org/confluence/display/MAVEN/Dynamic+phases [ > https://cwiki.apache.org/confluence/display/MAVEN/Dynamic+phases] > > Thoughts? > -- > > Sent from my phone > -- > > Sent from my phone > -- > > Sent from my phone -- Sent from my phone
Re: Dynamic phases proposal
To avoid confusion, let's call it stages. Stage 1: Always call post-bound executions (MNG-5665[1]) Stage 2: before and after Stage 3: priorities (MNG-3522[2]) Stage 4: transitional lifecycle For both all you need to start evaluating the value of phase. For now we can assume that after:clean is just another label for post-clean and will have exactly the same effect. MNG-5665 contains a proposal to change the xml, but we shouldn't do that (yet). Let's start with a hardcoded list of postphases (or in case a goal fails, see if a post-x phase exists). Stage 1 is to make it work, stage 2 to make it configurable. IIRC you cannot ask from inside a Mojo if is was called explicitly or because it was bound to a phase, nor can you ask for the value of this phase. I kind of like this, plugins shouldn't care about this. However, inside Maven it will become important at which phase it is to know if there are more executions to call OR create blocks of executions. Now it is just a list of executions: loop and fail fast. thanks, Robert [1] https://issues.apache.org/jira/browse/MNG-5665 [2] https://issues.apache.org/jira/browse/MNG-3522 On 25-10-2019 21:33:14, Stephen Connolly wrote: Robert, I would be fine splitting out into, pardon the pun, phases: Phase 1: before and after Phase 2: priorities Phase 3: transitional lifecycle Might have a phase 1.5 of before:* and after:* to catch the start of a lifecycle and the end of a lifecycle... On Fri 25 Oct 2019 at 20:30, Stephen Connolly mailto:stephen.alan.conno...@gmail.com]> wrote: Robert, Michael, Tibor, let’s continue here (though I asked Infra and it’s fine that anyone in the community can join our Slack) On Fri 25 Oct 2019 at 20:01, Stephen Connolly mailto:stephen.alan.conno...@gmail.com]> wrote: https://cwiki.apache.org/confluence/display/MAVEN/Dynamic+phases [https://cwiki.apache.org/confluence/display/MAVEN/Dynamic+phases] Thoughts? -- Sent from my phone -- Sent from my phone -- Sent from my phone
