Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2
+1 On Sat, 7 Mar 2020 at 21:56, Karl Heinz Marbaise wrote: > We solved 23 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227=12343772 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDEP%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1555 > > > https://repository.apache.org/content/repositories/maven-1555/org/apache/maven/plugins/maven-dependency-plugin/3.1.2/maven-dependency-plugin-3.1.2-source-release.zip > > Source release checksum(s): > [NAME-OF]-source-release.zip sha512: > > e06c1696842682e599c2b7e6a24c58ac0c01ae0d5bf57fcc7269a7fd11092143c598fa82f908ee181d905cb949f44515e14b7b899e5df1aa184d68d2d308f83f > > Staging site: > https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Kind regards > Karl Heinz Marbaise > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [DISCUSS] checking reproducible builds
clearly, save goal is not a good choice: buildinfo would be better
I know buildinfo is not a usual term, but it's widely used in Reproducible
Builds [1] & [2], then it would be nice us Maven not to reinvent a wheel that
has already been invented
on separating checking, I really don't see how this improves experience
I love this idea of maven-artifact-plugin, but I don't see which goals od
maven-dependency-plugin could go in:
https://maven.apache.org/plugins/maven-dependency-plugin/
Regards,
Hervé
[1] https://reproducible-builds.org/docs/jvm/
[2] https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles
Le dimanche 8 mars 2020, 21:04:56 CET Robert Scholte a écrit :
> I'm thinking of maven-artifact-plugin, having goals related to artifacts.
> That implies that the save goal should be renamed.
> A couple of goals of the maven-dependency-plugin are actually more
> artifact-related are might be worth moving.
>
> Robert
>
> On 8-3-2020 13:44:07, Michael Osipov wrote:
>
> Am 2020-03-08 um 12:48 schrieb Hervé BOUTEMY:
> > Le dimanche 8 mars 2020, 00:31:07 CET Michael Osipov a écrit :
> >> Am 2020-03-07 um 19:04 schrieb Hervé BOUTEMY:
> >>> Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit :
> This is expected because I am on 1.8.0_242. I don't have Java 7
> installed anymore on the server.
> >>>
> >>> for the discussion I wanted us to have, just being able to test and see
> >>> how we detect issues, this is perfect, isn't it?
> >>
> >> This is really nice. Here is the diffoscope output:
> > you're discovering the wonders of diffoscope :)
> >
> >>> --- maven-site-plugin-3.9.0.jar
> >>> +++ reference/maven-site-plugin-3.9.0.jar
> >>> ├── zipinfo {}
> >>> │ @@ -1,8 +1,8 @@
> >
> > [...]
> >
> >>> META-INF/MANIFEST.MF
> >>> │ @@ -1,10 +1,10 @@
> >>> │ Manifest-Version: 1.0
> >>> │ +Implementation-Vendor: The Apache Software Foundation^M
> >>> │ Implementation-Title: Apache Maven Site Plugin
> >>> │ Implementation-Version: 3.9.0
> >>> │ +Build-Jdk-Spec: 1.7^M
> >>> │ Specification-Vendor: The Apache Software Foundation
> >>> │ -Specification-Title: Apache Maven Site Plugin^M
> >>> │ -Build-Jdk-Spec: 1.8^M
> >>> │ Created-By: Maven Jar Plugin 3.2.0
> >>> │ +Specification-Title: Apache Maven Site Plugin^M
> >>> │ Specification-Version: 3.9
> >>> │ -Implementation-Vendor: The Apache Software Foundation^M
> >>
> >> I wonder where the CRs code from...this could be the default
> >> serialization format on every platform.
> >
> > FYI I don't have such CRs in output on my Linux box
>
> This cannot be. See
> https://github.com/AdoptOpenJDK/openjdk-jdk11u/blob/master/src/java.base/sha
> re/classes/java/util/jar/Manifest.java and search for \r\n. Old Sun code
> uses *always* CRLF. Plase recheck on your side and run a hexdump on the
> Manifest file.
>
> >>> how did you find the experience? any improvement proposal?
> >>> and any idea on where to put this goal in the future?
> >>
> >> There is room for improvement when I quickly read the code. I will write
> >> separately on this.
> >
> > sure, code can be improved: don't hesitate
> > but I was not asking yet for code improvement (I'm confident, it will
> > happen) but *experience* improvement
> >
> >> I'd leave as a plugin for now.
> >
> > you mean a separate plugin? same "buildinfo" name as current? "save" goal
> > name?
>
> OK, let's talk about experience:
>
> * buildinfo may be changed to broader name, e.g.,
> maven-reproducibility-plugin. Explanain follows
> * 'save' does too much. It should save only and not compare. Save should
> either run at initialize or at build-resources phase, imho
> * Add a 'compare' goal, not phase bound. It performs the actual comparsion.
>
> Strictly speaking if the plugin is called buildinfo it should handle the
> buildinfo files only.
>
> >> At least in 3.7.x.
> >
> > 3.7.x as Maven 3.7.x?
> > does that mean that you think it should be one day integrated into Maven
> > core? what's the rationale?
>
> Not really, but if this happens, not before 4.x. I don't have any
> rationale or entry point for this yet.
>
> Michael
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: Please check master branch build before merging
I'll take a look at the doxia-site-tools issues. I think the maven-shared-utils issues have something to do with Windows. I filed 862 for this: https://issues.apache.org/jira/browse/MSHARED-862 Perhaps someone who works on Windows can investigate. It would be helpful if we could hook Jenkins directly into Github as Travis and CircleCI do, do we don't have to go hunting for the CI results. On Sun, Mar 8, 2020 at 5:29 PM Robert Scholte wrote: > > To ensure that our projects are stable, we're testing all our projects with a > matrix of OSes and JDKs (and in case of plugin Maven versions) > > The master status can be found at (this static page is updated once per day!): > https://builds.apache.org/view/M-R/view/Maven/job/dist-tool-plugin/site/dist-tool-master-jobs.html > > It is possible to have all blue (/green). Even after adding new JDKs and > Central switching to https I've been able to get all masters back to stable. > > As you might see right now a couple are failing. It might be an infra issue > (broken Jenkins node) in which case you can exclude that node [1]. > For the same reason, start with a branch before pushing to master. Once > you've seen all blue on the branch, you should merge back to master. > > If tests are broken, I will ask the committer to fix his commit. If that > requires some assistance, I can help. > > thanks, > Robert > > [1] https://gitbox.apache.org/repos/asf/maven-jenkins-env.git > -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Please check master branch build before merging
To ensure that our projects are stable, we're testing all our projects with a matrix of OSes and JDKs (and in case of plugin Maven versions) The master status can be found at (this static page is updated once per day!): https://builds.apache.org/view/M-R/view/Maven/job/dist-tool-plugin/site/dist-tool-master-jobs.html It is possible to have all blue (/green). Even after adding new JDKs and Central switching to https I've been able to get all masters back to stable. As you might see right now a couple are failing. It might be an infra issue (broken Jenkins node) in which case you can exclude that node [1]. For the same reason, start with a branch before pushing to master. Once you've seen all blue on the branch, you should merge back to master. If tests are broken, I will ask the committer to fix his commit. If that requires some assistance, I can help. thanks, Robert [1] https://gitbox.apache.org/repos/asf/maven-jenkins-env.git
Re: [DISCUSS] checking reproducible builds
I'm thinking of maven-artifact-plugin, having goals related to artifacts.
That implies that the save goal should be renamed.
A couple of goals of the maven-dependency-plugin are actually more
artifact-related are might be worth moving.
Robert
On 8-3-2020 13:44:07, Michael Osipov wrote:
Am 2020-03-08 um 12:48 schrieb Hervé BOUTEMY:
> Le dimanche 8 mars 2020, 00:31:07 CET Michael Osipov a écrit :
>> Am 2020-03-07 um 19:04 schrieb Hervé BOUTEMY:
>>> Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit :
This is expected because I am on 1.8.0_242. I don't have Java 7
installed anymore on the server.
>>>
>>> for the discussion I wanted us to have, just being able to test and see
>>> how we detect issues, this is perfect, isn't it?
>>
>> This is really nice. Here is the diffoscope output:
> you're discovering the wonders of diffoscope :)
>
>>> --- maven-site-plugin-3.9.0.jar
>>> +++ reference/maven-site-plugin-3.9.0.jar
>>> ├── zipinfo {}
>>> │ @@ -1,8 +1,8 @@
> [...]
>>> META-INF/MANIFEST.MF
>>> │ @@ -1,10 +1,10 @@
>>> │ Manifest-Version: 1.0
>>> │ +Implementation-Vendor: The Apache Software Foundation^M
>>> │ Implementation-Title: Apache Maven Site Plugin
>>> │ Implementation-Version: 3.9.0
>>> │ +Build-Jdk-Spec: 1.7^M
>>> │ Specification-Vendor: The Apache Software Foundation
>>> │ -Specification-Title: Apache Maven Site Plugin^M
>>> │ -Build-Jdk-Spec: 1.8^M
>>> │ Created-By: Maven Jar Plugin 3.2.0
>>> │ +Specification-Title: Apache Maven Site Plugin^M
>>> │ Specification-Version: 3.9
>>> │ -Implementation-Vendor: The Apache Software Foundation^M
>>
>> I wonder where the CRs code from...this could be the default
>> serialization format on every platform.
> FYI I don't have such CRs in output on my Linux box
This cannot be. See
https://github.com/AdoptOpenJDK/openjdk-jdk11u/blob/master/src/java.base/share/classes/java/util/jar/Manifest.java
and search for \r\n. Old Sun code uses *always* CRLF. Plase recheck on
your side and run a hexdump on the Manifest file.
>>> how did you find the experience? any improvement proposal?
>>> and any idea on where to put this goal in the future?
>>
>> There is room for improvement when I quickly read the code. I will write
>> separately on this.
> sure, code can be improved: don't hesitate
> but I was not asking yet for code improvement (I'm confident, it will happen)
> but *experience* improvement
>
>> I'd leave as a plugin for now.
> you mean a separate plugin? same "buildinfo" name as current? "save" goal
> name?
OK, let's talk about experience:
* buildinfo may be changed to broader name, e.g.,
maven-reproducibility-plugin. Explanain follows
* 'save' does too much. It should save only and not compare. Save should
either run at initialize or at build-resources phase, imho
* Add a 'compare' goal, not phase bound. It performs the actual comparsion.
Strictly speaking if the plugin is called buildinfo it should handle the
buildinfo files only.
>> At least in 3.7.x.
> 3.7.x as Maven 3.7.x?
> does that mean that you think it should be one day integrated into Maven core?
> what's the rationale?
Not really, but if this happens, not before 4.x. I don't have any
rationale or entry point for this yet.
Michael
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: Current master is broken
Am 2020-03-08 um 20:46 schrieb Robert Scholte: you mean it was broken with current master and after applying this patch it is fixed? Correct. On 8-3-2020 14:22:21, Michael Osipov wrote: Am 2020-03-08 um 13:06 schrieb Robert Scholte: https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a151f10c7823cbbbe98446acad68da0ff82f2e04 should fix it, please verify. This perfectly works now for MSITE 3.9.0 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Current master is broken
you mean it was broken with current master and after applying this patch it is fixed? On 8-3-2020 14:22:21, Michael Osipov wrote: Am 2020-03-08 um 13:06 schrieb Robert Scholte: > https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a151f10c7823cbbbe98446acad68da0ff82f2e04 > should fix it, please verify. This perfectly works now for MSITE 3.9.0 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [DISCUSS] checking reproducible builds
Il Dom 8 Mar 2020, 13:44 Michael Osipov ha scritto:
> Am 2020-03-08 um 12:48 schrieb Hervé BOUTEMY:
> > Le dimanche 8 mars 2020, 00:31:07 CET Michael Osipov a écrit :
> >> Am 2020-03-07 um 19:04 schrieb Hervé BOUTEMY:
> >>> Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit :
> This is expected because I am on 1.8.0_242. I don't have Java 7
> installed anymore on the server.
> >>>
> >>> for the discussion I wanted us to have, just being able to test and see
> >>> how we detect issues, this is perfect, isn't it?
> >>
> >> This is really nice. Here is the diffoscope output:
> > you're discovering the wonders of diffoscope :)
> >
> >>> --- maven-site-plugin-3.9.0.jar
> >>> +++ reference/maven-site-plugin-3.9.0.jar
> >>> ├── zipinfo {}
> >>> │ @@ -1,8 +1,8 @@
> > [...]
> >>> META-INF/MANIFEST.MF
> >>> │ @@ -1,10 +1,10 @@
> >>> │ Manifest-Version: 1.0
> >>> │ +Implementation-Vendor: The Apache Software Foundation^M
> >>> │ Implementation-Title: Apache Maven Site Plugin
> >>> │ Implementation-Version: 3.9.0
> >>> │ +Build-Jdk-Spec: 1.7^M
> >>> │ Specification-Vendor: The Apache Software Foundation
> >>> │ -Specification-Title: Apache Maven Site Plugin^M
> >>> │ -Build-Jdk-Spec: 1.8^M
> >>> │ Created-By: Maven Jar Plugin 3.2.0
> >>> │ +Specification-Title: Apache Maven Site Plugin^M
> >>> │ Specification-Version: 3.9
> >>> │ -Implementation-Vendor: The Apache Software Foundation^M
> >>
> >> I wonder where the CRs code from...this could be the default
> >> serialization format on every platform.
> > FYI I don't have such CRs in output on my Linux box
>
> This cannot be. See
>
> https://github.com/AdoptOpenJDK/openjdk-jdk11u/blob/master/src/java.base/share/classes/java/util/jar/Manifest.java
> and search for \r\n. Old Sun code uses *always* CRLF. Plase recheck on
> your side and run a hexdump on the Manifest file.
>
> >>> how did you find the experience? any improvement proposal?
> >>> and any idea on where to put this goal in the future?
> >>
> >> There is room for improvement when I quickly read the code. I will write
> >> separately on this.
> > sure, code can be improved: don't hesitate
> > but I was not asking yet for code improvement (I'm confident, it will
> happen)
> > but *experience* improvement
> >
> >> I'd leave as a plugin for now.
> > you mean a separate plugin? same "buildinfo" name as current? "save" goal
> > name?
>
> OK, let's talk about experience:
>
> * buildinfo may be changed to broader name, e.g.,
> maven-reproducibility-plugin.
+1
> Explanain follows
> * 'save' does too much. It should save only and not compare. Save should
> either run at initialize or at build-resources phase, imho
> * Add a 'compare' goal, not phase bound. It performs the actual comparsion.
>
+1 for splitting this way
Enrico
> Strictly speaking if the plugin is called buildinfo it should handle the
> buildinfo files only.
>
> >> At least in 3.7.x.
> > 3.7.x as Maven 3.7.x?
> > does that mean that you think it should be one day integrated into Maven
> core?
> > what's the rationale?
>
> Not really, but if this happens, not before 4.x. I don't have any
> rationale or entry point for this yet.
>
> Michael
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2
Hi, it was MDEP-648, which was mentioned in the previous email thread
("Trying to release maven-dependency-plugin"), the thread which I referred
to in my previous reply.
- Eric L
On Sun, Mar 8, 2020 at 3:45 PM Hervé BOUTEMY wrote:
> you did not answer to the important part: what benefit do you expect from
> these? are you stuck by a bug?
>
> Le dimanche 8 mars 2020, 13:14:31 CET Eric Lilja a écrit :
> > It's not too late, all it takes is will, and it was feedbacked by another
> > person in the previous thread regarding the upcoming release of this
> > plugin, but his mail didn't receive a response.
> >
> > - Eric L
> >
> > On Sun, Mar 8, 2020 at 9:21 AM Hervé BOUTEMY
> wrote:
> > > what benefit do you expect from these?
> > > are you stuck by a bug?
> > >
> > > Notice: too late for this release, this is a vote thread
> > > the feedback eventually useful here is "blocking issue found while
> ...",
> > > then
> > > the release manager can look if this is critical for any user or just
> an
> > > edge
> > > case, and choose to finish the release or cancel it
> > >
> > > Regards,
> > >
> > > Hervé
> > >
> > > Le samedi 7 mars 2020, 19:33:47 CET Eric Lilja a écrit :
> > > > It would be very nice to release maven-artifact-transfer first (both
> > >
> > > 0.12.1
> > >
> > > > and 0.13.0 look ready in Jira, with one and two issues closed
> > >
> > > respectively,
> > >
> > > > so I would go for 0.13.0 to get all ready fixes out), and integrate
> into
> > > > this release. Please consider doing that!
> > > >
> > > > - Eric L
> > > >
> > > > On Sat, Mar 7, 2020 at 12:56 PM Karl Heinz Marbaise <
> khmarba...@gmx.de>
> > > >
> > > > wrote:
> > > > > We solved 23 issues:
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227;
> > >
> > > > > version=12343772
> > >
> > > > > There are still a couple of issues left in JIRA:
> > >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDEP%20AND%20re
> > >
> > >
> solution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
> > >
> > > > > %2C%20updated%20DESC
> > > > >
> > > > > Staging repo:
> > > > > https://repository.apache.org/content/repositories/maven-1555
> > >
> > >
> https://repository.apache.org/content/repositories/maven-1555/org/apache/m
> > >
> > >
> aven/plugins/maven-dependency-plugin/3.1.2/maven-dependency-plugin-3.1.2-s
> > >
> > > > > ource-release.zip
> > > > >
> > > > > Source release checksum(s):
> > >
> > > > > [NAME-OF]-source-release.zip sha512:
> > >
> e06c1696842682e599c2b7e6a24c58ac0c01ae0d5bf57fcc7269a7fd11092143c598fa82f9
> > >
> > > > > 08ee181d905cb949f44515e14b7b899e5df1aa184d68d2d308f83f
> > >
> > > > > Staging site:
> > >
> https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/
> > >
> > > > > Guide to testing staged releases:
> > >
> https://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > > > Vote open for at least 72 hours.
> > > > >
> > > > > [ ] +1
> > > > > [ ] +0
> > > > > [ ] -1
> > > > >
> > > > > Kind regards
> > > > > Karl Heinz Marbaise
> > > > >
> > > > >
> -
> > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > > > For additional commands, e-mail: dev-h...@maven.apache.org
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2
you did not answer to the important part: what benefit do you expect from these? are you stuck by a bug? Le dimanche 8 mars 2020, 13:14:31 CET Eric Lilja a écrit : > It's not too late, all it takes is will, and it was feedbacked by another > person in the previous thread regarding the upcoming release of this > plugin, but his mail didn't receive a response. > > - Eric L > > On Sun, Mar 8, 2020 at 9:21 AM Hervé BOUTEMY wrote: > > what benefit do you expect from these? > > are you stuck by a bug? > > > > Notice: too late for this release, this is a vote thread > > the feedback eventually useful here is "blocking issue found while ...", > > then > > the release manager can look if this is critical for any user or just an > > edge > > case, and choose to finish the release or cancel it > > > > Regards, > > > > Hervé > > > > Le samedi 7 mars 2020, 19:33:47 CET Eric Lilja a écrit : > > > It would be very nice to release maven-artifact-transfer first (both > > > > 0.12.1 > > > > > and 0.13.0 look ready in Jira, with one and two issues closed > > > > respectively, > > > > > so I would go for 0.13.0 to get all ready fixes out), and integrate into > > > this release. Please consider doing that! > > > > > > - Eric L > > > > > > On Sat, Mar 7, 2020 at 12:56 PM Karl Heinz Marbaise > > > > > > wrote: > > > > We solved 23 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227; > > > > > > version=12343772 > > > > > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDEP%20AND%20re > > > > solution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC > > > > > > %2C%20updated%20DESC > > > > > > > > Staging repo: > > > > https://repository.apache.org/content/repositories/maven-1555 > > > > https://repository.apache.org/content/repositories/maven-1555/org/apache/m > > > > aven/plugins/maven-dependency-plugin/3.1.2/maven-dependency-plugin-3.1.2-s > > > > > > ource-release.zip > > > > > > > > Source release checksum(s): > > > > > > [NAME-OF]-source-release.zip sha512: > > e06c1696842682e599c2b7e6a24c58ac0c01ae0d5bf57fcc7269a7fd11092143c598fa82f9 > > > > > > 08ee181d905cb949f44515e14b7b899e5df1aa184d68d2d308f83f > > > > > > Staging site: > > https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/ > > > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > Vote open for at least 72 hours. > > > > > > > > [ ] +1 > > > > [ ] +0 > > > > [ ] -1 > > > > > > > > Kind regards > > > > Karl Heinz Marbaise > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Current master is broken
Am 2020-03-08 um 13:06 schrieb Robert Scholte: https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a151f10c7823cbbbe98446acad68da0ff82f2e04 should fix it, please verify. This perfectly works now for MSITE 3.9.0 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Another Release for Maven Dependency Plugin WAS [VOTE] Release Apache Maven Dependency Plugin version 3.1.2
Fair enough! The reason the plugin hadn't been released in such a long time was what made me worried about not including fixes that seemed pretty much good-to-go and that users had asked for, in case the slow release cycle would to continue. Thanks for doing the release, Karl, and thanks for sharing upcoming plans for this plugin and artifact-transfer! Looking forward to it! - Eric L On Sun, Mar 8, 2020 at 1:33 PM Karl Heinz Marbaise wrote: > Hi, > > the Apache Maven Dependency Plugin hasn't been released for a very long > time (approx. a year) so I will finish the release first (except someone > finds a blocking issue) and afterwards I really appreciate to work on > another release with upgraded parts for maven-artifact-transfer > apart from that in artifact-transfer there should be done several > updates first and only a single release will be done for 0.13.0... and > afterwards making a release of it ...and then integrate that into > maven-dependency-plugin and make another release of maven dependency > plugin. > > > Kind regards > Karl Heinz Marbaise > > On 07.03.20 19:33, Eric Lilja wrote: > > It would be very nice to release maven-artifact-transfer first (both > > 0.12.1 and 0.13.0 look ready in Jira, with one and two issues closed > > respectively, so I would go for 0.13.0 to get all ready fixes out), and > > integrate into this release. Please consider doing that! > > > > - Eric L >
Re: [DISCUSS] checking reproducible builds
Am 2020-03-08 um 12:48 schrieb Hervé BOUTEMY:
Le dimanche 8 mars 2020, 00:31:07 CET Michael Osipov a écrit :
Am 2020-03-07 um 19:04 schrieb Hervé BOUTEMY:
Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit :
This is expected because I am on 1.8.0_242. I don't have Java 7
installed anymore on the server.
for the discussion I wanted us to have, just being able to test and see
how we detect issues, this is perfect, isn't it?
This is really nice. Here is the diffoscope output:
you're discovering the wonders of diffoscope :)
--- maven-site-plugin-3.9.0.jar
+++ reference/maven-site-plugin-3.9.0.jar
├── zipinfo {}
│ @@ -1,8 +1,8 @@
[...]
META-INF/MANIFEST.MF
│ @@ -1,10 +1,10 @@
│ Manifest-Version: 1.0
│ +Implementation-Vendor: The Apache Software Foundation^M
│ Implementation-Title: Apache Maven Site Plugin
│ Implementation-Version: 3.9.0
│ +Build-Jdk-Spec: 1.7^M
│ Specification-Vendor: The Apache Software Foundation
│ -Specification-Title: Apache Maven Site Plugin^M
│ -Build-Jdk-Spec: 1.8^M
│ Created-By: Maven Jar Plugin 3.2.0
│ +Specification-Title: Apache Maven Site Plugin^M
│ Specification-Version: 3.9
│ -Implementation-Vendor: The Apache Software Foundation^M
I wonder where the CRs code from...this could be the default
serialization format on every platform.
FYI I don't have such CRs in output on my Linux box
This cannot be. See
https://github.com/AdoptOpenJDK/openjdk-jdk11u/blob/master/src/java.base/share/classes/java/util/jar/Manifest.java
and search for \r\n. Old Sun code uses *always* CRLF. Plase recheck on
your side and run a hexdump on the Manifest file.
how did you find the experience? any improvement proposal?
and any idea on where to put this goal in the future?
There is room for improvement when I quickly read the code. I will write
separately on this.
sure, code can be improved: don't hesitate
but I was not asking yet for code improvement (I'm confident, it will happen)
but *experience* improvement
I'd leave as a plugin for now.
you mean a separate plugin? same "buildinfo" name as current? "save" goal
name?
OK, let's talk about experience:
* buildinfo may be changed to broader name, e.g.,
maven-reproducibility-plugin. Explanain follows
* 'save' does too much. It should save only and not compare. Save should
either run at initialize or at build-resources phase, imho
* Add a 'compare' goal, not phase bound. It performs the actual comparsion.
Strictly speaking if the plugin is called buildinfo it should handle the
buildinfo files only.
At least in 3.7.x.
3.7.x as Maven 3.7.x?
does that mean that you think it should be one day integrated into Maven core?
what's the rationale?
Not really, but if this happens, not before 4.x. I don't have any
rationale or entry point for this yet.
Michael
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: Current master is broken
Il Dom 8 Mar 2020, 13:06 Robert Scholte ha scritto: > > https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a151f10c7823cbbbe98446acad68da0ff82f2e04 > should fix it, please verify. > I can't do it today, I am sorry. I will check as soon as I have my laptop :) Thanks for addressing the problem so soon Enrico > > > thanks, > Robert > On 6-3-2020 11:13:52, Enrico Olivelli wrote: > Il giorno ven 6 mar 2020 alle ore 10:43 Robert Scholte > ha scritto: > > > > I found the root cause, and it is quite exclusive for maven-shade-plugin > (rewriting reduced-pom where excludes need to be updated). No need to > revert, this is on top of my list to fix. > > Good. > It is important that we keep compatibility with current version of > maven shade plugin. > It would be a too big burden to force uses to update a plugin in order > to work with Maven 3.7.0 > > Enrico > > > > > Robert > > On 3-3-2020 23:23:47, Enrico Olivelli wrote: > > Hi guys, > > I am trying current master and the build of a simple project > > (https://github.com/diennea/herddb) is stuck in the Maven Shade Plugin > > > > The bad commit is > > 716cc1fe02661897232a7cc3e4c1bb3b3df3b832 > https://github.com/apache/maven/commit/716cc1fe02661897232a7cc3e4c1bb3b3df3b832 > > > > With a > > git revert 716cc1fe02661897232a7cc3e4c1bb3b3df3b832 > > > > The build passes > > The commit is from Robert. > > I feel it is good to push such a revert if we do not have time to > > investigate, otherwise code will diverge too much and we will not be > > able to find a fix easily > > > > Enrico > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Another Release for Maven Dependency Plugin WAS [VOTE] Release Apache Maven Dependency Plugin version 3.1.2
Hi, the Apache Maven Dependency Plugin hasn't been released for a very long time (approx. a year) so I will finish the release first (except someone finds a blocking issue) and afterwards I really appreciate to work on another release with upgraded parts for maven-artifact-transfer apart from that in artifact-transfer there should be done several updates first and only a single release will be done for 0.13.0... and afterwards making a release of it ...and then integrate that into maven-dependency-plugin and make another release of maven dependency plugin. Kind regards Karl Heinz Marbaise On 07.03.20 19:33, Eric Lilja wrote: It would be very nice to release maven-artifact-transfer first (both 0.12.1 and 0.13.0 look ready in Jira, with one and two issues closed respectively, so I would go for 0.13.0 to get all ready fixes out), and integrate into this release. Please consider doing that! - Eric L - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2
It's not too late, all it takes is will, and it was feedbacked by another person in the previous thread regarding the upcoming release of this plugin, but his mail didn't receive a response. - Eric L On Sun, Mar 8, 2020 at 9:21 AM Hervé BOUTEMY wrote: > what benefit do you expect from these? > are you stuck by a bug? > > Notice: too late for this release, this is a vote thread > the feedback eventually useful here is "blocking issue found while ...", > then > the release manager can look if this is critical for any user or just an > edge > case, and choose to finish the release or cancel it > > Regards, > > Hervé > > Le samedi 7 mars 2020, 19:33:47 CET Eric Lilja a écrit : > > It would be very nice to release maven-artifact-transfer first (both > 0.12.1 > > and 0.13.0 look ready in Jira, with one and two issues closed > respectively, > > so I would go for 0.13.0 to get all ready fixes out), and integrate into > > this release. Please consider doing that! > > > > - Eric L > > > > On Sat, Mar 7, 2020 at 12:56 PM Karl Heinz Marbaise > > > > wrote: > > > We solved 23 issues: > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227; > > > version=12343772 > > > > > > There are still a couple of issues left in JIRA: > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDEP%20AND%20re > > > > solution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC > > > %2C%20updated%20DESC > > > > > > Staging repo: > > > https://repository.apache.org/content/repositories/maven-1555 > > > > > > > > > > https://repository.apache.org/content/repositories/maven-1555/org/apache/m > > > > aven/plugins/maven-dependency-plugin/3.1.2/maven-dependency-plugin-3.1.2-s > > > ource-release.zip > > > > > > Source release checksum(s): > > > [NAME-OF]-source-release.zip sha512: > > > > > > > e06c1696842682e599c2b7e6a24c58ac0c01ae0d5bf57fcc7269a7fd11092143c598fa82f9 > > > 08ee181d905cb949f44515e14b7b899e5df1aa184d68d2d308f83f > > > > > > Staging site: > > > > https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/ > > > > > > Guide to testing staged releases: > > > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > Vote open for at least 72 hours. > > > > > > [ ] +1 > > > [ ] +0 > > > [ ] -1 > > > > > > Kind regards > > > Karl Heinz Marbaise > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Current master is broken
https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a151f10c7823cbbbe98446acad68da0ff82f2e04 should fix it, please verify. thanks, Robert On 6-3-2020 11:13:52, Enrico Olivelli wrote: Il giorno ven 6 mar 2020 alle ore 10:43 Robert Scholte ha scritto: > > I found the root cause, and it is quite exclusive for maven-shade-plugin > (rewriting reduced-pom where excludes need to be updated). No need to revert, > this is on top of my list to fix. Good. It is important that we keep compatibility with current version of maven shade plugin. It would be a too big burden to force uses to update a plugin in order to work with Maven 3.7.0 Enrico > > Robert > On 3-3-2020 23:23:47, Enrico Olivelli wrote: > Hi guys, > I am trying current master and the build of a simple project > (https://github.com/diennea/herddb) is stuck in the Maven Shade Plugin > > The bad commit is > 716cc1fe02661897232a7cc3e4c1bb3b3df3b832https://github.com/apache/maven/commit/716cc1fe02661897232a7cc3e4c1bb3b3df3b832 > > With a > git revert 716cc1fe02661897232a7cc3e4c1bb3b3df3b832 > > The build passes > The commit is from Robert. > I feel it is good to push such a revert if we do not have time to > investigate, otherwise code will diverge too much and we will not be > able to find a fix easily > > Enrico > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [DISCUSS] checking reproducible builds
Le dimanche 8 mars 2020, 00:31:07 CET Michael Osipov a écrit :
> Am 2020-03-07 um 19:04 schrieb Hervé BOUTEMY:
> > Le samedi 7 mars 2020, 17:39:20 CET Michael Osipov a écrit :
> >> This is expected because I am on 1.8.0_242. I don't have Java 7
> >> installed anymore on the server.
> >
> > for the discussion I wanted us to have, just being able to test and see
> > how we detect issues, this is perfect, isn't it?
>
> This is really nice. Here is the diffoscope output:
you're discovering the wonders of diffoscope :)
> > --- maven-site-plugin-3.9.0.jar
> > +++ reference/maven-site-plugin-3.9.0.jar
> > ├── zipinfo {}
> > │ @@ -1,8 +1,8 @@
[...]
> > META-INF/MANIFEST.MF
> > │ @@ -1,10 +1,10 @@
> > │ Manifest-Version: 1.0
> > │ +Implementation-Vendor: The Apache Software Foundation^M
> > │ Implementation-Title: Apache Maven Site Plugin
> > │ Implementation-Version: 3.9.0
> > │ +Build-Jdk-Spec: 1.7^M
> > │ Specification-Vendor: The Apache Software Foundation
> > │ -Specification-Title: Apache Maven Site Plugin^M
> > │ -Build-Jdk-Spec: 1.8^M
> > │ Created-By: Maven Jar Plugin 3.2.0
> > │ +Specification-Title: Apache Maven Site Plugin^M
> > │ Specification-Version: 3.9
> > │ -Implementation-Vendor: The Apache Software Foundation^M
>
> I wonder where the CRs code from...this could be the default
> serialization format on every platform.
FYI I don't have such CRs in output on my Linux box
>
> > how did you find the experience? any improvement proposal?
> > and any idea on where to put this goal in the future?
>
> There is room for improvement when I quickly read the code. I will write
> separately on this.
sure, code can be improved: don't hesitate
but I was not asking yet for code improvement (I'm confident, it will happen)
but *experience* improvement
> I'd leave as a plugin for now.
you mean a separate plugin? same "buildinfo" name as current? "save" goal
name?
> At least in 3.7.x.
3.7.x as Maven 3.7.x?
does that mean that you think it should be one day integrated into Maven core?
what's the rationale?
Regards,
Hervé
>
> M
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: MavenProject - replacement for deprecated method
Good question, I'm missing that same information. On 7-3-2020 18:42:35, Slawomir Jaranowski wrote: Hi, In my plugin I need list of report plugins, I use method: org.apache.maven.project.MavenProject#getReportArtifacts but this method (and many other) is deprecated in class MavenProject - maven-core version 3.5.0 What method / class / library I should use instead of this. In source code there isn't any information about replacement. -- Sławomir Jaranowski
Re: [VOTE] Release Apache Maven Dependency Plugin version 3.1.2
what benefit do you expect from these? are you stuck by a bug? Notice: too late for this release, this is a vote thread the feedback eventually useful here is "blocking issue found while ...", then the release manager can look if this is critical for any user or just an edge case, and choose to finish the release or cancel it Regards, Hervé Le samedi 7 mars 2020, 19:33:47 CET Eric Lilja a écrit : > It would be very nice to release maven-artifact-transfer first (both 0.12.1 > and 0.13.0 look ready in Jira, with one and two issues closed respectively, > so I would go for 0.13.0 to get all ready fixes out), and integrate into > this release. Please consider doing that! > > - Eric L > > On Sat, Mar 7, 2020 at 12:56 PM Karl Heinz Marbaise > > wrote: > > We solved 23 issues: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227; > > version=12343772 > > > > There are still a couple of issues left in JIRA: > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDEP%20AND%20re > > solution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC > > %2C%20updated%20DESC > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1555 > > > > > > https://repository.apache.org/content/repositories/maven-1555/org/apache/m > > aven/plugins/maven-dependency-plugin/3.1.2/maven-dependency-plugin-3.1.2-s > > ource-release.zip > > > > Source release checksum(s): > > [NAME-OF]-source-release.zip sha512: > > > > e06c1696842682e599c2b7e6a24c58ac0c01ae0d5bf57fcc7269a7fd11092143c598fa82f9 > > 08ee181d905cb949f44515e14b7b899e5df1aa184d68d2d308f83f > > > > Staging site: > > https://maven.apache.org/plugins-archives/maven-dependency-plugin-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > Kind regards > > Karl Heinz Marbaise > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
