date:20200603

JVM Arguments not working for JDK11

2020-06-03 Thread Ankit Tomar

Hi Team,

I am trying to pass jvmArguments in plugin but they are not working.
We are using embedded cassandra in our application and it tries to access
JDK's internal classes and after JDK 11 Java has put strict checks on
internal class access using reflection . There is one work-around for it
that is to pass packages to access using *--add-exports *option .

I need to pass below option to plugin:

-Djdk.attach.allowAttachSelf=true --add-exports
java.base/jdk.internal.misc=ALL-UNNAMED --add-exports
java.base/jdk.internal.ref=ALL-UNNAMED --add-exports
java.base/sun.nio.ch=ALL-UNNAMED
--add-exports
java.management.rmi/com.sun.jmx.remote.internal.rmi=ALL-UNNAMED
--add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED --add-exports
java.rmi/sun.rmi.server=ALL-UNNAMED --add-exports
java.sql/java.sql=ALL-UNNAMED  --add-opens
java.base/java.lang.module=ALL-UNNAMED --add-opens
java.base/jdk.internal.loader=ALL-UNNAMED --add-opens
java.base/jdk.internal.ref=ALL-UNNAMED --add-opens
java.base/jdk.internal.reflect=ALL-UNNAMED --add-opens
java.base/jdk.internal.math=ALL-UNNAMED --add-opens
java.base/jdk.internal.module=ALL-UNNAMED --add-opens
java.base/jdk.internal.util.jar=ALL-UNNAMED --add-opens
jdk.management/com.sun.management.internal=ALL-UNNAMED

Please suggest how to pass these arguments.


Thanks & Regards,
Ankit

Re: JVM Arguments not working for JDK11

2020-06-03 Thread Ankit Tomar

Missed plugin name, I am using appassembler-maven-plugin
I have tried  and  but both are not
working

Thanks & Regards,
Ankit


On Wed, Jun 3, 2020 at 6:39 PM Ankit Tomar 
wrote:

> Hi ,
>
> Please suggest how to pass these arguments to the plugin.
>
> On Tue, Jun 2, 2020 at 11:13 PM Ankit Tomar 
> wrote:
>
>> Hi Team,
>>
>> I am trying to pass jvmArguments in plugin but they are not working.
>> We are using embedded cassandra in our application and it tries to access
>> JDK's internal classes and after JDK 11 Java has put strict checks on
>> internal class access using reflection . There is one work-around for it
>> that is to pass packages to access using *--add-exports *option .
>>
>> I need to pass below option to plugin:
>>
>> -Djdk.attach.allowAttachSelf=true --add-exports
>> java.base/jdk.internal.misc=ALL-UNNAMED --add-exports
>> java.base/jdk.internal.ref=ALL-UNNAMED --add-exports 
>> java.base/sun.nio.ch=ALL-UNNAMED
>> --add-exports
>> java.management.rmi/com.sun.jmx.remote.internal.rmi=ALL-UNNAMED
>> --add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED --add-exports
>> java.rmi/sun.rmi.server=ALL-UNNAMED --add-exports
>> java.sql/java.sql=ALL-UNNAMED  --add-opens
>> java.base/java.lang.module=ALL-UNNAMED --add-opens
>> java.base/jdk.internal.loader=ALL-UNNAMED --add-opens
>> java.base/jdk.internal.ref=ALL-UNNAMED --add-opens
>> java.base/jdk.internal.reflect=ALL-UNNAMED --add-opens
>> java.base/jdk.internal.math=ALL-UNNAMED --add-opens
>> java.base/jdk.internal.module=ALL-UNNAMED --add-opens
>> java.base/jdk.internal.util.jar=ALL-UNNAMED --add-opens
>> jdk.management/com.sun.management.internal=ALL-UNNAMED
>>
>> Please suggest how to pass these arguments.
>>
>>
>> Thanks & Regards,
>> Ankit
>>
>>

[GitHub] [maven-site-plugin] jonvolfson commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-03 Thread GitBox



jonvolfson commented on a change in pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434863055



##
File path: src/it/projects/MSITE-856/verify.bsh
##
@@ -0,0 +1,48 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+final File siteDirectory = new File( basedir, "target/generated-site" );
+if ( !siteDirectory.exists() || !siteDirectory.isDirectory() )
+{
+System.err.println( "generated-site is missing or not a directory." );
+result = false;

Review comment:
   Fixed. Removed the variable "result" so that false would be returned as 
soon as an error occurred. Not sure if this is the cleanest way to fix this.

##
File path: src/it/projects/MSITE-856/src/site/site.xml
##
@@ -0,0 +1,30 @@
+
+
+
+
+http://maven.apache.org/DECORATION/1.6.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/DECORATION/1.6.0 
http://maven.apache.org/xsd/decoration-1.6.0.xsd;>
+

Review comment:
   fixed

##
File path: src/it/projects/MSITE-856/verify.bsh
##
@@ -0,0 +1,49 @@
+

Review comment:
   fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-03 Thread Robert Scholte

Based on https://www.apache.org/dev/licensing-howto.html 
[https://www.apache.org/dev/licensing-howto.html] it looks like I should add 
these to the distributions as well, but to me it doesn't make sense to unpack 
these files into the targeted directory.

Robert
On 3-6-2020 21:00:47, Christofer Dutz  wrote:
Well doesn't have to be compatible as long as it does what it's supposed to.

Was just asking as I wrote the Downloader to enable Apache projects to use the 
maven wrapper (No checked in binaries)
Unfortunately we always were required to maintain the NOTICE reference that the 
scripts and the java file were third party stuff.
Just looking forward to replacing this all with the new source-distribution and 
to no longer have discussions on what has to be in the NOTICE file.

Chris



Am 03.06.20, 18:56 schrieb "Robert Scholte" :

Starting with Maven 3.7.0 there will be 3 wrapper distributions, 
org.apache.maven:apache-maven-wrapper
and with the following classifiers:
script: mvnw, mvnw.cmd, mvnwDebug, mvnwDebug.cmd, 
.mvn/wrapper/maven-wrapper.properties
bin: like script, but also .mvn/wrapper/maven-wrapper.jar

source: like script, but also .mvn/wrapper/MavenWrapperDownloader.java

I am not aware of any NOTICE file.
I expect that it can be a replacement, but for me this wrapper code is is a new 
brand feature in Maven, so there hasn't been any attempt to be backwards 
compatible with the takari code.

thanks,
Robert

On 3-6-2020 09:11:53, Christofer Dutz wrote:
Congrats on this ...

As the rest is usually just dropping the mwnw scripts, the config file and my 
downloader.java ...
is there an apache package we can now just drop in to replace the old and get 
rid of the Notice stuff?

Chris


Am 02.06.20, 22:36 schrieb "Robert Scholte" :

Hi,

The vote has passed with the following result:

+1 : Robert Scholte, Romain Manni-Bucau, Olivier Lamy, Hervé BOUTEMY, Maarten 
Mulders

PMC quorum: reached

I will promote the artifacts to the central repo.

On 30-5-2020 11:17:43, Robert Scholte wrote:
Hi,

I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to 
configure it in the next maven-core.

We solved 1 issue:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12348346=Text

There are no issues in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MWRAPPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/service/local/repositories/maven-1584/
https://repository.apache.org/service/local/repositories/maven-1584/content/org/apache/maven/plugins/maven-wrapper-plugin/3.0.1/maven-wrapper-plugin-3.0.1-source-release.zip

(note: there are some issues with https://repository.apache.org/ : you cannot 
browse through the content, but you can download the zip )

Source release checksum(s):
maven-wrapper-plugin-3.0.1-source-release.zip sha512: 
04084e8806af4507996ce7d9caafc1a9ff2c9e278ba1c0f41552edb6516d75f1685177130c76c04c262376437d96be3083c2b46309c482ab07b74785c35dafcb

Staging site:
https://maven.apache.org/plugins-archives/maven-wrapper-plugin-LATEST/

Guide to testing staged releases:
As this is a special bootstrapping release, the following instructions are a 
proper way of testing:

- clone/download+unpack current master branch of Apache Maven core ( 
https://github.com/apache/maven ) (this will make all apache-maven-wrapper 
distributions available in your local repository)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- download+unpack sources from maven-wrapper-plugin (see above)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- go to the root of any Maven project
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo wrapper:wrapper 
-DwrapperVersion=3.7.0-SNAPSHOT' with optional extra arguments

NOTE: be aware of the difference between maven-wrapper and the 
maven-wrapper-plugin.
The maven-wrapper-plugin only downloads and unpacks the maven wrapper scripts.
The content of the maven-wrapper scripts are not part of the plugin, hence not 
part of this release.
Adjustments to that content belong to Maven core

https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

?B�CB�?�?[��X��ܚX�K??K[XZ[?�??]�][��X��ܚX�P?X]�[��\?X�?K�ܙ�B��܈?Y??]?[ۘ[??��[X[�?�??K[XZ[?�??]�Z?[???X]�[��\?X�?K�ܙ�B�

Т�ХF�V�7V'67&��R���âFWb�V�7V'67&��fV��6�R��Фf�"FF�F����6����G2�R���âFWbֆV��fV��6�R��Р

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-03 Thread Christofer Dutz

Well doesn't have to be compatible as long as it does what it's supposed to.

Was just asking as I wrote the Downloader to enable Apache projects to use the 
maven wrapper (No checked in binaries)
Unfortunately we always were required to maintain the NOTICE reference that the 
scripts and the java file were third party stuff.
Just looking forward to replacing this all with the new source-distribution and 
to no longer have discussions on what has to be in the NOTICE file.

Chris



Am 03.06.20, 18:56 schrieb "Robert Scholte" :

Starting with Maven 3.7.0 there will be 3 wrapper distributions, 
org.apache.maven:apache-maven-wrapper
and with the following classifiers:
script: mvnw, mvnw.cmd, mvnwDebug, mvnwDebug.cmd, 
.mvn/wrapper/maven-wrapper.properties
bin: like script, but also .mvn/wrapper/maven-wrapper.jar

source: like script, but also .mvn/wrapper/MavenWrapperDownloader.java

I am not aware of any NOTICE file.
I expect that it can be a replacement, but for me this wrapper code is is a 
new brand feature in Maven, so there hasn't been any attempt to be backwards 
compatible with the takari code.

thanks,
Robert

On 3-6-2020 09:11:53, Christofer Dutz  wrote:
Congrats on this ...

As the rest is usually just dropping the mwnw scripts, the config file and 
my downloader.java ...
is there an apache package we can now just drop in to replace the old and 
get rid of the Notice stuff?

Chris


Am 02.06.20, 22:36 schrieb "Robert Scholte" :

Hi,

The vote has passed with the following result:

+1 : Robert Scholte, Romain Manni-Bucau, Olivier Lamy, Hervé BOUTEMY, 
Maarten Mulders

PMC quorum: reached

I will promote the artifacts to the central repo.

On 30-5-2020 11:17:43, Robert Scholte wrote:
Hi,

I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to 
configure it in the next maven-core.

We solved 1 issue:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12348346=Text

There are no issues in JIRA:

https://issues.apache.org/jira/issues/?jql=project%20%3D%20MWRAPPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/service/local/repositories/maven-1584/

https://repository.apache.org/service/local/repositories/maven-1584/content/org/apache/maven/plugins/maven-wrapper-plugin/3.0.1/maven-wrapper-plugin-3.0.1-source-release.zip

(note: there are some issues with https://repository.apache.org/ : you 
cannot browse through the content, but you can download the zip )

Source release checksum(s):
maven-wrapper-plugin-3.0.1-source-release.zip sha512: 
04084e8806af4507996ce7d9caafc1a9ff2c9e278ba1c0f41552edb6516d75f1685177130c76c04c262376437d96be3083c2b46309c482ab07b74785c35dafcb

Staging site:
https://maven.apache.org/plugins-archives/maven-wrapper-plugin-LATEST/

Guide to testing staged releases:
As this is a special bootstrapping release, the following instructions are 
a proper way of testing:

- clone/download+unpack current master branch of Apache Maven core ( 
https://github.com/apache/maven ) (this will make all apache-maven-wrapper 
distributions available in your local repository)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- download+unpack sources from maven-wrapper-plugin (see above)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- go to the root of any Maven project
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo wrapper:wrapper 
-DwrapperVersion=3.7.0-SNAPSHOT' with optional extra arguments

NOTE: be aware of the difference between maven-wrapper and the 
maven-wrapper-plugin.
The maven-wrapper-plugin only downloads and unpacks the maven wrapper 
scripts.
The content of the maven-wrapper scripts are not part of the plugin, hence 
not part of this release.
Adjustments to that content belong to Maven core

https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1


?B�CB�?�?[��X��ܚX�K??K[XZ[?�??]�][��X��ܚX�P?X]�[��\?X�?K�ܙ�B��܈?Y??]?[ۘ[??��[X[�?�??K[XZ[?�??]�Z?[???X]�[��\?X�?K�ܙ�B�

[GitHub] [maven-site-plugin] elharo commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-03 Thread GitBox



elharo commented on a change in pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434760284



##
File path: src/it/projects/MSITE-856/src/site/site.xml
##
@@ -0,0 +1,30 @@
+
+
+
+
+http://maven.apache.org/DECORATION/1.6.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/DECORATION/1.6.0 
http://maven.apache.org/xsd/decoration-1.6.0.xsd;>
+

Review comment:
   two space indents in all XML files, per Maven project guidelines

##
File path: src/it/projects/MSITE-856/verify.bsh
##
@@ -0,0 +1,49 @@
+

Review comment:
   delete blank line

##
File path: src/it/projects/MSITE-856/verify.bsh
##
@@ -0,0 +1,48 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+final File siteDirectory = new File( basedir, "target/generated-site" );
+if ( !siteDirectory.exists() || !siteDirectory.isDirectory() )
+{
+System.err.println( "generated-site is missing or not a directory." );
+result = false;

Review comment:
   consider returning when there's an answer unless for some reason you 
actually need the result variable in BSH?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [maven-site] branch master updated: details

2020-06-03 Thread Robert Scholte

Looks good to me.

I expect some trouble when moving plugins from Maven 3.0 to 3.1.0, so I've 
started a wiki page[1] with the first known issue and solution.

Robert

[1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=155749857


ps. As long as Maven isn't bundled with its own JRE, the Eclipse+Java11 is off 
topic for me.

On 3-6-2020 03:01:03, Olivier Lamy  wrote:
Hi
Please comment or (not) complain on this change.
html version https://maven.apache.org/developers/compatibility-plan.html

cheers
Olivier
PS: FYI Eclipse will be jdk11 in September
https://www.eclipse.org/lists/cross-project-issues-dev/msg17532.html

On Wed, 3 Jun 2020 at 10:56, wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> olamy pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/maven-site.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 43193ca details
> 43193ca is described below
>
> commit 43193ca123403f52664ae628fcdb5fa7e2460cec
> Author: Olivier Lamy
> AuthorDate: Wed Jun 3 10:56:34 2020 +1000
>
> details
> ---
> content/apt/developers/compatibility-plan.apt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/content/apt/developers/compatibility-plan.apt
> b/content/apt/developers/compatibility-plan.apt
> index a0213a9..d0bb8d0 100644
> --- a/content/apt/developers/compatibility-plan.apt
> +++ b/content/apt/developers/compatibility-plan.apt
> @@ -46,7 +46,7 @@ Maven Compatibility Plan
>
> * Since 2012, Maven 3.0 + Java 7 prerequisites, with plugins in 3.0
>
> - * (WIP) discussions on Maven > 3.0.x (3.1 or 3.2 or 3.3? details still
> TDB) + Java 8 prerequisites
> + * Since June 2020, Maven Plugin API used by plugins >= 3.1.0 + Java 8
> prerequisites
>
> []
>
>
>

--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-03 Thread Robert Scholte

Starting with Maven 3.7.0 there will be 3 wrapper distributions, 
org.apache.maven:apache-maven-wrapper
and with the following classifiers:
script: mvnw, mvnw.cmd, mvnwDebug, mvnwDebug.cmd, 
.mvn/wrapper/maven-wrapper.properties
bin: like script, but also .mvn/wrapper/maven-wrapper.jar

source: like script, but also .mvn/wrapper/MavenWrapperDownloader.java

I am not aware of any NOTICE file.
I expect that it can be a replacement, but for me this wrapper code is is a new 
brand feature in Maven, so there hasn't been any attempt to be backwards 
compatible with the takari code.

thanks,
Robert

On 3-6-2020 09:11:53, Christofer Dutz  wrote:
Congrats on this ...

As the rest is usually just dropping the mwnw scripts, the config file and my 
downloader.java ...
is there an apache package we can now just drop in to replace the old and get 
rid of the Notice stuff?

Chris


Am 02.06.20, 22:36 schrieb "Robert Scholte" :

Hi,

The vote has passed with the following result:

+1 : Robert Scholte, Romain Manni-Bucau, Olivier Lamy, Hervé BOUTEMY, Maarten 
Mulders

PMC quorum: reached

I will promote the artifacts to the central repo.

On 30-5-2020 11:17:43, Robert Scholte wrote:
Hi,

I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to 
configure it in the next maven-core.

We solved 1 issue:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12348346=Text

There are no issues in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MWRAPPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/service/local/repositories/maven-1584/
https://repository.apache.org/service/local/repositories/maven-1584/content/org/apache/maven/plugins/maven-wrapper-plugin/3.0.1/maven-wrapper-plugin-3.0.1-source-release.zip

(note: there are some issues with https://repository.apache.org/ : you cannot 
browse through the content, but you can download the zip )

Source release checksum(s):
maven-wrapper-plugin-3.0.1-source-release.zip sha512: 
04084e8806af4507996ce7d9caafc1a9ff2c9e278ba1c0f41552edb6516d75f1685177130c76c04c262376437d96be3083c2b46309c482ab07b74785c35dafcb

Staging site:
https://maven.apache.org/plugins-archives/maven-wrapper-plugin-LATEST/

Guide to testing staged releases:
As this is a special bootstrapping release, the following instructions are a 
proper way of testing:

- clone/download+unpack current master branch of Apache Maven core ( 
https://github.com/apache/maven ) (this will make all apache-maven-wrapper 
distributions available in your local repository)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- download+unpack sources from maven-wrapper-plugin (see above)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- go to the root of any Maven project
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo wrapper:wrapper 
-DwrapperVersion=3.7.0-SNAPSHOT' with optional extra arguments

NOTE: be aware of the difference between maven-wrapper and the 
maven-wrapper-plugin.
The maven-wrapper-plugin only downloads and unpacks the maven wrapper scripts.
The content of the maven-wrapper scripts are not part of the plugin, hence not 
part of this release.
Adjustments to that content belong to Maven core

https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

B�CB��[��X��ܚX�KK[XZ[�]�][��X��ܚX�PX]�[��\X�K�ܙ�B��܈Y][ۘ[��[X[��K[XZ[�]�Z[X]�[��\X�K�ܙ�B�

[GitHub] [maven-site-plugin] jonvolfson commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-03 Thread GitBox



jonvolfson commented on a change in pull request #31:
URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434688818



##
File path: src/main/java/org/apache/maven/plugins/site/render/SiteMap.java
##
@@ -172,9 +172,13 @@ private static void extractItems( List items, 
Sink sink )
 for ( MenuItem item : items )
 {
 sink.listItem();
-sink.link( relativePath( item.getHref() ) );
-sink.text( item.getName() );
-sink.link_();
+if ( !( item.getHref() == null ) )

Review comment:
   fixed

##
File path: src/it/projects/MSITE-856/verify.bsh
##
@@ -0,0 +1,48 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+final File siteDirectory = new File( basedir, "target/generated-site" );
+if ( !siteDirectory.exists() || !siteDirectory.isDirectory() )
+{
+System.err.println( "generated-site is missing or not a directory." );
+result = false;

Review comment:
   fixed

##
File path: src/it/projects/MSITE-856/pom.xml
##
@@ -0,0 +1,69 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+msite856
+nullcheck
+1.0-SNAPSHOT
+pom
+MSITE-856
+
+
+
+
+
+maven-site-plugin
+@project.version@
+
+true
+
+

Review comment:
   fixed, removed this dependency

##
File path: src/it/projects/MSITE-856/pom.xml
##
@@ -0,0 +1,69 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+msite856
+nullcheck
+1.0-SNAPSHOT
+pom
+MSITE-856
+
+

Review comment:
   fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

JVM Arguments not working for JDK11

2020-06-03 Thread Ankit Tomar

Hi ,

Please suggest how to pass these arguments to the plugin.

On Tue, Jun 2, 2020 at 11:13 PM Ankit Tomar 
wrote:

> Hi Team,
>
> I am trying to pass jvmArguments in plugin but they are not working.
> We are using embedded cassandra in our application and it tries to access
> JDK's internal classes and after JDK 11 Java has put strict checks on
> internal class access using reflection . There is one work-around for it
> that is to pass packages to access using *--add-exports *option .
>
> I need to pass below option to plugin:
>
> -Djdk.attach.allowAttachSelf=true --add-exports
> java.base/jdk.internal.misc=ALL-UNNAMED --add-exports
> java.base/jdk.internal.ref=ALL-UNNAMED --add-exports 
> java.base/sun.nio.ch=ALL-UNNAMED
> --add-exports
> java.management.rmi/com.sun.jmx.remote.internal.rmi=ALL-UNNAMED
> --add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED --add-exports
> java.rmi/sun.rmi.server=ALL-UNNAMED --add-exports
> java.sql/java.sql=ALL-UNNAMED  --add-opens
> java.base/java.lang.module=ALL-UNNAMED --add-opens
> java.base/jdk.internal.loader=ALL-UNNAMED --add-opens
> java.base/jdk.internal.ref=ALL-UNNAMED --add-opens
> java.base/jdk.internal.reflect=ALL-UNNAMED --add-opens
> java.base/jdk.internal.math=ALL-UNNAMED --add-opens
> java.base/jdk.internal.module=ALL-UNNAMED --add-opens
> java.base/jdk.internal.util.jar=ALL-UNNAMED --add-opens
> jdk.management/com.sun.management.internal=ALL-UNNAMED
>
> Please suggest how to pass these arguments.
>
>
> Thanks & Regards,
> Ankit
>
>

Re: [maven-site] branch master updated: details

2020-06-03 Thread Olivier Lamy

On Wed, 3 Jun 2020 at 4:56 pm, Michael Osipov  wrote:

> Am 2020-06-03 um 03:00 schrieb Olivier Lamy:
> > Hi
> > Please comment or (not) complain on this change.
> > html version https://maven.apache.org/developers/compatibility-plan.html
>
> LGTM
>
> > PS: FYI Eclipse will be jdk11 in September
> > https://www.eclipse.org/lists/cross-project-issues-dev/msg17532.html
>
> I don't understand the reasoning behind this. Simply because of Jetty
> 10? Seriously?


you should ask eclipse folks not sure we have the answer here ;)


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: [maven-site] branch master updated: details

2020-06-03 Thread Olivier Lamy

Thanks for reading this

On Wed, 3 Jun 2020 at 6:28 pm, Anders Hammar  wrote:

> A few comments:
>
> 1. I think we should separate the prerequisites for Maven core and those
> for our plugins.
> 2. Do users really care about "Maven Plugin API"? I think that an end user
> would like to know what version of Maven (core) that a plugin will work
> with.


Bear in mind this page is for maven developers (we already enough trouble
getting consensus between us so let’s avoid asking users as well :))
Maybe we should simply say Maven API?

>
>
> /Anders
>
> On Wed, Jun 3, 2020 at 3:01 AM Olivier Lamy  wrote:
>
> > Hi
> > Please comment or (not) complain on this change.
> > html version https://maven.apache.org/developers/compatibility-plan.html
> >
> > cheers
> > Olivier
> > PS: FYI Eclipse will be jdk11 in September
> > https://www.eclipse.org/lists/cross-project-issues-dev/msg17532.html
> >
> > On Wed, 3 Jun 2020 at 10:56,  wrote:
> >
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > olamy pushed a commit to branch master
> > > in repository https://gitbox.apache.org/repos/asf/maven-site.git
> > >
> > >
> > > The following commit(s) were added to refs/heads/master by this push:
> > >  new 43193ca  details
> > > 43193ca is described below
> > >
> > > commit 43193ca123403f52664ae628fcdb5fa7e2460cec
> > > Author: Olivier Lamy 
> > > AuthorDate: Wed Jun 3 10:56:34 2020 +1000
> > >
> > > details
> > > ---
> > >  content/apt/developers/compatibility-plan.apt | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/content/apt/developers/compatibility-plan.apt
> > > b/content/apt/developers/compatibility-plan.apt
> > > index a0213a9..d0bb8d0 100644
> > > --- a/content/apt/developers/compatibility-plan.apt
> > > +++ b/content/apt/developers/compatibility-plan.apt
> > > @@ -46,7 +46,7 @@ Maven Compatibility Plan
> > >
> > >* Since 2012, Maven 3.0 + Java 7 prerequisites, with plugins in 3.0
> > >
> > > -  * (WIP) discussions on Maven > 3.0.x (3.1 or 3.2 or 3.3? details
> still
> > > TDB) + Java 8 prerequisites
> > > +  * Since June 2020, Maven Plugin API used by plugins >= 3.1.0 + Java
> 8
> > > prerequisites
> > >
> > >[]
> > >
> > >
> > >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: [surefire] Invert trimStackTrace default

2020-06-03 Thread Olivier Lamy

definitely +1

On Wed, 3 Jun 2020 at 18:08, Romain Manni-Bucau 
wrote:

> Hi everyone,
>
> Shouldn't we set trimStackTrace=false by default?
> Current state makes the log quite useless since there is never the data you
> need to understand why it failed so it just mess up the output without
> added value IMO.
>
> Wdyt?
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>


-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: [maven-site] branch master updated: details

2020-06-03 Thread Anders Hammar

A few comments:

1. I think we should separate the prerequisites for Maven core and those
for our plugins.
2. Do users really care about "Maven Plugin API"? I think that an end user
would like to know what version of Maven (core) that a plugin will work
with.

/Anders

On Wed, Jun 3, 2020 at 3:01 AM Olivier Lamy  wrote:

> Hi
> Please comment or (not) complain on this change.
> html version https://maven.apache.org/developers/compatibility-plan.html
>
> cheers
> Olivier
> PS: FYI Eclipse will be jdk11 in September
> https://www.eclipse.org/lists/cross-project-issues-dev/msg17532.html
>
> On Wed, 3 Jun 2020 at 10:56,  wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > olamy pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/maven-site.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> >  new 43193ca  details
> > 43193ca is described below
> >
> > commit 43193ca123403f52664ae628fcdb5fa7e2460cec
> > Author: Olivier Lamy 
> > AuthorDate: Wed Jun 3 10:56:34 2020 +1000
> >
> > details
> > ---
> >  content/apt/developers/compatibility-plan.apt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/content/apt/developers/compatibility-plan.apt
> > b/content/apt/developers/compatibility-plan.apt
> > index a0213a9..d0bb8d0 100644
> > --- a/content/apt/developers/compatibility-plan.apt
> > +++ b/content/apt/developers/compatibility-plan.apt
> > @@ -46,7 +46,7 @@ Maven Compatibility Plan
> >
> >* Since 2012, Maven 3.0 + Java 7 prerequisites, with plugins in 3.0
> >
> > -  * (WIP) discussions on Maven > 3.0.x (3.1 or 3.2 or 3.3? details still
> > TDB) + Java 8 prerequisites
> > +  * Since June 2020, Maven Plugin API used by plugins >= 3.1.0 + Java 8
> > prerequisites
> >
> >[]
> >
> >
> >
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>

Re: [surefire] Invert trimStackTrace default

2020-06-03 Thread Enrico Olivelli

Il giorno mer 3 giu 2020 alle ore 10:08 Romain Manni-Bucau <
rmannibu...@gmail.com> ha scritto:

> Hi everyone,
>
> Shouldn't we set trimStackTrace=false by default?
>

+1
It is very awkward current default (trimStackTrace=true)

Enrico


> Current state makes the log quite useless since there is never the data you
> need to understand why it failed so it just mess up the output without
> added value IMO.
>
> Wdyt?
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>

[surefire] Invert trimStackTrace default

2020-06-03 Thread Romain Manni-Bucau

Hi everyone,

Shouldn't we set trimStackTrace=false by default?
Current state makes the log quite useless since there is never the data you
need to understand why it failed so it just mess up the output without
added value IMO.

Wdyt?

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book

[ANN] Maven Resolver Ant Tasks 1.2.1 released

2020-06-03 Thread Michael Osipov

The Apache Maven team is pleased to announce the release of the Maven 
Resolver Ant Tasks version 1.2.1.


https://maven.apache.org/resolver-ant-tasks/

Release Notes - Maven Resolver Ant Tasks - Version 1.2.1

** Bug
* [MRESOLVER-100] - Resolver Ant Task taskdef failing

** Improvement
* [MRESOLVER-102] - make build Reproducible
* [MRESOLVER-113] - Use a FileResource instead of PathElement for 
easier copy of path created by Resolve


** Dependency upgrade
* [MRESOLVER-110] - Upgrade to Maven 3.6.3
* [MRESOLVER-111] - Upgrade to Maven Resolver from 1.3.3 to 1.4.2
* [MRESOLVER-112] - Upgrade to Maven Antrun Plugin 3.0.0


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-03 Thread Christofer Dutz

Congrats on this ... 

As the rest is usually just dropping the mwnw scripts, the config file and my 
downloader.java ... 
is there an apache package we can now just drop in to replace the old and get 
rid of the Notice stuff?

Chris


Am 02.06.20, 22:36 schrieb "Robert Scholte" :

Hi,

The vote has passed with the following result:

+1 : Robert Scholte, Romain Manni-Bucau, Olivier Lamy, Hervé BOUTEMY, 
Maarten Mulders

PMC quorum: reached

I will promote the artifacts to the central repo.

On 30-5-2020 11:17:43, Robert Scholte  wrote:
Hi,

I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to 
configure it in the next maven-core. 

We solved 1 issue:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721=12348346=Text

There are no issues in JIRA:

https://issues.apache.org/jira/issues/?jql=project%20%3D%20MWRAPPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/service/local/repositories/maven-1584/

https://repository.apache.org/service/local/repositories/maven-1584/content/org/apache/maven/plugins/maven-wrapper-plugin/3.0.1/maven-wrapper-plugin-3.0.1-source-release.zip

(note: there are some issues with https://repository.apache.org/ : you 
cannot browse through the content, but you can download the zip )

Source release checksum(s):
maven-wrapper-plugin-3.0.1-source-release.zip sha512: 
04084e8806af4507996ce7d9caafc1a9ff2c9e278ba1c0f41552edb6516d75f1685177130c76c04c262376437d96be3083c2b46309c482ab07b74785c35dafcb

Staging site:
https://maven.apache.org/plugins-archives/maven-wrapper-plugin-LATEST/

Guide to testing staged releases:
As this is a special bootstrapping release, the following instructions are 
a proper way of testing:

- clone/download+unpack current master branch of Apache Maven core ( 
https://github.com/apache/maven ) (this will make all apache-maven-wrapper 
distributions available in your local repository)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- download+unpack sources from maven-wrapper-plugin (see above)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- go to the root of any Maven project
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo wrapper:wrapper 
-DwrapperVersion=3.7.0-SNAPSHOT' with optional extra arguments

NOTE: be aware of the difference between maven-wrapper and the 
maven-wrapper-plugin.
The maven-wrapper-plugin only downloads and unpacks the maven wrapper 
scripts.
The content of the maven-wrapper scripts are not part of the plugin, hence 
not part of this release.
Adjustments to that content belong to Maven core

https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

[RESULT] [VOTE] Release Maven Resolver Ant Tasks version 1.2.1

2020-06-03 Thread Michael Osipov


Hi,

The vote has passed with the following result:

+1: Michael Osipov, Sylwester Lachiewicz, Hervé Boutemy, Olivier Lamy

PMC quorum: reached

I will promote the artifacts to the central repo, the source release ZIP 
file

and add this release the board report.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [maven-site] branch master updated: details

2020-06-03 Thread Michael Osipov


Am 2020-06-03 um 03:00 schrieb Olivier Lamy:

Hi
Please comment or (not) complain on this change.
html version https://maven.apache.org/developers/compatibility-plan.html


LGTM


PS: FYI Eclipse will be jdk11 in September
https://www.eclipse.org/lists/cross-project-issues-dev/msg17532.html


I don't understand the reasoning behind this. Simply because of Jetty 
10? Seriously?


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

JVM Arguments not working for JDK11

Re: JVM Arguments not working for JDK11

[GitHub] [maven-site-plugin] jonvolfson commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

[GitHub] [maven-site-plugin] elharo commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

Re: [maven-site] branch master updated: details

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

[GitHub] [maven-site-plugin] jonvolfson commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

JVM Arguments not working for JDK11

Re: [maven-site] branch master updated: details

Re: [maven-site] branch master updated: details

Re: [surefire] Invert trimStackTrace default

Re: [maven-site] branch master updated: details

Re: [surefire] Invert trimStackTrace default

[surefire] Invert trimStackTrace default

[ANN] Maven Resolver Ant Tasks 1.2.1 released

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

[RESULT] [VOTE] Release Maven Resolver Ant Tasks version 1.2.1

Re: [maven-site] branch master updated: details

20 matches

Site Navigation

Mail list logo

Footer information