[GitHub] [maven-site-plugin] slachiewicz commented on pull request #34: [DOXIA-616]

2021-01-25 Thread GitBox 


slachiewicz commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766441620


   I'll look at it tomorrow



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]

2021-01-25 Thread GitBox 


michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766434017


   I won't be able to review before mid Feb due to circumstances here.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-25 Thread GitBox 


bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766418215


   @michael-o @hboutemy @elharo Friendly reminder that this PR is still 
waiting, and its content is not going to change with regards to the failed 
builds, which are caused by something else (*master* is failing the same builds 
the same way).
   
   The more we wait, the more risk we have to get conflicting changes.
   
   Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Loging api in JSR-330 component

2021-01-25 Thread Benjamin Marwell 
Elliotte,

MNG-7085 actually *IS* about updating the pages you mentioned.

If it is missing something (eg doc updates), we should add it to the
issue’s description.
Maybe this one needs some measurable fulfillment criteria.

Am Mo., 25. Jan. 2021 um 19:14 Uhr schrieb Elliotte Rusty Harold
:
>
> No, an issue is too easily forgotten. We should have something on the
> main web site. It needs to be consistent with or replace:
>
> https://maven.apache.org/maven-jsr330.html
> https://maven.apache.org/maven-logging.html
>
> In addition the API docs of the relevant libraries need to be updated.
>
> Maven has a lot of technical debt, and a large part of that is both a
> symptom and a cause of outdated, incomplete, and inconsistent
> documentation. Long time committers routinely suggest contradictory
> approaches as the way Maven does things. The only way I know to avoid
> this is to have normative, maintained documentation of agreed
> development practices that is in the source repo and published on the
> web site. This helps flush out and resolve areas where different
> committers believe different things to be true. When a conflict
> arises, it can be settled by reference to the docs. If the docs don't
> speak to the issue at hand, then the point can be discussed and the
> resolution added to the docs.
>
> Issues and mailing list threads from years ago (and even if it's
> current today, it will be years ago soon) are not sufficient. Relying
> on this has helped us into the morass we're in now in multiple areas,
> not just logging.
>
> On Mon, Jan 25, 2021 at 5:38 PM Matthieu Brouillard
>  wrote:
> >
> > is MNG-7085 [1] suited for that ?
> > Or do you propose that another (or existing) design document is written
> > first covering all the logging use-cases ?
> >
> > [1]: https://issues.apache.org/jira/browse/MNG-7085
> >
> > On Mon, Jan 25, 2021 at 6:12 PM Elliotte Rusty Harold 
> > wrote:
> >
> > > It would really help to have a complete, up-to-date design doc for
> > > Maven logging first, as well as clearing lout obsolete docs. Absent
> > > that there's a lot of crosstalk and conflicting updates across
> > > projects. It's not obvious everyone understands the same consensus.
> > >
> > > On Mon, Jan 25, 2021 at 3:45 PM Matthieu Brouillard
> > >  wrote:
> > > >
> > > > Issues MNG-7082 ,
> > > MNG-7083
> > > > , MNG-7084
> > > >  and MNG-7085
> > > >  created for
> > > traceability.
> > > >
> > > > I'll push PRs for the first two.
> > > >
> > > > On Mon, Jan 25, 2021 at 11:57 AM Romain Manni-Bucau <
> > > rmannibu...@gmail.com>
> > > > wrote:
> > > >
> > > > > For me only 1 and 4 are "strictly required" but this plan works with
> > > the
> > > > > nice to have additions.
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau  |  Blog
> > > > >  | Old Blog
> > > > >  | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn  | Book
> > > > > <
> > > > >
> > > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >
> > > > >
> > > > >
> > > > > Le lun. 25 janv. 2021 à 11:51, Matthieu Brouillard <
> > > matth...@brouillard.fr
> > > > > >
> > > > > a écrit :
> > > > >
> > > > > > In order to go further on this topic, I'd like to create issues for
> > > each
> > > > > > discussed topic in this thread and probably start working on some:
> > > > > >
> > > > > > * issue-1: remove depreciation on
> > > 'org.apache.maven.plugin.logging.Log'
> > > > > > * issue-2: introduce lazy evaluation/message production for each
> > > level in
> > > > > > 'org.apache.maven.plugin.logging.Log'
> > > > > > * issue-3: enable injection of org.apache.maven.plugin.logging.Log
> > > > > >   + discuss further in the issue which implementation to inject
> > > > > where/when
> > > > > >   + document (where ?) usage for extensions & non mojo injectable
> > > classes
> > > > > > * issue-4: update 'https://maven.apache.org/maven-logging.html' (or
> > > > > > elsewhere ?) with latest recommandations
> > > > > >   + use #getLog() for mojos
> > > > > >   + use injection for other use cases
> > > > > >
> > > > > > If it is ok then I'll create those issues and start working on the 2
> > > > > first.
> > > > > > Once created people will be able to provide additional context or
> > > > > > information to each ticket.
> > > > > >
> > > > > > Matthieu
> > > > > >
> > > > > > On Mon, Jan 25, 2021 at 8:07 AM Guillaume Nodet 
> > > > > wrote:
> > > > > >
> > > > > > > +1 for giving the logging API a bit of love with Supplier
> > > > > and/or
> > > > > > > formatter-like api.
> > > > > > >
> > > > > > > Guillaume Nodet
> > > > > > >
> > > > > > > Le lun. 25 janv. 2021 à 07:41,

Re: Loging api in JSR-330 component

2021-01-25 Thread Elliotte Rusty Harold 
No, an issue is too easily forgotten. We should have something on the
main web site. It needs to be consistent with or replace:

https://maven.apache.org/maven-jsr330.html
https://maven.apache.org/maven-logging.html

In addition the API docs of the relevant libraries need to be updated.

Maven has a lot of technical debt, and a large part of that is both a
symptom and a cause of outdated, incomplete, and inconsistent
documentation. Long time committers routinely suggest contradictory
approaches as the way Maven does things. The only way I know to avoid
this is to have normative, maintained documentation of agreed
development practices that is in the source repo and published on the
web site. This helps flush out and resolve areas where different
committers believe different things to be true. When a conflict
arises, it can be settled by reference to the docs. If the docs don't
speak to the issue at hand, then the point can be discussed and the
resolution added to the docs.

Issues and mailing list threads from years ago (and even if it's
current today, it will be years ago soon) are not sufficient. Relying
on this has helped us into the morass we're in now in multiple areas,
not just logging.

On Mon, Jan 25, 2021 at 5:38 PM Matthieu Brouillard
 wrote:
>
> is MNG-7085 [1] suited for that ?
> Or do you propose that another (or existing) design document is written
> first covering all the logging use-cases ?
>
> [1]: https://issues.apache.org/jira/browse/MNG-7085
>
> On Mon, Jan 25, 2021 at 6:12 PM Elliotte Rusty Harold 
> wrote:
>
> > It would really help to have a complete, up-to-date design doc for
> > Maven logging first, as well as clearing lout obsolete docs. Absent
> > that there's a lot of crosstalk and conflicting updates across
> > projects. It's not obvious everyone understands the same consensus.
> >
> > On Mon, Jan 25, 2021 at 3:45 PM Matthieu Brouillard
> >  wrote:
> > >
> > > Issues MNG-7082 ,
> > MNG-7083
> > > , MNG-7084
> > >  and MNG-7085
> > >  created for
> > traceability.
> > >
> > > I'll push PRs for the first two.
> > >
> > > On Mon, Jan 25, 2021 at 11:57 AM Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > > wrote:
> > >
> > > > For me only 1 and 4 are "strictly required" but this plan works with
> > the
> > > > nice to have additions.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau  |  Blog
> > > >  | Old Blog
> > > >  | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn  | Book
> > > > <
> > > >
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > > >
> > > > Le lun. 25 janv. 2021 à 11:51, Matthieu Brouillard <
> > matth...@brouillard.fr
> > > > >
> > > > a écrit :
> > > >
> > > > > In order to go further on this topic, I'd like to create issues for
> > each
> > > > > discussed topic in this thread and probably start working on some:
> > > > >
> > > > > * issue-1: remove depreciation on
> > 'org.apache.maven.plugin.logging.Log'
> > > > > * issue-2: introduce lazy evaluation/message production for each
> > level in
> > > > > 'org.apache.maven.plugin.logging.Log'
> > > > > * issue-3: enable injection of org.apache.maven.plugin.logging.Log
> > > > >   + discuss further in the issue which implementation to inject
> > > > where/when
> > > > >   + document (where ?) usage for extensions & non mojo injectable
> > classes
> > > > > * issue-4: update 'https://maven.apache.org/maven-logging.html' (or
> > > > > elsewhere ?) with latest recommandations
> > > > >   + use #getLog() for mojos
> > > > >   + use injection for other use cases
> > > > >
> > > > > If it is ok then I'll create those issues and start working on the 2
> > > > first.
> > > > > Once created people will be able to provide additional context or
> > > > > information to each ticket.
> > > > >
> > > > > Matthieu
> > > > >
> > > > > On Mon, Jan 25, 2021 at 8:07 AM Guillaume Nodet 
> > > > wrote:
> > > > >
> > > > > > +1 for giving the logging API a bit of love with Supplier
> > > > and/or
> > > > > > formatter-like api.
> > > > > >
> > > > > > Guillaume Nodet
> > > > > >
> > > > > > Le lun. 25 janv. 2021 à 07:41, Mark Struberg
> >  > > > >
> > > > > a
> > > > > > écrit :
> > > > > >
> > > > > > >  +1Technically from a pure ClassLoader point our very own makes
> > more
> > > > > > > sense.We can probably think about Lambda to resolve the String
> > > > > > > lazily.Insofar the SLF4J api is outdated as well.
> > > > > > > And of course internally we might still route to slf4j. But we
> > should
> > > > > not
> > > > > > > expose those classes to the plugins if not necessary. They just
> > > > > > > unnecessarily create

Re: Loging api in JSR-330 component

2021-01-25 Thread Matthieu Brouillard 
is MNG-7085 [1] suited for that ?
Or do you propose that another (or existing) design document is written
first covering all the logging use-cases ?

[1]: https://issues.apache.org/jira/browse/MNG-7085

On Mon, Jan 25, 2021 at 6:12 PM Elliotte Rusty Harold 
wrote:

> It would really help to have a complete, up-to-date design doc for
> Maven logging first, as well as clearing lout obsolete docs. Absent
> that there's a lot of crosstalk and conflicting updates across
> projects. It's not obvious everyone understands the same consensus.
>
> On Mon, Jan 25, 2021 at 3:45 PM Matthieu Brouillard
>  wrote:
> >
> > Issues MNG-7082 ,
> MNG-7083
> > , MNG-7084
> >  and MNG-7085
> >  created for
> traceability.
> >
> > I'll push PRs for the first two.
> >
> > On Mon, Jan 25, 2021 at 11:57 AM Romain Manni-Bucau <
> rmannibu...@gmail.com>
> > wrote:
> >
> > > For me only 1 and 4 are "strictly required" but this plan works with
> the
> > > nice to have additions.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le lun. 25 janv. 2021 à 11:51, Matthieu Brouillard <
> matth...@brouillard.fr
> > > >
> > > a écrit :
> > >
> > > > In order to go further on this topic, I'd like to create issues for
> each
> > > > discussed topic in this thread and probably start working on some:
> > > >
> > > > * issue-1: remove depreciation on
> 'org.apache.maven.plugin.logging.Log'
> > > > * issue-2: introduce lazy evaluation/message production for each
> level in
> > > > 'org.apache.maven.plugin.logging.Log'
> > > > * issue-3: enable injection of org.apache.maven.plugin.logging.Log
> > > >   + discuss further in the issue which implementation to inject
> > > where/when
> > > >   + document (where ?) usage for extensions & non mojo injectable
> classes
> > > > * issue-4: update 'https://maven.apache.org/maven-logging.html' (or
> > > > elsewhere ?) with latest recommandations
> > > >   + use #getLog() for mojos
> > > >   + use injection for other use cases
> > > >
> > > > If it is ok then I'll create those issues and start working on the 2
> > > first.
> > > > Once created people will be able to provide additional context or
> > > > information to each ticket.
> > > >
> > > > Matthieu
> > > >
> > > > On Mon, Jan 25, 2021 at 8:07 AM Guillaume Nodet 
> > > wrote:
> > > >
> > > > > +1 for giving the logging API a bit of love with Supplier
> > > and/or
> > > > > formatter-like api.
> > > > >
> > > > > Guillaume Nodet
> > > > >
> > > > > Le lun. 25 janv. 2021 à 07:41, Mark Struberg
>  > > >
> > > > a
> > > > > écrit :
> > > > >
> > > > > >  +1Technically from a pure ClassLoader point our very own makes
> more
> > > > > > sense.We can probably think about Lambda to resolve the String
> > > > > > lazily.Insofar the SLF4J api is outdated as well.
> > > > > > And of course internally we might still route to slf4j. But we
> should
> > > > not
> > > > > > expose those classes to the plugins if not necessary. They just
> > > > > > unnecessarily create classpatch clashes some times (been there
> done
> > > > > that).
> > > > > >
> > > > > > LieGrue,strub
> > > > > >
> > > > > > On Saturday, 23 January 2021, 18:06:34 CET, Romain
> Manni-Bucau <
> > > > > > rmannibu...@gmail.com> wrote:
> > > > > >
> > > > > >  Hi Benjamin,
> > > > > >
> > > > > > Guess it was unexpectedly deprecated, let's revert that on
> master.
> > > > > >
> > > > > > Romain Manni-Bucau
> > > > > > @rmannibucau  |  Blog
> > > > > >  | Old Blog
> > > > > >  | Github <
> > > > > > https://github.com/rmannibucau> |
> > > > > > LinkedIn  | Book
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > >
> > > > > >
> > > > > >
> > > > > > Le sam. 23 janv. 2021 à 17:58, Benjamin Marwell <
> bmarw...@apache.org
> > > >
> > > > a
> > > > > > écrit :
> > > > > >
> > > > > > > Robert, that's deprecated! What to use instead? Or was it
> > > deprecated
> > > > in
> > > > > > > error?
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> https://github.com/apache/maven/blob/master/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Sat, 23 Jan 2021, 12:10 Robert Scholte, <
>

Re: Loging api in JSR-330 component

2021-01-25 Thread Elliotte Rusty Harold 
It would really help to have a complete, up-to-date design doc for
Maven logging first, as well as clearing lout obsolete docs. Absent
that there's a lot of crosstalk and conflicting updates across
projects. It's not obvious everyone understands the same consensus.

On Mon, Jan 25, 2021 at 3:45 PM Matthieu Brouillard
 wrote:
>
> Issues MNG-7082 , MNG-7083
> , MNG-7084
>  and MNG-7085
>  created for traceability.
>
> I'll push PRs for the first two.
>
> On Mon, Jan 25, 2021 at 11:57 AM Romain Manni-Bucau 
> wrote:
>
> > For me only 1 and 4 are "strictly required" but this plan works with the
> > nice to have additions.
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le lun. 25 janv. 2021 à 11:51, Matthieu Brouillard  > >
> > a écrit :
> >
> > > In order to go further on this topic, I'd like to create issues for each
> > > discussed topic in this thread and probably start working on some:
> > >
> > > * issue-1: remove depreciation on 'org.apache.maven.plugin.logging.Log'
> > > * issue-2: introduce lazy evaluation/message production for each level in
> > > 'org.apache.maven.plugin.logging.Log'
> > > * issue-3: enable injection of org.apache.maven.plugin.logging.Log
> > >   + discuss further in the issue which implementation to inject
> > where/when
> > >   + document (where ?) usage for extensions & non mojo injectable classes
> > > * issue-4: update 'https://maven.apache.org/maven-logging.html' (or
> > > elsewhere ?) with latest recommandations
> > >   + use #getLog() for mojos
> > >   + use injection for other use cases
> > >
> > > If it is ok then I'll create those issues and start working on the 2
> > first.
> > > Once created people will be able to provide additional context or
> > > information to each ticket.
> > >
> > > Matthieu
> > >
> > > On Mon, Jan 25, 2021 at 8:07 AM Guillaume Nodet 
> > wrote:
> > >
> > > > +1 for giving the logging API a bit of love with Supplier
> > and/or
> > > > formatter-like api.
> > > >
> > > > Guillaume Nodet
> > > >
> > > > Le lun. 25 janv. 2021 à 07:41, Mark Struberg  > >
> > > a
> > > > écrit :
> > > >
> > > > >  +1Technically from a pure ClassLoader point our very own makes more
> > > > > sense.We can probably think about Lambda to resolve the String
> > > > > lazily.Insofar the SLF4J api is outdated as well.
> > > > > And of course internally we might still route to slf4j. But we should
> > > not
> > > > > expose those classes to the plugins if not necessary. They just
> > > > > unnecessarily create classpatch clashes some times (been there done
> > > > that).
> > > > >
> > > > > LieGrue,strub
> > > > >
> > > > > On Saturday, 23 January 2021, 18:06:34 CET, Romain Manni-Bucau <
> > > > > rmannibu...@gmail.com> wrote:
> > > > >
> > > > >  Hi Benjamin,
> > > > >
> > > > > Guess it was unexpectedly deprecated, let's revert that on master.
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau  |  Blog
> > > > >  | Old Blog
> > > > >  | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn  | Book
> > > > > <
> > > > >
> > > >
> > >
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >
> > > > >
> > > > >
> > > > > Le sam. 23 janv. 2021 à 17:58, Benjamin Marwell  > >
> > > a
> > > > > écrit :
> > > > >
> > > > > > Robert, that's deprecated! What to use instead? Or was it
> > deprecated
> > > in
> > > > > > error?
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://github.com/apache/maven/blob/master/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Sat, 23 Jan 2021, 12:10 Robert Scholte, 
> > > > wrote:
> > > > > >
> > > > > > > See
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://maven.apache.org/ref/3.6.3/maven-plugin-api/apidocs/org/apache/maven/plugin/AbstractMojo.html
> > > > > > >
> > > > > > > You can get the logger by calling getLog(), so don't inject the
> > > > logger
> > > > > > > here.
> > > > > > >
> > > > > > > Robert
> > > > > > > On 22-1-2021 19:19:47, Slawomir Jaranowski <
> > s.jaranow...@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > It is not only an extension case.
> > > > > > >
> > > > > > > For example I can write Mojo like:
> > > > > > >
> > > > > > > @Mojo(name =

Re: Loging api in JSR-330 component

2021-01-25 Thread Matthieu Brouillard 
Issues MNG-7082 , MNG-7083
, MNG-7084
 and MNG-7085
 created for traceability.

I'll push PRs for the first two.

On Mon, Jan 25, 2021 at 11:57 AM Romain Manni-Bucau 
wrote:

> For me only 1 and 4 are "strictly required" but this plan works with the
> nice to have additions.
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 25 janv. 2021 à 11:51, Matthieu Brouillard  >
> a écrit :
>
> > In order to go further on this topic, I'd like to create issues for each
> > discussed topic in this thread and probably start working on some:
> >
> > * issue-1: remove depreciation on 'org.apache.maven.plugin.logging.Log'
> > * issue-2: introduce lazy evaluation/message production for each level in
> > 'org.apache.maven.plugin.logging.Log'
> > * issue-3: enable injection of org.apache.maven.plugin.logging.Log
> >   + discuss further in the issue which implementation to inject
> where/when
> >   + document (where ?) usage for extensions & non mojo injectable classes
> > * issue-4: update 'https://maven.apache.org/maven-logging.html' (or
> > elsewhere ?) with latest recommandations
> >   + use #getLog() for mojos
> >   + use injection for other use cases
> >
> > If it is ok then I'll create those issues and start working on the 2
> first.
> > Once created people will be able to provide additional context or
> > information to each ticket.
> >
> > Matthieu
> >
> > On Mon, Jan 25, 2021 at 8:07 AM Guillaume Nodet 
> wrote:
> >
> > > +1 for giving the logging API a bit of love with Supplier
> and/or
> > > formatter-like api.
> > >
> > > Guillaume Nodet
> > >
> > > Le lun. 25 janv. 2021 à 07:41, Mark Struberg  >
> > a
> > > écrit :
> > >
> > > >  +1Technically from a pure ClassLoader point our very own makes more
> > > > sense.We can probably think about Lambda to resolve the String
> > > > lazily.Insofar the SLF4J api is outdated as well.
> > > > And of course internally we might still route to slf4j. But we should
> > not
> > > > expose those classes to the plugins if not necessary. They just
> > > > unnecessarily create classpatch clashes some times (been there done
> > > that).
> > > >
> > > > LieGrue,strub
> > > >
> > > > On Saturday, 23 January 2021, 18:06:34 CET, Romain Manni-Bucau <
> > > > rmannibu...@gmail.com> wrote:
> > > >
> > > >  Hi Benjamin,
> > > >
> > > > Guess it was unexpectedly deprecated, let's revert that on master.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau  |  Blog
> > > >  | Old Blog
> > > >  | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn  | Book
> > > > <
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > > >
> > > > Le sam. 23 janv. 2021 à 17:58, Benjamin Marwell  >
> > a
> > > > écrit :
> > > >
> > > > > Robert, that's deprecated! What to use instead? Or was it
> deprecated
> > in
> > > > > error?
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven/blob/master/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Sat, 23 Jan 2021, 12:10 Robert Scholte, 
> > > wrote:
> > > > >
> > > > > > See
> > > > > >
> > > > >
> > > >
> > >
> >
> https://maven.apache.org/ref/3.6.3/maven-plugin-api/apidocs/org/apache/maven/plugin/AbstractMojo.html
> > > > > >
> > > > > > You can get the logger by calling getLog(), so don't inject the
> > > logger
> > > > > > here.
> > > > > >
> > > > > > Robert
> > > > > > On 22-1-2021 19:19:47, Slawomir Jaranowski <
> s.jaranow...@gmail.com
> > >
> > > > > wrote:
> > > > > > It is not only an extension case.
> > > > > >
> > > > > > For example I can write Mojo like:
> > > > > >
> > > > > > @Mojo(name = "example")
> > > > > > public class ExampleMojo extends AbstractMojo {
> > > > > >
> > > > > > @Inject
> > > > > > private MyService myService;
> > > > > >
> > > > > > @Override
> > > > > > public void execute() {
> > > > > > }
> > > > > > }
> > > > > >
> > > > > > and
> > > > > >
> > > > > > @Named
> > > > > > public class MyService {
> > > > > >
> > > > > > @Inject
> > > > > > private Logger??? logger;
> > > > > > }
> > > > > >
> > > > > > So the question is what logger we should use in the component?
> > > > > >
> > > > > > Another case is that components can be Singleton and their
> instance
> > > > will
> >

Re: Loging api in JSR-330 component

2021-01-25 Thread Romain Manni-Bucau 
For me only 1 and 4 are "strictly required" but this plan works with the
nice to have additions.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 25 janv. 2021 à 11:51, Matthieu Brouillard 
a écrit :

> In order to go further on this topic, I'd like to create issues for each
> discussed topic in this thread and probably start working on some:
>
> * issue-1: remove depreciation on 'org.apache.maven.plugin.logging.Log'
> * issue-2: introduce lazy evaluation/message production for each level in
> 'org.apache.maven.plugin.logging.Log'
> * issue-3: enable injection of org.apache.maven.plugin.logging.Log
>   + discuss further in the issue which implementation to inject where/when
>   + document (where ?) usage for extensions & non mojo injectable classes
> * issue-4: update 'https://maven.apache.org/maven-logging.html' (or
> elsewhere ?) with latest recommandations
>   + use #getLog() for mojos
>   + use injection for other use cases
>
> If it is ok then I'll create those issues and start working on the 2 first.
> Once created people will be able to provide additional context or
> information to each ticket.
>
> Matthieu
>
> On Mon, Jan 25, 2021 at 8:07 AM Guillaume Nodet  wrote:
>
> > +1 for giving the logging API a bit of love with Supplier and/or
> > formatter-like api.
> >
> > Guillaume Nodet
> >
> > Le lun. 25 janv. 2021 à 07:41, Mark Struberg 
> a
> > écrit :
> >
> > >  +1Technically from a pure ClassLoader point our very own makes more
> > > sense.We can probably think about Lambda to resolve the String
> > > lazily.Insofar the SLF4J api is outdated as well.
> > > And of course internally we might still route to slf4j. But we should
> not
> > > expose those classes to the plugins if not necessary. They just
> > > unnecessarily create classpatch clashes some times (been there done
> > that).
> > >
> > > LieGrue,strub
> > >
> > > On Saturday, 23 January 2021, 18:06:34 CET, Romain Manni-Bucau <
> > > rmannibu...@gmail.com> wrote:
> > >
> > >  Hi Benjamin,
> > >
> > > Guess it was unexpectedly deprecated, let's revert that on master.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le sam. 23 janv. 2021 à 17:58, Benjamin Marwell 
> a
> > > écrit :
> > >
> > > > Robert, that's deprecated! What to use instead? Or was it deprecated
> in
> > > > error?
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/maven/blob/master/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On Sat, 23 Jan 2021, 12:10 Robert Scholte, 
> > wrote:
> > > >
> > > > > See
> > > > >
> > > >
> > >
> >
> https://maven.apache.org/ref/3.6.3/maven-plugin-api/apidocs/org/apache/maven/plugin/AbstractMojo.html
> > > > >
> > > > > You can get the logger by calling getLog(), so don't inject the
> > logger
> > > > > here.
> > > > >
> > > > > Robert
> > > > > On 22-1-2021 19:19:47, Slawomir Jaranowski  >
> > > > wrote:
> > > > > It is not only an extension case.
> > > > >
> > > > > For example I can write Mojo like:
> > > > >
> > > > > @Mojo(name = "example")
> > > > > public class ExampleMojo extends AbstractMojo {
> > > > >
> > > > > @Inject
> > > > > private MyService myService;
> > > > >
> > > > > @Override
> > > > > public void execute() {
> > > > > }
> > > > > }
> > > > >
> > > > > and
> > > > >
> > > > > @Named
> > > > > public class MyService {
> > > > >
> > > > > @Inject
> > > > > private Logger??? logger;
> > > > > }
> > > > >
> > > > > So the question is what logger we should use in the component?
> > > > >
> > > > > Another case is that components can be Singleton and their instance
> > > will
> > > > be
> > > > > created once.
> > > > >
> > > > >
> > > > > pt., 22 sty 2021 o 12:36 Romain Manni-Bucau
> > > > > napisał(a):
> > > > >
> > > > > > Do it means if we represent our classloading structure, all
> loaders
> > > on
> > > > > top
> > > > > > of mojo use slf4j and others our maven abstraction.
> > > > > > Sounds ok to me except for extensions which are not in maven land
> > so
> > > > > > subject to slf4j api breaking changes and undefined/ambiguous
> > > context -
> > > > > > which is never true for maven code itself since we guarantee and
> > own
> > > > it.
> > > > > > Should we promote the abstraction for extensions too?
> > > > > >
> > > > > > Le ven. 22 janv. 2021 à 11:41, Robert

Re: Loging api in JSR-330 component

2021-01-25 Thread Matthieu Brouillard 
In order to go further on this topic, I'd like to create issues for each
discussed topic in this thread and probably start working on some:

* issue-1: remove depreciation on 'org.apache.maven.plugin.logging.Log'
* issue-2: introduce lazy evaluation/message production for each level in
'org.apache.maven.plugin.logging.Log'
* issue-3: enable injection of org.apache.maven.plugin.logging.Log
  + discuss further in the issue which implementation to inject where/when
  + document (where ?) usage for extensions & non mojo injectable classes
* issue-4: update 'https://maven.apache.org/maven-logging.html' (or
elsewhere ?) with latest recommandations
  + use #getLog() for mojos
  + use injection for other use cases

If it is ok then I'll create those issues and start working on the 2 first.
Once created people will be able to provide additional context or
information to each ticket.

Matthieu

On Mon, Jan 25, 2021 at 8:07 AM Guillaume Nodet  wrote:

> +1 for giving the logging API a bit of love with Supplier and/or
> formatter-like api.
>
> Guillaume Nodet
>
> Le lun. 25 janv. 2021 à 07:41, Mark Struberg  a
> écrit :
>
> >  +1Technically from a pure ClassLoader point our very own makes more
> > sense.We can probably think about Lambda to resolve the String
> > lazily.Insofar the SLF4J api is outdated as well.
> > And of course internally we might still route to slf4j. But we should not
> > expose those classes to the plugins if not necessary. They just
> > unnecessarily create classpatch clashes some times (been there done
> that).
> >
> > LieGrue,strub
> >
> > On Saturday, 23 January 2021, 18:06:34 CET, Romain Manni-Bucau <
> > rmannibu...@gmail.com> wrote:
> >
> >  Hi Benjamin,
> >
> > Guess it was unexpectedly deprecated, let's revert that on master.
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le sam. 23 janv. 2021 à 17:58, Benjamin Marwell  a
> > écrit :
> >
> > > Robert, that's deprecated! What to use instead? Or was it deprecated in
> > > error?
> > >
> > >
> > >
> >
> https://github.com/apache/maven/blob/master/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Sat, 23 Jan 2021, 12:10 Robert Scholte, 
> wrote:
> > >
> > > > See
> > > >
> > >
> >
> https://maven.apache.org/ref/3.6.3/maven-plugin-api/apidocs/org/apache/maven/plugin/AbstractMojo.html
> > > >
> > > > You can get the logger by calling getLog(), so don't inject the
> logger
> > > > here.
> > > >
> > > > Robert
> > > > On 22-1-2021 19:19:47, Slawomir Jaranowski 
> > > wrote:
> > > > It is not only an extension case.
> > > >
> > > > For example I can write Mojo like:
> > > >
> > > > @Mojo(name = "example")
> > > > public class ExampleMojo extends AbstractMojo {
> > > >
> > > > @Inject
> > > > private MyService myService;
> > > >
> > > > @Override
> > > > public void execute() {
> > > > }
> > > > }
> > > >
> > > > and
> > > >
> > > > @Named
> > > > public class MyService {
> > > >
> > > > @Inject
> > > > private Logger??? logger;
> > > > }
> > > >
> > > > So the question is what logger we should use in the component?
> > > >
> > > > Another case is that components can be Singleton and their instance
> > will
> > > be
> > > > created once.
> > > >
> > > >
> > > > pt., 22 sty 2021 o 12:36 Romain Manni-Bucau
> > > > napisał(a):
> > > >
> > > > > Do it means if we represent our classloading structure, all loaders
> > on
> > > > top
> > > > > of mojo use slf4j and others our maven abstraction.
> > > > > Sounds ok to me except for extensions which are not in maven land
> so
> > > > > subject to slf4j api breaking changes and undefined/ambiguous
> > context -
> > > > > which is never true for maven code itself since we guarantee and
> own
> > > it.
> > > > > Should we promote the abstraction for extensions too?
> > > > >
> > > > > Le ven. 22 janv. 2021 à 11:41, Robert Scholte a
> > > > > écrit :
> > > > >
> > > > > > I'm not so sure about this, it probably depends on the context.
> > > > > >
> > > > > > I think we should assume that JSR330 component are not aware of
> > their
> > > > > > context.
> > > > > > They should not require a Maven context, hence in such case it
> > makes
> > > > > sense
> > > > > > to use SLF4J API, while the application selects the logger
> > > > > implementation.
> > > > > > Think of Maven Extensions. I'd say they should be using the SLF4J
> > API
> > > > > > because their context is not bound to 1 plugin.
> > > > > >
> > > > > > thanks,
> > > > > > Robert
> > > > > > On 18-1-2021 09:34:01, Romain Manni-Bucau wrote:
> > > > > > Generally you want to propagate the mojo logger to have
> consistent
> > > logs
> > > > >