[GitHub] [maven-gh-actions-shared] olamy merged pull request #14: Update example in readme with v1 branch
olamy merged pull request #14: URL: https://github.com/apache/maven-gh-actions-shared/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-gh-actions-shared] olamy merged pull request #11: Rename workflow to maven-verify
olamy merged pull request #11: URL: https://github.com/apache/maven-gh-actions-shared/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-gh-actions-shared] olamy merged pull request #12: Remove release-drafetr from branch v1
olamy merged pull request #12: URL: https://github.com/apache/maven-gh-actions-shared/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-gh-actions-shared] olamy merged pull request #13: Release drafter - add v* branches
olamy merged pull request #13: URL: https://github.com/apache/maven-gh-actions-shared/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on a change in pull request #2: unpack wrapper distribution
hboutemy commented on a change in pull request #2:
URL: https://github.com/apache/maven-wrapper-plugin/pull/2#discussion_r735968181
##
File path: src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java
##
@@ -128,7 +128,7 @@ public void execute() throws MojoExecutionException,
MojoFailureException
Artifact artifact;
try
{
-artifact = downloadWrapper( wrapperVersion );
+artifact = downloadWrapperDitribution( wrapperVersion );
Review comment:
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704 I completely value the work done to sync mvn and mvnw: syncing again is just about copying the 6 partial scripts to `maven-wrapper-distribution/src/assembly/maven/`. on releasing, there is only 1 simultaneous release for the 3 artifacts: wrapper, wrapper distribution and wrapper-plugin = the full wrapper, clearly separate from the Maven distribution. It is really simple and logical. And there won't be many releases in the future, because everything is independant from Maven version. with the latest commits, the new wrapper is working well with whatever Maven version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704 I completely value the work done to sync mvn and mvnw: syncing is just about copying the 6 partial scripts. on releasing, there is only 1 simultaneous release for the 3 artifacts: wrapper, wrapper distribution and wrapper-plugin = the full wrapper, clearly separate from the Maven distribution. It is really simple and logical. And there won't be many releases in the future, because everything is independant from Maven version. with the latest commits, the new wrapper is working well with whatever Maven version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704 I completely value the work done to sync mvn and mvnw: syncing is just about copying the 6 partial scripts. on releasing, there is only 1 simultaneous release for the 3 artifacts: wrapper, wrapper distribution and wrapper-plugin = the full wrapper, clearly separate from the Maven distribution. It is really simple and logical. with the latest commits, the new wrapper is working well with whatever Maven version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] first step at putting all wrapper pieces in one build
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951204672 I'm not convinced this is the right thing to do. If you compare the original mvn and mvnw script when it was donated, you should have noticed that they both went their own way. It took me quite some time to get them in sync and to pick the best of both. By splitting it up it will happen again. Maybe you should wait with this AFTER MNG-7073 so Maven contains a script template that can be reused here. Moving the wrapper to here, does that mean that this plugin must be released every time is released too, like the takari plugin used to do? Then we've lost the benefit of the current setup, because most likely the plugin now doesn't require new releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #2: unpack wrapper distribution
rfscholte commented on a change in pull request #2:
URL: https://github.com/apache/maven-wrapper-plugin/pull/2#discussion_r735855180
##
File path: src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java
##
@@ -128,7 +128,7 @@ public void execute() throws MojoExecutionException,
MojoFailureException
Artifact artifact;
try
{
-artifact = downloadWrapper( wrapperVersion );
+artifact = downloadWrapperDitribution( wrapperVersion );
Review comment:
typo, misses an S
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy opened a new pull request #1: [MWRAPPER-14] first step at putting all wrapper pieces in one build
hboutemy opened a new pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1 Wrapper consists in 3 pieces: - wrapper (maven-wrapper.jar) - wrapper distribution (mvnw scripts) - wrapper plugin that should have the same version = "the wrapper version" the wrapper plugin will unpack wrapper distribution with the same version as the plugin the only drawback vs releasing wrapper and wrapper distribution in the Apache Maven core release is that partial mvn scripts (3 shell and 3 cmd) are copied but in terms of versions clarity, seems much easier to understand: wrapper is something, Maven is something notice that this is a WIP: I did not yet review maven-wrapper-plugin logic to select the distribution version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Upcoming Maven 3.8.4
We're in an awkward situation. It looks like that of all the 3.8.x releases, the first (3.8.1) is the most stable one. The subtitle of Maven 3.8.2 was "Fixes and non-invasive backports from Maven 4.0.0-alpha-1." Looking back it looks like the backports weren't that non-invasive, and we have unintended regressions on both 3.8.2 and 3.8.3 compared to 3.6.3 As you might know we do our (plugin) tests with every latest 3.x-release, because most assume that should be the most stable one. Hence we need to have a 3.8.4 with either fixes or reverts before thinking of any other release. thanks, Robert -- Origineel bericht -- Van: "Gary Gregory" Aan: "Maven Developers List" CC: "Rob Tompkins" Verzonden: 24-10-2021 12:03:59 Onderwerp: Re: Upcoming Maven 3.8.4 That's the normal release process for any project AFAIK, if you want to put a release candidate out to on https://dist.apache.org/repos/dist/dev/ that is done via svn, we've automated those steps. Then the actual release goes to https://dist.apache.org/repos/dist/release/, same for Maven https://dist.apache.org/repos/dist/release/maven/ After that, the files are mirrored all over by various servers. Publishing to Maven Central is a separate process but critical since that is what most builds (Maven, Ant Ivy, and so on) expect and use. Gary On Sun, Oct 24, 2021, 05:27 Slawomir Jaranowski wrote: Hi, Very strange release process for common components ... some of the artifacts are published to the Central Repository and some of them are published by svn repository ... I don't see benefit for customizing maven core for one of case of usage but it is discussion for another place, here I only point it sob., 23 paź 2021 o 22:51 Gary Gregory napisał(a): > HI All: > > I discovered a regression this morning that prevents me from creating > a release candidate for Apache Commons CLI: > > https://issues.apache.org/jira/browse/MNG-7316 > https://github.com/apache/maven/pull/601 > > May this be included for 3.8.4 please? > > Gary > > On Sat, Oct 23, 2021 at 3:48 PM Falko Modler wrote: > > > > Hi, > > > > > Given that we had two releases with regressions I tend *not* to merge > > > #578. Give it more time and thought. > > > > As written before on GH, not merging #578 or a backport of #476 will > > bring back MNG-6843. > > This will catch users off guard that were happily benefitting from > > MNG-6843 being fixed in 3.8.2 and 3.8.3. > > > > If you still want to do it this way, then please at least document that > > MNG-6843 is back under "Known Issues" in 3.8.4 "Release Notes". > > Additionally, MNG-6843 should be reopened. > > > > I'd really prefer if we could keep MNG-6843 fixed, by whichever PR > > (doesn't need to be mine). > > > > Cheers, > > > > Falko > > > > Am 23.10.2021 um 21:22 schrieb Michael Osipov: > > > Folks, > > > > > > all important tickets for Maven 3.8.4 have been addressed in > > > maven-3.8.x branch. > > > > > > We have two open PRs: > > > * #578: Alternative to the ThreadLocal approach > > > * #476: As far as I understand a more global approach to the issue and > > > supersedes #576, but requires Java 8. So Maven 3.9+ > > > > > > Given that we had two releases with regressions I tend *not* to merge > > > #578. Give it more time and thought. Maybe go over to #476 directly in > > > 3.9.0 and 4.0.0. > > > > > > Please test and let me know whether you still see errors. If I don't > > > read any objections I will start the new release somewhere around mid > > > next week. > > > > > > Michael > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sławomir Jaranowski - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
