date:20220103

Re: [DISCUSS] Move maven caching to an external repository

2022-01-03 Thread Guillaume Nodet

I'd go for #2 ...

Le mar. 4 janv. 2022 à 00:14, Hervé BOUTEMY  a
écrit :

> yes, I was happy to learn about that shallow + filter approach :)
>
> now, we have one choice to do:
> 1. keep the shallow repository
> or
> 2. keep a strongly filtered repository done from the shallow
>
> option 2 gives a smaller Git repository (0.8 MB vs 3.77 MB), but old
> commits
> cannot be built (because filtering removed many files)
> option 1 maintains every commit as buildable as when it was in maven.git
>
> Which option do you choose?
>
> nce you choose, if nobody objects, I'll create
> maven-build-cache-extension.git
> with the content...
>
> Regards,
>
> Hervé
>
> Le lundi 3 janvier 2022, 15:15:02 CET Guillaume Nodet a écrit :
> > Awesome ! I didn't know about the shallow options during clone.
> > This looks good to me !
> >
> > Guillaume
> >
> > Le ven. 24 déc. 2021 à 00:14, Hervé BOUTEMY  a
> >
> > écrit :
> > > short version:
> > > I think I managed to extract exactly what we wanted:
> > >
> https://github.com/hboutemy/maven-build-cache-extension-shallow-filtered
> > > please review and confirm the result is ok
> > >
> > >
> > > longer version: how was it done?
> > > the first recipe I found is to drop old history:
> > >
> > > git clone https://github.com/hboutemy/maven-build-cache-extension.git
> > > shallow --shallow-since=2021-10-18
> > > cd shallow
> > > git filter-branch -- --all
> > >
> > > you can see the intermediate result in
> > > https://github.com/hboutemy/maven-build-cache-extension-shallow
> > >
> > > then I just filtered with "git filter-repo" to remove globally many
> files
> > > that were removed in
> > >
> https://github.com/hboutemy/maven-build-cache-extension-shallow/commit/a32
> > > 3d9859f091cdd8a2b946c71d12228ec29b70c
> > >
> > >
> > > Regards,
> > >
> > > Hervé
> > >
> > > Le dimanche 19 décembre 2021, 22:56:56 CET Hervé BOUTEMY a écrit :
> > > > I've tried to use git filter-repo, excluding unwanted directories or
> > > > extensions
> > > >
> > > > here is a sample result:
> > > > https://github.com/hboutemy/maven-build-cache-extension-filtered
> > > > = 4200 commits
> > > >
> > > > instead of initial 11700
> > > > https://github.com/hboutemy/maven-build-cache-extension
> > > >
> > > > we can still improve the list of directories to exclude
> > > >
> > > > before taking time for that, I need feedback: what do you think about
> > >
> > > this
> > >
> > > > approach?
> > > >
> > > > Regards,
> > > >
> > > > Hervé
> > > >
> > > > Le vendredi 17 décembre 2021, 11:47:25 CET Guillaume Nodet a écrit :
> > > > > I've tried various things without any good results.
> > > > > Given there's not much history to preserve here, I'd go ahead and
> just
> > > > > create a new repo with the current contents of the branch.
> > > > > Any objections?
> > > > >
> > > > > Le dim. 12 déc. 2021 à 15:43, Jeff Jensen
> > > > > 
> > > > >
> > > > > a écrit :
> > > > > > I've split git repos before and using filter-branch is the key to
> > >
> > > keep
> > >
> > > > > > the
> > > > > > desired and purge the rest.
> > > > > >
> > > > > > From my notes, these two posts helped me:
> > > > > > *
> > >
> > >
> https://docs.github.com/en/get-started/using-git/splitting-a-subfolder-o
> > >
> > > > > > ut
> > > > > > -into-a-new-repository *
> > >
> > >
> https://support.atlassian.com/bitbucket-cloud/docs/split-a-repository-in
> > >
> > > > > > -t
> > > > > > wo/
> > > > > >
> > > > > > These are my shortcut notes for doing so, hope they are clear
> enough
> > >
> > > for
> > >
> > > > > > you and help. In a new repo, locally convert a current source
> > > > > > subdirectory
> > > > > > to the root directory and purge everything else; then push to
> remote
> > >
> > > and
> > >
> > > > > > locally cleanup:
> > > > > >1.
> > > > > >
> > > > > >Make directory for new repo from current repo:
> > > > > > git clone current-repo to-new-directory
> > > > > >
> > > > > >1.
> > > > > >
> > > > > >Disconnect from current remote immediately to prevent
> catastrophe
> > >
> > > and
> > >
> > > > > >verify none set
> > > > > >
> > > > > > git remote rm origin
> > > > > >
> > > > > > git remote -v
> > > > > >
> > > > > >1.
> > > > > >
> > > > > >Keep desired dir and move it to top level, remove the rest
> > > > > >1.
> > > > > >
> > > > > >   FOLDER-NAME: which one to keep and move to top level
> > > > > >   2.
> > > > > >
> > > > > >   BRANCH-NAME: which branch to do this on (must exist, e.g.
> > >
> > > master)
> > >
> > > > > > git filter-branch --prune-empty --subdirectory-filter FOLDER-NAME
> > > > > > BRANCH-NAME
> > > > > >
> > > > > >1.
> > > > > >
> > > > > >Setup remote repo and verify set
> > > > > >
> > > > > > git remote add origin
> https://githost.com/NEW-REPOSITORY-NAME.git
> > > > > > 
> > > > > >
> > > > > > git remote -v
> > > > > >
> > > > > >1.
> > > > > >
> > > > > >Push to new repo
> > > > > >
> > > > > > git

Re: [DISCUSS] Move maven caching to an external repository

2022-01-03 Thread Hervé BOUTEMY

yes, I was happy to learn about that shallow + filter approach :)

now, we have one choice to do:
1. keep the shallow repository
or
2. keep a strongly filtered repository done from the shallow

option 2 gives a smaller Git repository (0.8 MB vs 3.77 MB), but old commits 
cannot be built (because filtering removed many files)
option 1 maintains every commit as buildable as when it was in maven.git

Which option do you choose?

nce you choose, if nobody objects, I'll create maven-build-cache-extension.git 
with the content...

Regards,

Hervé

Le lundi 3 janvier 2022, 15:15:02 CET Guillaume Nodet a écrit :
> Awesome ! I didn't know about the shallow options during clone.
> This looks good to me !
> 
> Guillaume
> 
> Le ven. 24 déc. 2021 à 00:14, Hervé BOUTEMY  a
> 
> écrit :
> > short version:
> > I think I managed to extract exactly what we wanted:
> > https://github.com/hboutemy/maven-build-cache-extension-shallow-filtered
> > please review and confirm the result is ok
> > 
> > 
> > longer version: how was it done?
> > the first recipe I found is to drop old history:
> > 
> > git clone https://github.com/hboutemy/maven-build-cache-extension.git
> > shallow --shallow-since=2021-10-18
> > cd shallow
> > git filter-branch -- --all
> > 
> > you can see the intermediate result in
> > https://github.com/hboutemy/maven-build-cache-extension-shallow
> > 
> > then I just filtered with "git filter-repo" to remove globally many files
> > that were removed in
> > https://github.com/hboutemy/maven-build-cache-extension-shallow/commit/a32
> > 3d9859f091cdd8a2b946c71d12228ec29b70c
> > 
> > 
> > Regards,
> > 
> > Hervé
> > 
> > Le dimanche 19 décembre 2021, 22:56:56 CET Hervé BOUTEMY a écrit :
> > > I've tried to use git filter-repo, excluding unwanted directories or
> > > extensions
> > > 
> > > here is a sample result:
> > > https://github.com/hboutemy/maven-build-cache-extension-filtered
> > > = 4200 commits
> > > 
> > > instead of initial 11700
> > > https://github.com/hboutemy/maven-build-cache-extension
> > > 
> > > we can still improve the list of directories to exclude
> > > 
> > > before taking time for that, I need feedback: what do you think about
> > 
> > this
> > 
> > > approach?
> > > 
> > > Regards,
> > > 
> > > Hervé
> > > 
> > > Le vendredi 17 décembre 2021, 11:47:25 CET Guillaume Nodet a écrit :
> > > > I've tried various things without any good results.
> > > > Given there's not much history to preserve here, I'd go ahead and just
> > > > create a new repo with the current contents of the branch.
> > > > Any objections?
> > > > 
> > > > Le dim. 12 déc. 2021 à 15:43, Jeff Jensen
> > > > 
> > > > 
> > > > a écrit :
> > > > > I've split git repos before and using filter-branch is the key to
> > 
> > keep
> > 
> > > > > the
> > > > > desired and purge the rest.
> > > > > 
> > > > > From my notes, these two posts helped me:
> > > > > *
> > 
> > https://docs.github.com/en/get-started/using-git/splitting-a-subfolder-o
> > 
> > > > > ut
> > > > > -into-a-new-repository *
> > 
> > https://support.atlassian.com/bitbucket-cloud/docs/split-a-repository-in
> > 
> > > > > -t
> > > > > wo/
> > > > > 
> > > > > These are my shortcut notes for doing so, hope they are clear enough
> > 
> > for
> > 
> > > > > you and help. In a new repo, locally convert a current source
> > > > > subdirectory
> > > > > to the root directory and purge everything else; then push to remote
> > 
> > and
> > 
> > > > > locally cleanup:
> > > > >1.
> > > > > 
> > > > >Make directory for new repo from current repo:
> > > > > git clone current-repo to-new-directory
> > > > > 
> > > > >1.
> > > > >
> > > > >Disconnect from current remote immediately to prevent catastrophe
> > 
> > and
> > 
> > > > >verify none set
> > > > > 
> > > > > git remote rm origin
> > > > > 
> > > > > git remote -v
> > > > > 
> > > > >1.
> > > > >
> > > > >Keep desired dir and move it to top level, remove the rest
> > > > >1.
> > > > >
> > > > >   FOLDER-NAME: which one to keep and move to top level
> > > > >   2.
> > > > >   
> > > > >   BRANCH-NAME: which branch to do this on (must exist, e.g.
> > 
> > master)
> > 
> > > > > git filter-branch --prune-empty --subdirectory-filter FOLDER-NAME
> > > > > BRANCH-NAME
> > > > > 
> > > > >1.
> > > > >
> > > > >Setup remote repo and verify set
> > > > > 
> > > > > git remote add origin https://githost.com/NEW-REPOSITORY-NAME.git
> > > > > 
> > > > > 
> > > > > git remote -v
> > > > > 
> > > > >1.
> > > > >
> > > > >Push to new repo
> > > > > 
> > > > > git push -u origin BRANCH-NAME
> > > > > 
> > > > >1.
> > > > >
> > > > >Further cleanup: delete all tags (locally only (Powershell))
> > > > > 
> > > > > git tag | foreach-object -process { git tag -d $_ }
> > > > > 
> > > > >1.
> > > > >
> > > > >Further cleanup: remove local unreachable/recyclable commits
> > > > >

Re: [VOTE] Release Maven Release version 3.0.0-M5

2022-01-03 Thread Tamás Cservenák

+1

On Mon, Jan 3, 2022 at 8:18 PM Michael Osipov  wrote:

> Am 2022-01-02 um 11:41 schrieb Michael Osipov:
> > Hi,
> >
> > We solved 9 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317824=12346565
> >
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/projects/MRELEASE/issues
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1690/
> >
> https://repository.apache.org/content/repositories/maven-1690/org/apache/maven/release/maven-release/3.0.0-M5/maven-release-3.0.0-M5-source-release.zip
> >
> >
> > Source release checksum(s):
> > maven-release-3.0.0-M5-source-release.zip
> >
> cbf9e5feec66d194022a0fa3088702e37b6a54d179b8dd836578601883a4d3583de7be136ca55ce29287417f43176a7e98f449da3abc6ef80d6d09a2701b1786
>
> >
> >
> > Staging site:
> > https://maven.apache.org/maven-release-archives/maven-release-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
>
> +1
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Archiver version 3.5.2

2022-01-03 Thread Michael Osipov


Am 2022-01-02 um 13:48 schrieb Michael Osipov:

Hi,

We solved 2 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922=12349631 



There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=component%20%3D%20maven-archiver%20AND%20project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC 



Staging repo:
https://repository.apache.org/content/repositories/maven-1691/
https://repository.apache.org/content/repositories/maven-1691/org/apache/maven/maven-archiver/3.5.2/maven-archiver-3.5.2-source-release.zip 



Source release checksum(s):
maven-archiver-3.5.2-source-release.zip
sha512: 
83e3657a626765307c1f6394ae96218128f577613ee5a8845eae07b875f7f5bab366dcb847b507be8809d4084187e6ee25f03230055a01cd1aec283f9497100a 



Staging site:
https://maven.apache.org/shared-archives/maven-archiver-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.


+1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Release version 3.0.0-M5

2022-01-03 Thread Michael Osipov


Am 2022-01-02 um 11:41 schrieb Michael Osipov:

Hi,

We solved 9 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317824=12346565 



There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/projects/MRELEASE/issues

Staging repo:
https://repository.apache.org/content/repositories/maven-1690/
https://repository.apache.org/content/repositories/maven-1690/org/apache/maven/release/maven-release/3.0.0-M5/maven-release-3.0.0-M5-source-release.zip 



Source release checksum(s):
maven-release-3.0.0-M5-source-release.zip
cbf9e5feec66d194022a0fa3088702e37b6a54d179b8dd836578601883a4d3583de7be136ca55ce29287417f43176a7e98f449da3abc6ef80d6d09a2701b1786 



Staging site:
https://maven.apache.org/maven-release-archives/maven-release-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.


+1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [DISCUSS] Move maven caching to an external repository

2022-01-03 Thread Guillaume Nodet

Awesome ! I didn't know about the shallow options during clone.
This looks good to me !

Guillaume

Le ven. 24 déc. 2021 à 00:14, Hervé BOUTEMY  a
écrit :

> short version:
> I think I managed to extract exactly what we wanted:
> https://github.com/hboutemy/maven-build-cache-extension-shallow-filtered
> please review and confirm the result is ok
>
>
> longer version: how was it done?
> the first recipe I found is to drop old history:
>
> git clone https://github.com/hboutemy/maven-build-cache-extension.git
> shallow --shallow-since=2021-10-18
> cd shallow
> git filter-branch -- --all
>
> you can see the intermediate result in
> https://github.com/hboutemy/maven-build-cache-extension-shallow
>
> then I just filtered with "git filter-repo" to remove globally many files
> that were removed in
> https://github.com/hboutemy/maven-build-cache-extension-shallow/commit/a323d9859f091cdd8a2b946c71d12228ec29b70c
>
>
> Regards,
>
> Hervé
>
> Le dimanche 19 décembre 2021, 22:56:56 CET Hervé BOUTEMY a écrit :
> > I've tried to use git filter-repo, excluding unwanted directories or
> > extensions
> >
> > here is a sample result:
> > https://github.com/hboutemy/maven-build-cache-extension-filtered
> > = 4200 commits
> >
> > instead of initial 11700
> > https://github.com/hboutemy/maven-build-cache-extension
> >
> > we can still improve the list of directories to exclude
> >
> > before taking time for that, I need feedback: what do you think about
> this
> > approach?
> >
> > Regards,
> >
> > Hervé
> >
> > Le vendredi 17 décembre 2021, 11:47:25 CET Guillaume Nodet a écrit :
> > > I've tried various things without any good results.
> > > Given there's not much history to preserve here, I'd go ahead and just
> > > create a new repo with the current contents of the branch.
> > > Any objections?
> > >
> > > Le dim. 12 déc. 2021 à 15:43, Jeff Jensen
> > > 
> > >
> > > a écrit :
> > > > I've split git repos before and using filter-branch is the key to
> keep
> > > > the
> > > > desired and purge the rest.
> > > >
> > > > From my notes, these two posts helped me:
> > > > *
> > > >
> > > >
> https://docs.github.com/en/get-started/using-git/splitting-a-subfolder-o
> > > > ut
> > > > -into-a-new-repository *
> > > >
> > > >
> https://support.atlassian.com/bitbucket-cloud/docs/split-a-repository-in
> > > > -t
> > > > wo/
> > > >
> > > > These are my shortcut notes for doing so, hope they are clear enough
> for
> > > > you and help. In a new repo, locally convert a current source
> > > > subdirectory
> > > > to the root directory and purge everything else; then push to remote
> and
> > > >
> > > > locally cleanup:
> > > >1.
> > > >
> > > >Make directory for new repo from current repo:
> > > > git clone current-repo to-new-directory
> > > >
> > > >1.
> > > >
> > > >Disconnect from current remote immediately to prevent catastrophe
> and
> > > >verify none set
> > > >
> > > > git remote rm origin
> > > >
> > > > git remote -v
> > > >
> > > >1.
> > > >
> > > >Keep desired dir and move it to top level, remove the rest
> > > >1.
> > > >
> > > >   FOLDER-NAME: which one to keep and move to top level
> > > >   2.
> > > >
> > > >   BRANCH-NAME: which branch to do this on (must exist, e.g.
> master)
> > > >
> > > > git filter-branch --prune-empty --subdirectory-filter FOLDER-NAME
> > > > BRANCH-NAME
> > > >
> > > >1.
> > > >
> > > >Setup remote repo and verify set
> > > >
> > > > git remote add origin https://githost.com/NEW-REPOSITORY-NAME.git
> > > > 
> > > >
> > > > git remote -v
> > > >
> > > >1.
> > > >
> > > >Push to new repo
> > > >
> > > > git push -u origin BRANCH-NAME
> > > >
> > > >1.
> > > >
> > > >Further cleanup: delete all tags (locally only (Powershell))
> > > >
> > > > git tag | foreach-object -process { git tag -d $_ }
> > > >
> > > >1.
> > > >
> > > >Further cleanup: remove local unreachable/recyclable commits
> > > >(remnants
> > > >of prior)
> > > >
> > > > git reflog expire --expire-unreachable=now --all
> > > >
> > > > git gc --prune=now
> > > >
> > > >
> > > > On Sun, Dec 12, 2021 at 7:32 AM Hervé BOUTEMY  >
> > > >
> > > > wrote:
> > > > > nice work done
> > > > > I published the result to
> https://maven.apache.org/ref/caching-LATEST/
> > > > >
> > > > > now, on moving source to a separate Git repository, I did a basic
> test
> > > > > pushing
> > > > > to a new repository:
> > > > > https://github.com/hboutemy/maven-build-cache-extension
> > > > >
> > > > > this leads to getting quite a lot of Maven history
> > > > >
> > > > > I'm not a Git wizard: is there a way to cut down the history to
> keep
> > > > > only
> > > > > the
> > > > > interesting part when the build cache code donation was done?
> > > > >
> > > > > Regards,
> > > > >
> > > > > Hervé
> > > > >
> > > > > Le jeudi 9 décembre 2021, 10:39:10 CET Guillaume Nodet a écrit :
> > > > > > Le jeu. 9 déc. 2021 à 09:52, Hervé BOUTEMY

Re: [VOTE] Release Maven Release version 3.0.0-M5

2022-01-03 Thread Arnaud Héritier

+1

On Sun, Jan 2, 2022 at 11:41 AM Michael Osipov  wrote:

> Hi,
>
> We solved 9 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317824=12346565
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MRELEASE/issues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1690/
>
> https://repository.apache.org/content/repositories/maven-1690/org/apache/maven/release/maven-release/3.0.0-M5/maven-release-3.0.0-M5-source-release.zip
>
> Source release checksum(s):
> maven-release-3.0.0-M5-source-release.zip
>
> cbf9e5feec66d194022a0fa3088702e37b6a54d179b8dd836578601883a4d3583de7be136ca55ce29287417f43176a7e98f449da3abc6ef80d6d09a2701b1786
>
> Staging site:
> https://maven.apache.org/maven-release-archives/maven-release-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

-- 
Arnaud Héritier
Twitter/GitHub/... : aheritier

Re: [VOTE] Release Maven Release version 3.0.0-M5

2022-01-03 Thread Jason van Zyl

+1 

> On Jan 2, 2022, at 5:41 AM, Michael Osipov  wrote:
> 
> Hi,
> 
> We solved 9 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317824=12346565
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MRELEASE/issues
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1690/
> https://repository.apache.org/content/repositories/maven-1690/org/apache/maven/release/maven-release/3.0.0-M5/maven-release-3.0.0-M5-source-release.zip
> 
> Source release checksum(s):
> maven-release-3.0.0-M5-source-release.zip
> cbf9e5feec66d194022a0fa3088702e37b6a54d179b8dd836578601883a4d3583de7be136ca55ce29287417f43176a7e98f449da3abc6ef80d6d09a2701b1786
> 
> Staging site:
> https://maven.apache.org/maven-release-archives/maven-release-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 

Thanks,

Jason




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slachiewicz commented on pull request #281: Update for assembly plugin 3.3.0

2022-01-03 Thread GitBox



slachiewicz commented on pull request #281:
URL: https://github.com/apache/maven-site/pull/281#issuecomment-1004028952


   Thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slachiewicz merged pull request #281: Update for assembly plugin 3.3.0

2022-01-03 Thread GitBox



slachiewicz merged pull request #281:
URL: https://github.com/apache/maven-site/pull/281


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Drop @inject and sisu from mojo?

2022-01-03 Thread Cyrille Le Clerc

Sorry for the delay.
I forgot the details. We have tracked the task to detail the problems on
the OpenTelemetry project:
https://github.com/open-telemetry/opentelemetry-java-contrib/issues/149

I'll re-test ASAP.

Cyrille

On Thu, Dec 16, 2021 at 12:34 PM Tamás Cservenák 
wrote:

> Howdy Cyrille,
>
> I'd love to hear more about your problems, and the limitations you have
> hit.
>
> Thanks
> Tamas
>
> On Thu, Dec 16, 2021 at 12:30 PM Cyrille Le Clerc
>  wrote:
>
> > Dear Maven Community,
> >
> > As an infrequent Maven plugin author (Jenkins Pipeline Maven integration
> > <
> https://github.com/jenkinsci/pipeline-maven-plugin/tree/master/maven-spy>
> > and OpenTelemetry Maven extension
> > <
> >
> https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/maven-extension
> > >),
> > I can share that *it is confusing for infrequent plugin authors to have
> > both @Inject and Plexus @Component with different behaviors*.
> >
> > For example, I tried first to implement the OpenTelemetry Maven extension
> > with @Inject and faced limitations so I had to rewrite to use @Component.
> >
> > I would see the removal of @Inject or of @Component as an improvement
> > thanks to simplification. As @Inject has limitations, it could make sense
> > to deprecate it.
> >
> > I hope this feedback helps
> >
> > Cyrille
> >
> >
> >
> >
> > On Mon, Dec 13, 2021 at 9:13 AM Romain Manni-Bucau <
> rmannibu...@gmail.com>
> > wrote:
> >
> > > Hi all,
> > >
> > > Seems the fact to leak our IoC to mojo still has side effects since we
> > are
> > > scanned in mojos - and we can't say these mojos are not supported since
> > it
> > > is the whole goal of mojo to run the code users/mojo writers want
> right?
> > > The fact we use something official and mainstream and leak it to mojo
> > > creates regularly side effects. Added to that the fact this part is not
> > > really well stable and the contract not well defined accross versions
> > makes
> > > it hard for mojo writer to keep up with.
> > >
> > > Overall my proposal would be to drop any mainstream imports from maven
> > mojo
> > > leakgae - we don't care of maven core - it concerns javax/jakarta, can
> be
> > > slf4j, etc...
> > >
> > > The javax one is very impacting for 3.x so I think we should target any
> > > future release, the other (slf4j) can be cleaned up for v4 I guess
> since
> > > right now it works by "luck" and can need a longer fix where our
> > classreal
> > > checks where is the binding - if in the app don't use maven, if in
> maven,
> > > use maven one and skip slf4j-api, in other words it requires an
> > integration
> > > for mojo of the libs we provide when used as libs but risk to still
> break
> > > or have side effects is not that low.
> > >
> > > Wdyt? How do we plan to get back to a stack which is not interferring
> > with
> > > mojo code as it almost was in maven 3.3?
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> >
> >
> > --
> > Cyrille Le Clerc
> > Product Management Director, Observability
> > Paris, France
> >
>


-- 
Cyrille Le Clerc
Product Management Director, Observability
Paris, France

Re: [DISCUSS] Move maven caching to an external repository

Re: [DISCUSS] Move maven caching to an external repository

Re: [VOTE] Release Maven Release version 3.0.0-M5

Re: [VOTE] Release Apache Maven Archiver version 3.5.2

Re: [VOTE] Release Maven Release version 3.0.0-M5

Re: [DISCUSS] Move maven caching to an external repository

Re: [VOTE] Release Maven Release version 3.0.0-M5

Re: [VOTE] Release Maven Release version 3.0.0-M5

[GitHub] [maven-site] slachiewicz commented on pull request #281: Update for assembly plugin 3.3.0

[GitHub] [maven-site] slachiewicz merged pull request #281: Update for assembly plugin 3.3.0

Re: Drop @inject and sisu from mojo?

11 matches

Site Navigation

Mail list logo

Footer information