Re: [DISCUSS] Major changed for 4.x
Hi, On Tue, 22 Aug 2023 at 17:36, Guillaume Nodet wrote: > > Hi everyone, > > I hope you guys have been able to rest a bit during the summer (for those > that are back to work already)... > > I've pushed a few important PRs in the past months and I'd really like to > get the discussion going around those. Those are major changes that I > think we should introduce in Maven 4 asap: > * Better support for alternative POM syntaxes > * Needed infrastructure to evolve the model > * POM mixins > * Support for XML entities / XInclude I really like the idea of being able to improve the model. I find a bit scary the idea of XML entities/XInclude especially for all the possible security problems that I can imagine coming with that. No real example in mind, but I had so many issues problems in the last 10 years with XML entities/XInclude :) but maybe I'm wrong. how do you exactly plan to do that? > > The first 3 changes are stacked onto each other. The first one is the > support for alternative POM syntaxes [2]. Note that no syntax is provided > by the PR, but an example extension is provided in the IT PR [3], the > reader being generated using the maven model and the IT's project is using > it [4]. The main idea is to provide an enhanced XML syntax if we want, as > it was discussed for the POM 5.0 [5]. > > The second one provides the ability to make evolution to the model without > breaking the maven ecosystem. The model has been stuck in 4.0.0 version > for 15 years or so, most of the things that would have required a change > have been delayed or worked around. The consumer POM that has been > introduced in Maven 4 is a first step, but I think we should go further. > Please read the details in the PR [6]. > > The third one is the support for POM mixins [7]. That one is still a > draft. Two ITs have been written to leverage mixins using GAV or as > relative paths [8]. This definitely needs some work, but the current state > definitely shows that it can be implemented and introduced in the next > alphas. > > The last one is a relatively small PR [9] which brings support for XML > entities and XInclude loaded from external files. All loaded files are > loaded using relative URLs (absolute URLs are rejected for security > reasons). The entities and xinclude bits are all inlined during the raw -> > consumer POM transformation so that they don't appear in repositories. I > wrote this PR as a possible alternative for mixins, that's the main reason > why I include it in this discussion. > > I'm not necessarily looking for in-depth reviews of the PRs, but at least > to find a consensus and general agreement on the way forward. > > Cheers, > Guillaume > > [2] https://github.com/apache/maven/pull/1197 > [3] > https://github.com/apache/maven-integration-testing/pull/276/files#diff-ffb3dec529cab94ebf3c5830444275ad2b2e4826fe1df843454882efadd2446c > [4] > https://github.com/apache/maven-integration-testing/pull/276/files#diff-8d7362e60d231ad8c5d4b7746873da2855d9cf1fd5aeeca9c143ed942bd94b38 > [5] > https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 > [6] https://github.com/apache/maven/pull/1160 > [7] > https://github.com/apache/maven/pull/1209/commits/211e27acd21a6cb8cee30ccd066499fc613a5c82 > [8] > https://github.com/apache/maven-integration-testing/tree/b2642d74caae854051dc77acd19b972dfe66b1cd/core-it-suite/src/test/resources/mng-5102-mixins > [9] https://github.com/apache/maven/pull/1205 > > -- > > Guillaume Nodet - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [ANN] Apache Maven 4.0.0-alpha-7 released
On 28/08/2023 at 11:42:48 AM, Guillaume Nodet wrote: > I haven’t had a chance to look into this yet - but I wondered if anyone > else had seen anything similar? > > > No. Can you check if you're using a recent surefire version ? > I’m using 3.1.2 here, which AFAIK is the latest. Along with Junit Jupiter 5.10.0 - interestingly I just set up a clean room project to check with and it seemed fine - so there must be some other dependency that’s confusing things along the way. If I manage to reproduce it from a clean/example project I’ll update. -- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine Tree
Re: [ANN] Apache Maven 4.0.0-alpha-7 released
Le lun. 28 août 2023 à 00:22, Mark Derricutt a écrit : > On 29/06/2023 at 3:16:24 PM, Guillaume Nodet wrote: > > > Maven 4.0.0-alpha-7 is available via > https://maven.apache.org/download.cgi > > > > > Interesting - I noticed over the weekend that under 4.0.0-alpha-7 surefire > isn’t picking up any of my Junit 5 tests, but maven 3.9.4 is. > > I haven’t had a chance to look into this yet - but I wondered if anyone > else had seen anything similar? > No. Can you check if you're using a recent surefire version ? > > > -- > "Great artists are extremely selfish and arrogant things" — Steven Wilson, > Porcupine Tree > -- Guillaume Nodet
Re: [maven-build-cache-extension] branch master updated: remove unused logback dependency (#88)
-1 Please revert this commit.
I'm the only one to express some concerns about such change.
Se conversations here
https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1694496822
On Sat, 26 Aug 2023 at 23:33, wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> elharo pushed a commit to branch master
> in repository
> https://gitbox.apache.org/repos/asf/maven-build-cache-extension.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 47f8404 remove unused logback dependency (#88)
> 47f8404 is described below
>
> commit 47f8404c256fa51ea2ce819eb782de88c36c2bd5
> Author: Elliotte Rusty Harold
> AuthorDate: Sat Aug 26 09:31:34 2023 -0400
>
> remove unused logback dependency (#88)
> ---
> pom.xml| 6 --
> src/test/resources/logback.xml | 40
> 2 files changed, 46 deletions(-)
>
> diff --git a/pom.xml b/pom.xml
> index 1c11381..8dc816c 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -188,12 +188,6 @@ under the License.
>junit-jupiter
>test
>
> -
> - ch.qos.logback
> - logback-classic
> - 1.3.11
> - test
> -
>
>org.slf4j
>log4j-over-slf4j
> diff --git a/src/test/resources/logback.xml b/src/test/resources/logback.xml
> deleted file mode 100644
> index 88be419..000
> --- a/src/test/resources/logback.xml
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -
> -
> -
> -
> - />
> -
> -
> -
> - %-4relative [%thread] %-5level %logger{64} - %msg %n
> -
> -
> -
> - name="org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy"
> level="debug"/>
> -
> -
> -
> -
> -
> -
>
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: [ANN] Apache Maven 4.0.0-alpha-7 released
On 29/06/2023 at 3:16:24 PM, Guillaume Nodet wrote: > Maven 4.0.0-alpha-7 is available via https://maven.apache.org/download.cgi > Interesting - I noticed over the weekend that under 4.0.0-alpha-7 surefire isn’t picking up any of my Junit 5 tests, but maven 3.9.4 is. I haven’t had a chance to look into this yet - but I wondered if anyone else had seen anything similar? -- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine Tree
