[GitHub] maven-surefire issue #160: SUREFIRE-1398 threadCount is set for JUnit only w...

2017-07-26 Thread MatousJobanek
Github user MatousJobanek commented on the issue:

https://github.com/apache/maven-surefire/pull/160
  
Sorry, I didn't notice that the parameter is used also in other cases.
I changed the commit to set the `threadCount` only when it is a positive 
value also in case of JUnit - in the same way as it is done in case of TestNG


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-surefire pull request #160: SUREFIRE-1398 Sets threadCount only when p...

2017-07-25 Thread MatousJobanek
GitHub user MatousJobanek opened a pull request:

https://github.com/apache/maven-surefire/pull/160

SUREFIRE-1398 Sets threadCount only when parallel parameter is set

Otherwise, the TestNG fails with 
`Cannot use a threadCount parameter less than 1; 1 > 0` 
in some cases when the parallel parameter was not set. To identify the 
cases, take a look at related Jira issue: 
https://issues.apache.org/jira/browse/SUREFIRE-1398
I removed the check for positiveness of the `threadCount` value as it's a 
responsibility of the user to provide correct value.
The question is if the default value of `threadCount` parameter shouldn't 
be 1, to avoid such a problems...? If yes, then I'll update my PR

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MatousJobanek/maven-surefire SUREFIRE-1398

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-surefire/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #160


commit 30df0c3fb5cc1f22caf0a9031155cb2d778b3fab
Author: Matous Jobanek <mjoba...@redhat.com>
Date:   2017-07-25T14:19:01Z

SUREFIRE-1398 Sets threadCount only when parallel parameter is set




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org