[GitHub] maven-plugins pull request #126: MCOMPILER-306 Fix `compilerArgs` example us...
GitHub user Stephan202 opened a pull request: https://github.com/apache/maven-plugins/pull/126 MCOMPILER-306 Fix `compilerArgs` example usage You can merge this pull request into a Git repository by running: $ git pull https://github.com/PicnicSupermarket/maven-plugins bugfix/MCOMPILER-306 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/126.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #126 commit bb0113a07fdce8ae76b326b916c0b12924b47157 Author: Stephan Schroevers Date: 2017-08-19T21:34:42Z MCOMPILER-306 Fix `compilerArgs` example usage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request: Fix for MJAVADOC-385
GitHub user Stephan202 opened a pull request: https://github.com/apache/maven-plugins/pull/74 Fix for MJAVADOC-385 This fixes the `maven-javadoc-plugin` documentation for the `` feature. The changes made are exactly those described in [MJAVADOC-385](https://issues.apache.org/jira/browse/MJAVADOC-385). Some integration test paths are updated as well. I verified it all still works. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Stephan202/maven-plugins MJAVADOC-385 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit f202cd38d8b722ad7d498b40be820fc5da5cdd2a Author: Stephan Schroevers Date: 2015-12-19T16:29:20Z Fix feature documentation Resolves MJAVADOC-385. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...
Github user Stephan202 closed the pull request at: https://github.com/apache/maven/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...
Github user Stephan202 commented on the pull request: https://github.com/apache/maven/pull/40#issuecomment-140189697 A variation on the proposed fix was merged in #58. So I'll close this PR. (I'll also delete by branch/fork, but the diff can still be viewed in [MNG-5786](https://issues.apache.org/jira/browse/MNG-5786).) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...
Github user Stephan202 commented on the pull request: https://github.com/apache/maven/pull/40#issuecomment-89738913 I can't seem to comment on [MNG-5786](https://jira.codehaus.org/browse/MNG-5786) anymore (comment button missing), presumably because of the impending Codehaus shutdown. So I'll continue the discussion here. @jvanzyl wrote: > The intended use and behaviour is to have one `.mvn` at the root of the multi-module project. By design we currently do not expect there to be multiple `.mvn` directories within one project tree. So I consider this behaviour correct. I understand wanting to keep the system simple and supporting only a single `.mvn` within the project tree. But as it stands, a "rogue" `.mvn` higher up, "outside" the project tree can silently impact the build. This can lead to hard to explain issues further down the line. As such, I suggest Maven either: 1. Warns if more than one `.mvn` is found in the path from CWD to root; 2. Fixes the code such that the "nearest" `.mvn` in the path from CWD to root always wins. Option 2 is no more difficult to understand than "we support only one `.mvn`" (as one does not even need to think about error cases) and can be achieved with a trivial patch; that's precisely what this PR proposes. Side note: if we feel uncomfortable considering any `.mvn` that may be outside the project tree, then the search logic should be extended with an extra termination condition: stop looking for a `.mvn` once the traversal up the directory tree reaches a directory that lacks a `pom.xml`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-site pull request: Fix download links for apache-maven-{3.2....
Github user Stephan202 closed the pull request at: https://github.com/apache/maven-site/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-site pull request: Fix download links for apache-maven-{3.2....
GitHub user Stephan202 opened a pull request:
https://github.com/apache/maven-site/pull/2
Fix download links for apache-maven-{3.2.5,3.1.1,3.0.5}-src.tar.gz.asc.
Summary says it. Some links on the download page contain the `/maven-2/`
path component, while that should be `/maven-3/`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Stephan202/maven-site fix-download-links
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-site/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
commit 0bf89b16ca070a971e54a0923ddb44b4d8661985
Author: Stephan Schroevers
Date: 2015-03-24T22:21:06Z
Fix download links for apache-maven-{3.2.5,3.1.1,3.0.5}-src.tar.gz.asc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...
GitHub user Stephan202 opened a pull request: https://github.com/apache/maven/pull/40 MNG-5786: Fix edge case in determining maven.multiModuleProjectDirectory. See [MNG-5786](https://jira.codehaus.org/browse/MNG-5786) for details. The commit message explains the issue in different words: MNG-5786: Fix maven.multiModuleProjectDirectory. Fixes an edge case where maven.multiModuleProjectDirectory is set incorrectly. Consider the following scenario: /some/path/to/the/workspace/.mvn /some/path/to/the/workspace/project/.mvn /some/path/to/the/workspace/project/pom.xml Prior to the fix, running Maven inside the *project* directory will cause maven.multiModuleProjectDirectory to be set to the *workspace* directory. The fix entails testing for the presence of .mvn before traversing one directory up, rather than afterwards. The loop termination condition was moved inside the loop, so as to ensure that .mvn can also be placed in the file system root. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Stephan202/maven MNG-5786 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit 5374bfcaff59414ca9b580cefbab8880bf782d42 Author: Stephan Schroevers Date: 2015-03-18T13:18:18Z MNG-5786: Fix maven.multiModuleProjectDirectory. Fixes an edge case where maven.multiModuleProjectDirectory is set incorrectly. Consider the following scenario: /some/path/to/the/workspace/.mvn /some/path/to/the/workspace/project/.mvn /some/path/to/the/workspace/project/pom.xml Prior to the fix, running Maven inside the *project* directory will cause maven.multiModuleProjectDirectory to be set to the *workspace* directory. The fix entails testing for the presence of .mvn before traversing one directory up, rather than afterwards. The loop termination condition was moved inside the loop, so as to ensure that .mvn can also be placed in the file system root. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request: Remove JUnit4Provider.java.orig.
GitHub user Stephan202 opened a pull request: https://github.com/apache/maven-surefire/pull/39 Remove JUnit4Provider.java.orig. The file `surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java.orig` was accidentally committed in 3274bd308adc85ef16d463cb7aa8af290465bc67. A benign mistake. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Stephan202/maven-surefire remove-patch-artifact Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 0bac911a303d9a3c7a43f2dee7c7bf8cd1f306bb Author: Stephan Schroevers Date: 2014-06-16T19:37:04Z Remove JUnit4Provider.java.orig. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request: Fix formatting and spelling mistakes ...
GitHub user Stephan202 opened a pull request: https://github.com/apache/maven-surefire/pull/38 Fix formatting and spelling mistakes in the documentation Highlights: - In `maven-surefire-plugin/src/site/apt/developing.apt.vm`, make sure text is not rendered bold. - In `maven-surefire-plugin/src/site/markdown/newerrorsummary.md`, ensure proper formatting of the list at the bottom of the page. - In `maven-surefire-plugin/src/site/site.xml`, add link to "Using POJO Tests" example. - In `maven-surefire-report-plugin/src/site/fml/faq.fml`, mention that upgrading Surefire will resolve the listed known issue. - Settle on a consistent title casing for (sub)headings. - Synchronize page titles with window titles and menu titles, where sensible. - Fix/make consistent italic/bold/monospace typesetting of various terms. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Stephan202/maven-surefire documentation-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 22eb7362657acac36af07b343389ec1e042d9a13 Author: Stephan Schroevers Date: 2014-06-09T20:39:52Z Fix formatting and spelling mistakes in the documentation. Highlights: - In maven-surefire-plugin/src/site/apt/developing.apt.vm, make sure text is not rendered bold. - In maven-surefire-plugin/src/site/markdown/newerrorsummary.md, ensure proper formatting of the list at the bottom of the page. - In maven-surefire-plugin/src/site/site.xml, add link to "Using POJO Tests" example. - In maven-surefire-report-plugin/src/site/fml/faq.fml, mention that upgrading Surefire will resolve the listed known issue. - Settle on a consistent title casing for (sub)headings. - Synchronize page titles with window titles and menu titles, where sensible. - Fix/make consistent italic/bold/monospace typesetting of various terms. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
