[GitHub] maven issue #114: MNG-6220 add color CLI option
Github user agudian commented on the issue: https://github.com/apache/maven/pull/114 @rfscholte: looks good! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request: Adding individual rerun times to XML ...
Github user agudian commented on the pull request: https://github.com/apache/maven-surefire/pull/96#issuecomment-143957705 I agree that it makes sense to add the same information to the xml report that we provide in the console output. Regarding what time to take for the test case, I'd opt for whatever we print in the console. If we get to choose, my first guess would have been the last execution as well. But heck - whether that's what a user needs really depends on the use case and the kind of error ;-). So let's not overthink this. Consistency is more important for this part ;-). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Locate .mvn in current directory
Github user agudian commented on the pull request: https://github.com/apache/maven/pull/58#issuecomment-121962243 Hi, Thanks for the patch! Are the windows-scripts also affected by the bug and could use a fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...
Github user agudian commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114251594 Works as it should, I'd say... :grinning: @tssp, I have rebased your commit, so this PR won't close automatically. Would you please close it? And thanks for the patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...
Github user agudian commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114223364 Sure, I'll take care of it. :wink: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-949] add forkCount parameter
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/21 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-956] make forkNumber unique among co...
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/22 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-946] prevent hanging main process if...
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/20 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-956] make forkNumber unique among co...
GitHub user agudian opened a pull request:
https://github.com/apache/maven-surefire/pull/22
[SUREFIRE-956] make forkNumber unique among concurrent surefire-executions
in a parallel maven build
This pull request builds upon some changes from
https://github.com/apache/maven-surefire/pull/21 - that one would need to be
applied first, leaving this one with only commits starting with [SUREFIRE-956]
(currently one).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agudian/maven-surefire SUREFIRE-956-forkNumber
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/22.patch
commit e9f758471aa9ac967025209df004d426e49e1844
Author: agudian andreas.gud...@gmail.com
Date: 2013-01-05T20:13:12Z
[SUREFIRE-946] prevent hanging main process if forked process was killed
(softly)
commit b32af3edadce6fd7b50a401b7362b039120ba33b
Author: agudian andreas.gud...@gmail.com
Date: 2013-01-05T21:08:53Z
Fix typo, format source
commit 16e544cf44c669981b1394a1e3e94734d74c6aac
Author: agudian andreas.gud...@gmail.com
Date: 2013-01-09T21:56:15Z
[SUREFIRE-946] fix crash-detection for reuseForks=true, now including hard
crashes.
* use a callback to close the TestProvidingInputStream after the forked
process ended but before waiting on InputFeeder to finish
* removed the shutdown hook in the forked VM again, removed
BOOTERCODE_CRASH (also fixes the other ITs that broke before)
* extend CrashDetectionIT for testing hard VM crashes
* add IT for killed main process with reusable fork
commit 652aab9f0315bd7d065c2ec57f6e6299d46c23be
Author: agudian andreas.gud...@gmail.com
Date: 2013-01-11T22:11:55Z
[SUREFIRE-946] reset verifier version to 1.4, update ForkStarter to latest
m-s-u snapshot.
commit 3c342a606a11ff72c21577132906dbf5ecd133d6
Author: agudian andreas.gud...@gmail.com
Date: 2013-01-11T22:20:22Z
[SUREFIRE-946] Fix the IT - now it actually tests the reported problem.
commit e27b083ba7b01e4ac6e6b94a10382287f51ae12d
Author: agudian andreas.gud...@gmail.com
Date: 2013-01-13T16:16:56Z
Use ShutdownHookUtils
commit 914123ff4776eb6289ec471b23cad7b51f643933
Author: Andreas Gudian andreas.gud...@gmail.com
Date: 2013-01-18T20:15:09Z
[SUREFIRE-949] add forkCount parameter, making the inconsitent forkMode
parameter deprecated.
- All defaulting works as in the previous versions, with the exception of
reuseForks (introduced in the last release). It's now true by default.
- forkCount supports C notation as in -T of maven-core
commit 2baed8122db7ad9e4e62c35d6e447865b890cc96
Author: Andreas Gudian andreas.gud...@gmail.com
Date: 2013-01-21T19:55:11Z
fix test (parenthesis were missing in the computation)
commit b70c2f29a069fc202a0a491b9d92bc57aa63b805
Author: Andreas Gudian andreas.gud...@gmail.com
Date: 2013-01-24T20:06:35Z
clean up variable naming: threadNumber becomes forkNumber
commit c1c76d5fabe83897786a71ca372569ba5bb0dbe6
Author: Andreas Gudian andreas.gud...@gmail.com
Date: 2013-01-24T20:12:08Z
[SUREFIRE-949] update documentation with new forkCount / reuseForks options
- also make ${surefire.threadNumber} replacement undocumented, as its
naming is totally misleading and might give users wrong impressions
commit aa4a7fe78e339dc8d89c6bb5d0c54f8c44639f3e
Author: Andreas Gudian andreas.gud...@gmail.com
Date: 2013-01-24T20:24:10Z
make test more robust by removing some assertions that depend on current
system load
commit 12bacc5e4ad0fccfcc6acba2b1aae7df7f79607d
Author: Andreas Gudian andreas.gud...@gmail.com
Date: 2013-01-24T20:35:02Z
[SUREFIRE-949] update documentation with new forkCount / reuseForks options
commit f6a0eaf3c8953769d3a0458d4798da48181d12ff
Author: Andreas Gudian andreas.gud...@gmail.com
Date: 2013-02-05T21:01:03Z
[SUREFIRE-956] make forkNumber unique among concurrent surefire-executions
in a parallel maven build
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
maven-shared pull request: [SUREFIRE-946] Allow execution of a callback aft...
Github user agudian closed the pull request at: https://github.com/apache/maven-shared/pull/2 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-949] add forkCount parameter
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/21 [SUREFIRE-949] add forkCount parameter [SUREFIRE-949] add forkCount parameter, making the inconsitent forkMode parameter deprecated. - All defaulting works as in the previous versions, with the exception of reuseForks (introduced in the last release). It's now true by default. - forkCount supports C notation as in -T of maven-core (I had some problems with building the latest head revision, so I branched from my previous work on SUREFIRE-946 - there's a separate pull-request for that one). You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-949-forkCount Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/21.patch commit e9f758471aa9ac967025209df004d426e49e1844 Author: agudian andreas.gud...@gmail.com Date: 2013-01-05T20:13:12Z [SUREFIRE-946] prevent hanging main process if forked process was killed (softly) commit b32af3edadce6fd7b50a401b7362b039120ba33b Author: agudian andreas.gud...@gmail.com Date: 2013-01-05T21:08:53Z Fix typo, format source commit 16e544cf44c669981b1394a1e3e94734d74c6aac Author: agudian andreas.gud...@gmail.com Date: 2013-01-09T21:56:15Z [SUREFIRE-946] fix crash-detection for reuseForks=true, now including hard crashes. * use a callback to close the TestProvidingInputStream after the forked process ended but before waiting on InputFeeder to finish * removed the shutdown hook in the forked VM again, removed BOOTERCODE_CRASH (also fixes the other ITs that broke before) * extend CrashDetectionIT for testing hard VM crashes * add IT for killed main process with reusable fork commit 652aab9f0315bd7d065c2ec57f6e6299d46c23be Author: agudian andreas.gud...@gmail.com Date: 2013-01-11T22:11:55Z [SUREFIRE-946] reset verifier version to 1.4, update ForkStarter to latest m-s-u snapshot. commit 3c342a606a11ff72c21577132906dbf5ecd133d6 Author: agudian andreas.gud...@gmail.com Date: 2013-01-11T22:20:22Z [SUREFIRE-946] Fix the IT - now it actually tests the reported problem. commit e27b083ba7b01e4ac6e6b94a10382287f51ae12d Author: agudian andreas.gud...@gmail.com Date: 2013-01-13T16:16:56Z Use ShutdownHookUtils commit 914123ff4776eb6289ec471b23cad7b51f643933 Author: Andreas Gudian andreas.gud...@gmail.com Date: 2013-01-18T20:15:09Z [SUREFIRE-949] add forkCount parameter, making the inconsitent forkMode parameter deprecated. - All defaulting works as in the previous versions, with the exception of reuseForks (introduced in the last release). It's now true by default. - forkCount supports C notation as in -T of maven-core - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-946] prevent hanging main process if...
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/20 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-946] prevent hanging main process if...
GitHub user agudian reopened a pull request: https://github.com/apache/maven-surefire/pull/20 [SUREFIRE-946] prevent hanging main process if forked process was killed... ... (softly) You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-946 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/20.patch commit c1283673d47726e6ef69634199dc6cf3f198c56a Author: Kristian Rosenvold krosenv...@apache.org Date: 2013-01-07T03:14:11Z o Fixed broken IT commit 4dfdb08ccc881daa4f0745547dc2f649eefc8134 Author: Kristian Rosenvold krosenv...@apache.org Date: 2013-01-08T14:54:48Z o Fixed testcase on windows. o Fixed 2.2.1 tests by splitting report parser to separate module commit 350dd6fd745f82dcdf071ff910665d8b388dfe7b Author: Kristian Rosenvold krosenv...@apache.org Date: 2013-01-09T17:20:50Z o Made sleep timeout configurable in forkModeIt for testing SUREFIRE-946 commit e54dbd810f62fe723800f11279b881bff244b707 Author: agudian andreas.gud...@gmail.com Date: 2013-01-05T20:13:12Z [SUREFIRE-946] prevent hanging main process if forked process was killed (softly) Fixed with extended IT commit 230c46a26eaffcb0da57fd317e6a7611ba2c8e96 Author: Kristian Rosenvold krosenv...@apache.org Date: 2013-01-09T18:03:30Z o Removed warning commit 126f44957784ea8a0e5e2bd1b32687f37cb8aaec Author: Kristian Rosenvold krosenv...@apache.org Date: 2013-01-09T18:48:40Z o Removed windows linefeeds commit 4c47f19af9918fabc42cfdb7ea62323a7f8279b6 Author: Kristian Rosenvold krosenv...@apache.org Date: 2013-01-09T19:23:30Z o Made volatile to get consistent synchronization commit 9cd2acb3ee667df3eeb8f46805ed2885190cf77d Author: Kristian Rosenvold krosenv...@apache.org Date: 2013-01-13T14:01:38Z o Apporto sidebar !! commit e9f758471aa9ac967025209df004d426e49e1844 Author: agudian andreas.gud...@gmail.com Date: 2013-01-05T20:13:12Z [SUREFIRE-946] prevent hanging main process if forked process was killed (softly) commit b32af3edadce6fd7b50a401b7362b039120ba33b Author: agudian andreas.gud...@gmail.com Date: 2013-01-05T21:08:53Z Fix typo, format source commit 16e544cf44c669981b1394a1e3e94734d74c6aac Author: agudian andreas.gud...@gmail.com Date: 2013-01-09T21:56:15Z [SUREFIRE-946] fix crash-detection for reuseForks=true, now including hard crashes. * use a callback to close the TestProvidingInputStream after the forked process ended but before waiting on InputFeeder to finish * removed the shutdown hook in the forked VM again, removed BOOTERCODE_CRASH (also fixes the other ITs that broke before) * extend CrashDetectionIT for testing hard VM crashes * add IT for killed main process with reusable fork commit 652aab9f0315bd7d065c2ec57f6e6299d46c23be Author: agudian andreas.gud...@gmail.com Date: 2013-01-11T22:11:55Z [SUREFIRE-946] reset verifier version to 1.4, update ForkStarter to latest m-s-u snapshot. commit 3c342a606a11ff72c21577132906dbf5ecd133d6 Author: agudian andreas.gud...@gmail.com Date: 2013-01-11T22:20:22Z [SUREFIRE-946] Fix the IT - now it actually tests the reported problem. commit e27b083ba7b01e4ac6e6b94a10382287f51ae12d Author: agudian andreas.gud...@gmail.com Date: 2013-01-13T16:16:56Z Use ShutdownHookUtils - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-shared pull request: [SUREFIRE-946] Allow execution of a callback aft...
GitHub user agudian opened a pull request: https://github.com/apache/maven-shared/pull/2 [SUREFIRE-946] Allow execution of a callback after the process finished,... ... or the timeout ran up. The callback is invoked, before calling waitForPumpers, allowing clients to release possible locks on or in the in/out streams. You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-shared SUREFIRE-946 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-shared/pull/2.patch commit 3eca1cae5228f32cf81434ab0d728f518862076d Author: agudian andreas.gud...@gmail.com Date: 2013-01-11T22:06:08Z [SUREFIRE-946] Allow execution of a callback after the process finished, or the timeout ran up. The callback is invoked, before calling waitForPumpers, allowing clients to release possible locks on or in the in/out streams. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-shared pull request: Make ShutdownHookUtils public
GitHub user agudian opened a pull request: https://github.com/apache/maven-shared/pull/1 Make ShutdownHookUtils public It can be re-used in surefire to remove some code-duplication You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-shared SHARED-UTILS Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-shared/pull/1.patch commit 86308726670c0b8f3348632bf168b20cc539c4b5 Author: agudian andreas.gud...@gmail.com Date: 2013-01-07T21:00:39Z Make ShutdownHookUtils public - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-shared pull request: Make ShutdownHookUtils public
Github user agudian closed the pull request at: https://github.com/apache/maven-shared/pull/1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-946] prevent hanging main process if...
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/20 [SUREFIRE-946] prevent hanging main process if forked process was killed... ... (softly) You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-946 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/20.patch commit 91c3d2f5b10bfa716888d98e6ab8d33a3cb41234 Author: agudian andreas.gud...@gmail.com Date: 2013-01-05T20:13:12Z [SUREFIRE-946] prevent hanging main process if forked process was killed (softly) - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: Initial draft of a new examples page explain...
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/19 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: Initial draft of a new examples page explain...
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/19 Initial draft of a new examples page explaining the fork and parallel options Needs some proof-reading... :) Did I miss something? Do you have suggestions for a better structure? You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire FORK-DOC Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/19.patch commit 2f54f1c717b001c70f8884c6e872b18bb62f6dab Author: agudian andreas.gud...@gmail.com Date: 2013-01-03T23:05:33Z Initial draft of a new examples page explaining the fork and parallel options - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-943] fix test name in XML report
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/18 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-943] fix test name in XML report
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/18 [SUREFIRE-943] fix test name in XML report Added an integration test for the issue and included a proposed fix. All other ITs still pass, but I have no clue if there might be other side-effects. You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-943 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/18.patch commit d2f3ffeb7174776480e0999120a71234c2537762 Author: agudian andreas.gud...@gmail.com Date: 2012-12-29T23:30:13Z [SUREFIRE-943] fix test name in XML report Added an integration test for the issue - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-933] repair parallel=classes
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/15 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-933] repair parallel=classes
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/15 [SUREFIRE-933] repair parallel=classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-933 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/15.patch commit 9d742738b57336d374f240ccebff1ea9bfac5c92 Author: agudian andreas.gud...@gmail.com Date: 2012-12-15T20:42:09Z [SUREFIRE-933] repair parallel=classes - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-934] remove getLocatedClasses() and ...
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/14 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-933] Fix forkMode onceperthread afte...
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/13 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-934] remove getLocatedClasses() and ...
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/14 [SUREFIRE-934] remove getLocatedClasses() and size() from TestsToRun .. to avoid potential programming errors with forkMode=onceperthread You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-934 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/14.patch commit 0cb28a6de72ee273b0eea0213513bc213724 Author: agudian andreas.gud...@gmail.com Date: 2012-12-08T20:02:02Z [SUREFIRE-933] Tests not matching categories would fail build Fixed in a way that does not break forkMode=onceperthread (enhanced the IT for that), refined the logic of JUnitCoreProvider.canRunClass (to also detect the BasicTest class from the IT) Tests are now filtered right before handing them over to JUnit. In case of a NoTestsRemainException while filtering the test request, nothing will be handed over to JUnit. commit 705adb5aba2b704ad2bead4427e4182d34153715 Author: agudian andreas.gud...@gmail.com Date: 2012-12-09T22:17:53Z [SUREFIRE-934] remove getLocatedClasses() and size() from TestsToRun .., to avoid potential programming errors with forkMode=onceperthread - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-839] Tests not matching categories w...
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/12 [SUREFIRE-839] Tests not matching categories would fail build Fixed in a way that does not break forkMode=onceperthread (enhanced the IT for that), refined the logic of JUnitCoreProvider.canRunClass (to also detect the BasicTest class from the IT) You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-839 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/12.patch commit 769626abe5d01ac6d5b8e4f8cd01191734b8c93c Author: agudian andreas.gud...@gmail.com Date: 2012-12-08T20:02:02Z [SUREFIRE-839] Tests not matching categories would fail build Fixed in a way that does not break forkMode=onceperthread (enhanced the IT for that), refined the logic of JUnitCoreProvider.canRunClass (to also detect the BasicTest class from the IT) - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-839] Tests not matching categories w...
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/12 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: [SUREFIRE-839] Tests not matching categories w...
GitHub user agudian opened a pull request: https://github.com/apache/maven-surefire/pull/13 [SUREFIRE-839] Tests not matching categories would fail build Fixed in a way that does not break forkMode=onceperthread (enhanced the IT for that). Tests are now filtered right before handing them over to JUnit. In case of a NoTestsRemainException while filtering the test request, nothing will be handed over to JUnit. Please note: I have changed the expected number of error free tests in Surefire839TestWithoutCategoriesIT from 2 to 3. You can merge this pull request into a Git repository by running: $ git pull https://github.com/agudian/maven-surefire SUREFIRE-839 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/13.patch commit 769626abe5d01ac6d5b8e4f8cd01191734b8c93c Author: agudian andreas.gud...@gmail.com Date: 2012-12-08T20:02:02Z [SUREFIRE-839] Tests not matching categories would fail build Fixed in a way that does not break forkMode=onceperthread (enhanced the IT for that), refined the logic of JUnitCoreProvider.canRunClass (to also detect the BasicTest class from the IT) commit 6a70e29e2fb7f55ab69af4e1a3ff8d8d32314117 Author: agudian andreas.gud...@gmail.com Date: 2012-12-08T22:30:11Z [SUREFIRE-839] Tests not matching categories would fail build Tests are now filtered right before handing them over to JUnit. In case of a NoTestsRemainException while filtering the test request, nothing will be handed over to JUnit. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: forkMode onceperthread (SUREFIRE-751) (licence...
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/10 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: forkMode onceperthread (SUREFIRE-751) (licence...
GitHub user agudian opened a pull request:
https://github.com/apache/maven-surefire/pull/10
forkMode onceperthread (SUREFIRE-751) (licence headers included)
In relation to http://jira.codehaus.org/browse/SUREFIRE-751
Adds a new forkMode option onceperthread, that creates one reusable
forked process for each thread specified with the threadCount option. The tests
are handed out to the processes on-demand, i.e. as soon as a test class was
executed, a new class to execute is supplied by the parent process.
Adds a resulotion of the placeholder ${surefire.threadNumber} to the
number of the executing thread (range [1..threadCount]). The resolution takes
place in system properties in the argLine. E.g.
-DmyDatabaseSchema=TEST_SCHEMA_${surefire.threadNumber}. Works for all
forkModes (including never, which would resolve the placeholder to 1).
Integration Tests ForkModeIT and ForkModeNGIT have been extended to
cover both new features
Discussion in http://markmail.org/message/xn7bo4xxnzpvmskw
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agudian/maven-surefire
fm-onceperthread-rebased
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/10.patch
commit efff9ff7ea46a57682a54802fa127237c1842ba8
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-06T20:54:00Z
forkMode=onceperthread, working for JUnit providers - TestNG support sill
needs some work. Requires maven-shared-utils version 0.2 (or latest snapshot of
it).
Don't use the extra thread for reading the next test class
support of forkMode=onceperthread in TestNG provider
Adapt and add integration tests for forkMode=onceperthread
fix gathering test results with forkMode=onceperthread (fixes faild ITs)
commit 996c65a5fd25a43426461a5cae4e2809c1f5459a
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-16T22:05:14Z
Merge pull request #1 from krosenvold/master
Need a couple of license headers
commit f341dff9da23d5a2ae4ac6ffa1eb8dd8e27a855c
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-16T22:09:52Z
Added licence headers, javadoc, did some minor renaming
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: forkMode onceperthread (SUREFIRE-751)
Github user agudian closed the pull request at: https://github.com/apache/maven-surefire/pull/8 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: forkMode onceperthread (SUREFIRE-751)
GitHub user agudian opened a pull request:
https://github.com/apache/maven-surefire/pull/8
forkMode onceperthread (SUREFIRE-751)
In relation to http://jira.codehaus.org/browse/SUREFIRE-751
- Adds a new forkMode option onceperthread, that creates one reusable
forked process for each thread specified with the threadCount option. The tests
are handed out to the processes on-demand, i.e. as soon as a test class was
executed, a new class to execute is supplied by the parent process.
- Adds a resulotion of the placeholder ${surefire.threadNumber} to the
number of the executing thread (range [1..threadCount]). The resolution takes
place in system properties in the argLine. E.g.
-DmyDatabaseSchema=TEST_SCHEMA_${surefire.threadNumber}. Works for all
forkModes (including never, which would resolve the placeholder to 1).
- Integration Tests ForkModeIT and ForkModeNGIT have been extended to cover
both new features
Discussion in http://markmail.org/message/xn7bo4xxnzpvmskw
Open points:
- Source-code formatting, Apache file headers missing
- Some Javadoc here and there... I'll add that soon.
- refactoring of the forkMode options to simplify the usage? See my
proposals in the above mailing list thread... :)
- anything else? Let me know! :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agudian/maven-surefire fm-onceperthread
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/8.patch
commit a9f1c138464acd7762ccc3871672843696b0cc57
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-06T20:54:00Z
forkMode=onceperthread, working for JUnit providers - TestNG support sill
needs some work. Requires maven-shared-utils version 0.2 (or latest snapshot of
it).
commit ba2e51f215cbce21ee9833b13042466c7358f4ef
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-07T21:13:16Z
Don't use the extra thread for reading the next test class
commit cbb158aeecd90c2e7b61f5496a83a79018737421
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-11T20:37:34Z
[SUREFIRE-924] deploy Surefire plugins site in /surefire instead of
/plugins
[SUREFIRE-913] forkMode always - RejectedExecutionException when 500 tests
Fix as suggested by Garry Tully
commit 23c6caa76bca4905200ef1f3185d48a9c9939850
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-11T20:40:15Z
support of forkMode=onceperthread in TestNG provider
commit 27057cec3daebe73be28f39aeb12950588014e9b
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-11T23:05:30Z
Adapt and add integration tests for forkMode=onceperthread
commit 0660c167ed83ec1cff4ba1e2f3f4b039cbb92fee
Author: agudian andreas.gud...@gmail.com
Date: 2012-11-12T10:52:37Z
fix gathering test results with forkMode=onceperthread (fixes faild ITs)
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
