[GitHub] maven-plugins pull request #136: [MDEP-584] Update plexus-utils to 3.1.0
Github user io7m closed the pull request at: https://github.com/apache/maven-plugins/pull/136 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #137: [MJAVADOC-489] Find the main module descrip...
GitHub user io7m opened a pull request: https://github.com/apache/maven-plugins/pull/137 [MJAVADOC-489] Find the main module descriptor The existing code was checking for the existence of a file "src/main/module-info.java" relative to the current directory. The problem is that in a multi-module build, the current directory is the project root, not the root of the current module. As a result, the module descriptor was not being found and all dependencies were ending up on the classpath instead. Fixes: MJAVADOC-489 You can merge this pull request into a Git repository by running: $ git pull https://github.com/io7m/maven-plugins MJAVADOC-489 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit 72046ff41b90a7667b07396623487f128542922f Author: Mark Raynsford <c...@io7m.com> Date: 2017-11-18T11:43:45Z [MJAVADOC-489] Find the main module descriptor The existing code was checking for the existence of a file "src/main/module-info.java" relative to the current directory. The problem is that in a multi-module build, the current directory is the project root, not the root of the current module. As a result, the module descriptor was not being found and all dependencies were ending up on the classpath instead. Fixes: MJAVADOC-489 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #136: [MDEP-584] Update plexus-utils to 3.1.0
GitHub user io7m opened a pull request: https://github.com/apache/maven-plugins/pull/136 [MDEP-584] Update plexus-utils to 3.1.0 This updates the plexus-utils dependency to 3.1.0. It corrects four unit tests that were failing due to new behaviour in 3.1.0: It appears that the new plexus-utils copies the lastModified attributes of files, and the old tests were implicitly depending on the attributes not being copied. Fixes: MDEP-584 You can merge this pull request into a Git repository by running: $ git pull https://github.com/io7m/maven-plugins MDEP-584 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/136.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #136 commit 178f30ff90efd73276ef636114377d74d047af11 Author: Mark Raynsford <c...@io7m.com> Date: 2017-11-18T11:38:40Z [MDEP-584] Update plexus-utils to 3.1.0 This updates the plexus-utils dependency to 3.1.0. It corrects four unit tests that were failing due to new behaviour in 3.1.0: It appears that the new plexus-utils copies the lastModified attributes of files, and the old tests were implicitly depending on the attributes not being copied. Fixes: MDEP-584 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #135: [MDEP-584] Update plexus-utils to 3.1.0
Github user io7m closed the pull request at: https://github.com/apache/maven-plugins/pull/135 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #135: [MDEP-584] Update plexus-utils to 3.1.0
GitHub user io7m opened a pull request: https://github.com/apache/maven-plugins/pull/135 [MDEP-584] Update plexus-utils to 3.1.0 This updates the plexus-utils dependency to 3.1.0. It corrects four unit tests that were failing due to new behaviour in 3.1.0: It appears that the new plexus-utils copies the lastModified attributes of files, and the old tests were implicitly depending on the attributes not being copied. Fixes: MDEP-584 You can merge this pull request into a Git repository by running: $ git pull https://github.com/io7m/maven-plugins trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #135 commit 59c0f89db6e69e8c4287c9dee07b831b26fcbca3 Author: Mark Raynsford <c...@io7m.com> Date: 2017-11-15T15:28:27Z [MDEP-584] Update plexus-utils to 3.1.0 This updates the plexus-utils dependency to 3.1.0. It corrects four unit tests that were failing due to new behaviour in 3.1.0: It appears that the new plexus-utils copies the lastModified attributes of files, and the old tests were implicitly depending on the attributes not being copied. Fixes: MDEP-584 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #104: MASSEMBLY-848 Do not attempt to resolve rea...
Github user io7m closed the pull request at: https://github.com/apache/maven-plugins/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #104: MASSEMBLY-848 Do not attempt to resolve rea...
GitHub user io7m opened a pull request: https://github.com/apache/maven-plugins/pull/104 MASSEMBLY-848 Do not attempt to resolve reactor projects I'm submitting this pull request in the hope of getting some discussion on the issue. I feel like the submitted fix here is not the right way to solve this problem but do not understand enough of the way Maven resolves artifacts to be sure. This change does at least appear to resolve the provided integration test properly and does not break any existing tests. ``` This is an attempt at addressing MASSEMBLY-848: When resolving the dependencies of a project, we explicitly avoid attempting to resolve any dependency artifacts that are also reactor projects. ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/io7m/maven-plugins trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit c1c9576c7cedc3cfb06d79350251f2a4296b308c Author: Mark Raynsford <c...@io7m.com> Date: 2017-02-22T20:36:09Z MASSEMBLY-848 Do not attempt to resolve reactor projects This is an attempt at addressing MASSEMBLY-848: When resolving the dependencies of a project, we explicitly avoid attempting to resolve any dependency artifacts that are also reactor projects. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
