[GitHub] maven issue #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/153 I don't see that piece of code, but if it works, that's fine. Jason added a comment about exposing them as System properties. I don't think we should remove that right now, but with a major version. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugin-testing issue #4: Added support for plugins without configurati...
Github user rfscholte commented on the issue: https://github.com/apache/maven-plugin-testing/pull/4 Do you know the reason why somebody implemented the `ConfigurationException` being thrown? --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/87 @rajivpjs can you close this pullrequest? This open PR causes warnings for https://issues.apache.org/jira/browse/MNG-5457 on the release page. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #114: MNG-6220 add color CLI option
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/114 Here's my proposal: https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=fd57754218e749305be1dd745fda9407960cf985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/89 Based on the recent messages on the mailing thread I assumed you are an active Maven user who wants to use the most recent version of Maven. My guess was right :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/89 Looks to me you're still testing with the installed version of Maven( e.g. 3.3.9), not your own fresh build. Instead try `/Users/rajivpjs/Desktop/Apache/Maven/rajivpjs/maven/mavenfixtarget/bin/mvn clean package -V` (the -V must confirm you're testing the right version). I should warn you that this issue is very hard to fix without in dept knowledge of Maven. There are probably other issues which are easier to fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...
Github user rfscholte commented on the issue: https://github.com/apache/maven-scm/pull/31 > What scares me is that this code appears to be quite sensitive to changes I totally agree. I tested with making changedFiles relative to repo instead of working directory and all unittests stayed green. That is not a good sign, so we must really work on that too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...
Github user rfscholte commented on the issue: https://github.com/apache/maven-scm/pull/31 https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumerTest.java#L191 confirms this if you see that subDirectory is actually the working directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...
Github user rfscholte commented on the issue: https://github.com/apache/maven-scm/pull/31 I think we missed something. `GitStatusConsumer` says /** * Entries are relative to working directory, not to the repositoryroot */ private List changedFiles = new ArrayList(); That was probably true before introducing the `--porcelain` argument, because the related git-status docs says Porcelain Format The porcelain format is similar to the short format, but is guaranteed not to change in a backwards-incompatible way between Git versions or based on user configuration. This makes it ideal for parsing by scripts. The description of the short format above also describes the porcelain format, with a few exceptions: 1.The userâs color.status configuration is not respected; color will always be off. 2.The userâs status.relativePaths configuration is not respected; paths shown will always be relative to the repository root. So we need to go through the codebase to verify if the proper paths are used. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-scm pull request: SCM-714 fix git commit when command line g...
Github user rfscholte commented on the pull request: https://github.com/apache/maven-scm/pull/41#issuecomment-165988127 This might be an interesting solution, but I really want the current behavior to be the default. Pattern based files might not select the correct set of files. I first would like to advice to switch to http://maven.apache.org/scm/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/index.html , or have an implementation where people can use filepatterns if they want. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: - logging configuration now no longer overwrit...
Github user rfscholte commented on the pull request: https://github.com/apache/maven/pull/22#issuecomment-46476155 I read about the failing test. I'm looking for the differences. I've tried it with 1.7.0_55 as well, still that test succeeds. So it failure is either caused by the OS, the default locale or the way Maven is started. For instance, I use the `cmd.exe` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: - logging configuration now no longer overwrit...
Github user rfscholte commented on the pull request: https://github.com/apache/maven/pull/22#issuecomment-46347052 Works fine on my system: Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T18:37:52+01:00) Maven home: D:\apache-maven-3.2.1\bin\.. Java version: 1.7.0_45, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_45\jre Default locale: nl_NL, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows What's yours? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
