[GitHub] maven-plugins pull request #104: MASSEMBLY-848 Do not attempt to resolve rea...

[io7m]

Github user io7m closed the pull request at:

https://github.com/apache/maven-plugins/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-plugins pull request #104: MASSEMBLY-848 Do not attempt to resolve rea...

[io7m]

GitHub user io7m opened a pull request:

https://github.com/apache/maven-plugins/pull/104

MASSEMBLY-848 Do not attempt to resolve reactor projects

I'm submitting this pull request in the hope of getting some discussion on 
the issue. I feel like the submitted fix here is not the right way to solve 
this problem but do not understand enough of the way Maven resolves artifacts 
to be sure. This change does at least appear to resolve the provided 
integration test properly and does not break any existing tests.

```
This is an attempt at addressing MASSEMBLY-848: When resolving the
dependencies of a project, we explicitly avoid attempting to resolve
any dependency artifacts that are also reactor projects.
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/io7m/maven-plugins trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-plugins/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #104


commit c1c9576c7cedc3cfb06d79350251f2a4296b308c
Author: Mark Raynsford 
Date:   2017-02-22T20:36:09Z

MASSEMBLY-848 Do not attempt to resolve reactor projects

This is an attempt at addressing MASSEMBLY-848: When resolving the
dependencies of a project, we explicitly avoid attempting to resolve
any dependency artifacts that are also reactor projects.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org